From nobody Fri Apr 29 23:12:46 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 66CDB1ABD543; Fri, 29 Apr 2022 23:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqpDb3Ztwz3w6H; Fri, 29 Apr 2022 23:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651273967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G/LsporzGv2sTriI6EeCxbi9mGNLbS8+j1PD6G0x+Jk=; b=NRJcHIeHpKcmTJoRyYG1o1TeLkY1WXw5zgF+apbNayTRb1uxL6YUTBC9zFGVreIIhTOG4V oHOVua+fTZTlnZw41hHmL1ulNOzs4WmGEzbXhhhw6NdCZQVC9DIowypL7AE0rvQM3dXxUO WRM/3Jmzu2Ru4ug2ylgOnuNmeT7kGbiVbxVpDgVbTazSf5Ul7mSOkTpKs/M2v06XPBNzrs jcivwuE8Qwcy9iCjovS2dUKquCsmZiZbZGMpxOjqURoqd4JlMbJQ5VUUCMhXFQp3mLZbPf rNV6SETB82GsSbIoA5CLFwnGCPAD4CMcfYXinF9wJASIKrVYzC4lYKcSJHXGOw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9AA9316307; Fri, 29 Apr 2022 23:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23TNCkht045099; Fri, 29 Apr 2022 23:12:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23TNCkmQ045098; Fri, 29 Apr 2022 23:12:46 GMT (envelope-from git) Date: Fri, 29 Apr 2022 23:12:46 GMT Message-Id: <202204292312.23TNCkmQ045098@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: d538e52c515b - stable/13 - ctl ramdisk: Free compare buffer after a compare I/O request. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d538e52c515b334a9e8f6b48abe08e03b8cdeafb Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651273967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G/LsporzGv2sTriI6EeCxbi9mGNLbS8+j1PD6G0x+Jk=; b=DXiRcRHc5iG4tIY6GenY1Ulon4BZZ6dfx48bB4Arb0tOd5Tkzh6TORa9KI9NixIArNsvTK xpxIEF6H9xA7rsgHE9oJvJmHnJNUByvc0/DGkoEk+Tse5MB/FSJqneOst+xmRNkJzaTG8M fVvQi81puabgMsIYNm7GLGfDCUcqQtFAghsUKeM7RBCwWfk1SogQEYMAdjY9bY4GM/6vdW sJ+uyE2usvZyMFDICcPPGPOMXqA1lZHnbwRRktNUqfMW5lebGz/RDBuCijfyDFQ/80G8Z0 DBWVUI2kTeMt/fSi0g8p9s73b3FdFUEzwh1Qr7OBtVCVBvlbDEt3SSFGJCIw2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651273967; a=rsa-sha256; cv=none; b=dBNaTfqRbXyBQ3msF0lYAgwim4gqTY+3obFuUhIpoDGhtUkd7KQgTYCIs2aFx9jWEo3SFO Yooj+XKMv7ekeTlOSrtLvR3P/VuLZTqWPhOPEEhQxrfdH4N5nmFVUxduYn/dqkaeMbwVum N0kRhH02bWYeb2CUJ2UW4rFE0zpHtDHFnecuHUv82UrZLmPvRYU7VRvuUYYr5TFOxFsRO3 yFmZCdKNaBu8PJ5ZSJ2j6fVtzhQwBGLQ7OHB386KxfzPhJXTJBJ4i8ujsW0/qZ/tJv1aPz YGqvTzD45qXA/MiDoDB1KsXPRKMEdghEcH2sxM1ZkBqtScwXnPN7pHkjPd6Z/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d538e52c515b334a9e8f6b48abe08e03b8cdeafb commit d538e52c515b334a9e8f6b48abe08e03b8cdeafb Author: John Baldwin AuthorDate: 2022-02-18 23:20:14 +0000 Commit: John Baldwin CommitDate: 2022-04-29 23:09:48 +0000 ctl ramdisk: Free compare buffer after a compare I/O request. For a compare request, the ramdisk backend allocates a temporary buffer to hold the I/O data and then compares it against the LUN's pages in ctl_backend_ramdisk_cmp after the data has been filled. However, the tempory buffer was leaked when after the comparison was complete. Fix this by freeing the buffer after the comparison. Reviewed by: mav Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D34316 (cherry picked from commit bd6e8729d6f6d42102b0359b56b7e3c89edd0ec9) --- sys/cam/ctl/ctl_backend_ramdisk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/cam/ctl/ctl_backend_ramdisk.c b/sys/cam/ctl/ctl_backend_ramdisk.c index 6febdd469bdd..9ddee1814aa1 100644 --- a/sys/cam/ctl/ctl_backend_ramdisk.c +++ b/sys/cam/ctl/ctl_backend_ramdisk.c @@ -386,6 +386,7 @@ ctl_backend_ramdisk_cmp(union ctl_io *io) if (res < cbe_lun->blocksize) break; } + free(io->scsiio.kern_data_ptr, M_RAMDISK); if (lbas > 0) { off += io->scsiio.kern_rel_offset - io->scsiio.kern_data_len; scsi_u64to8b(off, info);