From nobody Mon Apr 25 13:01:00 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 102D01A918F9; Mon, 25 Apr 2022 13:01:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kn4rX74wZz4j4C; Mon, 25 Apr 2022 13:01:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650891661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kl0iiomPTT+IyQj3kyqiFnn+c6662p6D8u4U97eEgjU=; b=bgC9OrqDYWjoJohFms5FZFoeb+uuse6YgyWmbz7MZQMcbwmzADpSVdYG2Gy61OVNIDlBeW afCFnQHxYsiIo7pvIUT72Qo0KDGDmbT/da4FXw3LmxI6Icj7YIREoEZteDp6Jg1oxGF2NL ydl7B2Cc9/QtbYm2km0WZLMGdmA0CGKIOJN0VU9sbQXD1dTIunTTqk2Slq59zEgYgBZl6i zr4iewx8VEH8natsCX5ZDSbXwxim0NaEvPGLGJeNB117nSRuwG3/nFo/2ByJUm8M1E8pGw FgK2sDeBtLl/6/2sft3kiyErn518Bgnsc4Z1UxYrW8OT5V6C4ZUwOOMI8RHDBw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3C911B480; Mon, 25 Apr 2022 13:01:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23PD10Bg019302; Mon, 25 Apr 2022 13:01:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23PD10SM019301; Mon, 25 Apr 2022 13:01:00 GMT (envelope-from git) Date: Mon, 25 Apr 2022 13:01:00 GMT Message-Id: <202204251301.23PD10SM019301@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 00193c79b420 - stable/13 - path_test: Verify that operations on unlinked files work List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 00193c79b4206ba8d576ae12a002340d7d1bd4ec Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650891661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kl0iiomPTT+IyQj3kyqiFnn+c6662p6D8u4U97eEgjU=; b=hg4OW8kWgx/SWGW+dZMwAMMea07faixFGyY8Xj6p8DB2argst5GQpm5dnOYhYsFs6jk1CD jroon943ZXLSwFk6G2vAXt+8Z+xix6+MorM2xdNjao5Zbd90ptquIdTIMoELCVPJpkOIpO TkM5d2kRZSwuX3/xf+X28MoqVMghDlZRF8jxZcAtjiYXwWuNii73G95tMjh1frePr4oNtz VFUBXerWry559WF/vZgXDNIimEgBkxiKT9qxqj4NKPIpuHef0TbHMh9fcm+QjPqknb84yy PJ53e62VPDiqYirFJv9dA/sZT81SdvIwbSqnlrYrSPM/vEFi5/zFLHYDooAamA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650891661; a=rsa-sha256; cv=none; b=IZriV6mt9AN48ukbH2ic1wH63EEEEhTdsUIPidoqavhd7Et7rmPWyORSuBqRHje5vMsFci QzNM9q70qG4Cn92CgXWXZVGQOxEiwoloblSfokpLHzjowLGAi4zNWRajsAgFXH5tQfLyCU SKpSEN8G41/6+hOAYq7SJjPt/SS52T4Kvo6UIA5xmKrYXMxYJAPoaSxkqlfU2KewlARVeX drZJmM5b1vh6ILpGf8OXUtfnNUC1fVQV4Avb3YWIPCT7qxVbuJqqpumySpr2EynZ4Sea2t JztpbtYGcSGY27kr+8VdIVt3kSA0+fwydHzFh2F3kpvqsJgTuCWp8npRwOe/AQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=00193c79b4206ba8d576ae12a002340d7d1bd4ec commit 00193c79b4206ba8d576ae12a002340d7d1bd4ec Author: Mark Johnston AuthorDate: 2022-04-18 21:46:04 +0000 Commit: Mark Johnston CommitDate: 2022-04-25 12:59:18 +0000 path_test: Verify that operations on unlinked files work Sponsored by: The FreeBSD Foundation (cherry picked from commit b13ac678420292f5994b0b6e0f27995b9399268b) --- tests/sys/file/path_test.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tests/sys/file/path_test.c b/tests/sys/file/path_test.c index b4411b67f26d..216782a5f2bc 100644 --- a/tests/sys/file/path_test.c +++ b/tests/sys/file/path_test.c @@ -898,6 +898,38 @@ ATF_TC_BODY(path_unix, tc) CHECKED_CLOSE(pathfd); } +/* + * Check that we can perform operations using an O_PATH fd for an unlinked file. + */ +ATF_TC_WITHOUT_HEAD(path_unlinked); +ATF_TC_BODY(path_unlinked, tc) +{ + char path[PATH_MAX]; + struct stat sb; + int pathfd; + + mktfile(path, "path_rights.XXXXXX"); + + pathfd = open(path, O_PATH); + ATF_REQUIRE_MSG(pathfd >= 0, FMT_ERR("open")); + + ATF_REQUIRE_MSG(fstatat(pathfd, "", &sb, AT_EMPTY_PATH) == 0, + FMT_ERR("fstatat")); + ATF_REQUIRE(sb.st_nlink == 1); + ATF_REQUIRE_MSG(fstat(pathfd, &sb) == 0, FMT_ERR("fstat")); + ATF_REQUIRE(sb.st_nlink == 1); + + ATF_REQUIRE_MSG(unlink(path) == 0, FMT_ERR("unlink")); + + ATF_REQUIRE_MSG(fstatat(pathfd, "", &sb, AT_EMPTY_PATH) == 0, + FMT_ERR("fstatat")); + ATF_REQUIRE(sb.st_nlink == 0); + ATF_REQUIRE_MSG(fstat(pathfd, &sb) == 0, FMT_ERR("fstat")); + ATF_REQUIRE(sb.st_nlink == 0); + + CHECKED_CLOSE(pathfd); +} + ATF_TP_ADD_TCS(tp) { ATF_TP_ADD_TC(tp, path_access); @@ -920,6 +952,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, path_pipe_fstatat); ATF_TP_ADD_TC(tp, path_rights); ATF_TP_ADD_TC(tp, path_unix); + ATF_TP_ADD_TC(tp, path_unlinked); return (atf_no_error()); }