From nobody Mon Apr 11 13:44:02 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BB6961A85DEE; Mon, 11 Apr 2022 13:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KcVSg2gXxz4vRh; Mon, 11 Apr 2022 13:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649684643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P2kWcLEAlS0I+VZjA5X728YpFUi9jJUzjnZ5m15Bhu4=; b=mDplvwA48XUvyzyq4Y4OGK2NI1/SCIP92lZEU/jarOQPWp/+t5HvLhGA0A/R3ltK/YBlhz dPJ7K+ah7Oa7QfeNL4gmIzeXu6aabaXTdB2m+9lslNhbQJrjU4z+xtPkJEkBflnHg+/NtV iz1eZ5dcXbT/bUCy4/qn2BRnq1736dE3MRSxRWv+f7JyC6OKLVIVlq794/ub5j9aoUiCo/ AFqe/RmH/drpxOk3KJtxPT1fRingSf+3Z9oFxAwdz+/MMTGHh2XP/rsMGwzGixvbogOiP7 tphkZACSfytiI1Pv2OEMBqKhO8ctnAAR0bHgVkp0dK6kmkVBT5OffbOdRioq+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1A55823FCA; Mon, 11 Apr 2022 13:44:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23BDi2jY029017; Mon, 11 Apr 2022 13:44:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23BDi2oh029016; Mon, 11 Apr 2022 13:44:02 GMT (envelope-from git) Date: Mon, 11 Apr 2022 13:44:02 GMT Message-Id: <202204111344.23BDi2oh029016@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 97d99787446f - stable/13 - audit: Initialize vattr fields before calling VOP_GETATTR List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 97d99787446fa48228d56973291ef3ae1f78ea66 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649684643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P2kWcLEAlS0I+VZjA5X728YpFUi9jJUzjnZ5m15Bhu4=; b=uL76ezwMiMeFAiGzmX55aAZlAuf9aoDLSR/FBYux5mFo7Al0vD5b/xuEradwUTtHTsRvt1 PdpDg293sxFjkSW1R/IoeZin5nBYOFc2MbgMRYB2J/5C/l40leuPggxmLTfDqe9bGTFeR0 G8UFFraF7WBz4qXeXDBJJmyNXvjwSc7masOVw1A+ayp8FOgmRDnLVi1IqHmiH+8fSvcXfo mqCLyorazDLF60gkZwPabs4nSJal1ZD79itaeXpG7mvpODgryPL4EZJhBdRRKiiiGMdApY xUYw5jkW2O2xfLmOxw19le8faf+oxRuJP6BDICfQxbMxBdYlqIvwZxhiCV6J9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649684643; a=rsa-sha256; cv=none; b=SUkvk2XRkbJBQocuXoHMafcnhLX7HiyCT7NYVYM8k1NNU3D9imlJNBuKdVBqlmH24Ggxgj YkZU1q9Tv5ddVbJnc5RXfGMZaDDtx41lTu9MIj/0Vl3YEPXjAHBmoXBBS14vY5FiFk6exU YEqZzmZ5OnfiDPYWpx9bw0wlf/efTA+jNuj4032kD/86Cu+XkVqUvRmGhnRd9yHVOjTTHw Xd0eNwADBAGu6zCqemp7cqCwz9h2D5kdsFSLxj8wNGCihfrkHUJD+LHo3Dx9OUOzyb//pt gV1k+Kk+Zkh6l4l9P0WAqBcYQaE0Y6mgn1YzvemXs3NgR3aWLBMA6dp7Xz7QTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=97d99787446fa48228d56973291ef3ae1f78ea66 commit 97d99787446fa48228d56973291ef3ae1f78ea66 Author: Mark Johnston AuthorDate: 2022-03-20 01:59:13 +0000 Commit: Mark Johnston CommitDate: 2022-04-11 13:43:27 +0000 audit: Initialize vattr fields before calling VOP_GETATTR Some filesystems do not fill out certain optional vattr fields. To ensure that they do not get copied out to userspace uninitialized, use VATTR_NULL to provide default values. Reported by: KMSAN Sponsored by: The FreeBSD Foundation (cherry picked from commit ecd764b0ea7a1b7fb5f1e6632f8d8db9233f06ea) --- sys/security/audit/audit_arg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/security/audit/audit_arg.c b/sys/security/audit/audit_arg.c index a917b5b6e297..7e0b0de2abff 100644 --- a/sys/security/audit/audit_arg.c +++ b/sys/security/audit/audit_arg.c @@ -873,6 +873,7 @@ audit_arg_vnode(struct vnode *vp, struct vnode_au_info *vnp) ASSERT_VOP_LOCKED(vp, "audit_arg_vnode"); + VATTR_NULL(&vattr); error = VOP_GETATTR(vp, &vattr, curthread->td_ucred); if (error) { /* XXX: How to handle this case? */