From nobody Fri Oct 08 06:11:19 2021 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8D52E12D46B3; Fri, 8 Oct 2021 06:11:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQd9y4065z3LWl; Fri, 8 Oct 2021 06:11:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2C3B022081; Fri, 8 Oct 2021 06:11:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1986BJor007896; Fri, 8 Oct 2021 06:11:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1986BJcY007895; Fri, 8 Oct 2021 06:11:19 GMT (envelope-from git) Date: Fri, 8 Oct 2021 06:11:19 GMT Message-Id: <202110080611.1986BJcY007895@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: a7c75ee92b0e - stable/12 - ficl: instead of pad, emit can use local variable List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: a7c75ee92b0edb8ab591f68fe2038de3b68fc031 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=a7c75ee92b0edb8ab591f68fe2038de3b68fc031 commit a7c75ee92b0edb8ab591f68fe2038de3b68fc031 Author: Toomas Soome AuthorDate: 2020-12-01 22:28:02 +0000 Commit: Kyle Evans CommitDate: 2021-10-08 05:24:28 +0000 ficl: instead of pad, emit can use local variable Pad in forth is used as "scratchpad" and internal implementations should not use it. Ficl does not really follow this rule and this can fire back. emit has no need to use pad, we can use local variable instead. (cherry picked from commit dba7640e44c5ec148a84b0d58c6c9a3c9e5147f3) --- stand/ficl/words.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/ficl/words.c b/stand/ficl/words.c index 54257275d5cc..3f781c6d2ff4 100644 --- a/stand/ficl/words.c +++ b/stand/ficl/words.c @@ -1015,7 +1015,7 @@ static void twoSwap(FICL_VM *pVM) static void emit(FICL_VM *pVM) { - char *cp = pVM->pad; + char cp[2]; int i; #if FICL_ROBUST > 1