From nobody Thu Oct 07 07:06:08 2021 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 43F0012BE66A; Thu, 7 Oct 2021 07:06:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQ2Rc1Qdtz3k2S; Thu, 7 Oct 2021 07:06:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 1153325781; Thu, 7 Oct 2021 07:06:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f45.google.com with SMTP id k3so3549554qve.10; Thu, 07 Oct 2021 00:06:20 -0700 (PDT) X-Gm-Message-State: AOAM532/FdSEw0NbLnCUF9ntNEyFx/O8yQxlUWrtykkonCDsozXshkb9 m+8HV74TUgd2tyQhj/YFLWIPDNHAM+cZf85lzhg= X-Google-Smtp-Source: ABdhPJz2ZO7hr+74kpSj1iEawZDDa+EnxpcrErvxikkyX+WNkOBYyWHe555EbbmXa/eTkOXnhCB4RTmmJN49DsGU+sg= X-Received: by 2002:a05:6214:13ce:: with SMTP id cg14mr2653845qvb.51.1633590379711; Thu, 07 Oct 2021 00:06:19 -0700 (PDT) List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 References: <202110070337.1973bgRH073900@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Thu, 7 Oct 2021 02:06:08 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 000aad3d093a - stable/12 - loader: allocate properly aligned buffer for network packet To: Alexey Dokuchaev Cc: src-committers , "" , dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-ThisMailContainsUnwantedMimeParts: N On Thu, Oct 7, 2021 at 1:50 AM Alexey Dokuchaev wrote: > > On Thu, Oct 07, 2021 at 01:20:05AM -0500, Kyle Evans wrote: > > On Thu, Oct 7, 2021 at 1:06 AM Alexey Dokuchaev wrote: > > > On Thu, Oct 07, 2021 at 03:37:42AM +0000, Kyle Evans wrote: > > > > commit 000aad3d093a376bb1104a284b4102149db43155 > > > > > > > > loader: allocate properly aligned buffer for network packet > > > > > > > > Use memalign(4, size) to ensure we have properly aligned buffer. > > > > > > > > (cherry picked from commit 659bf32dfc595b6cd6aeda7f05cb57872c64d2d1) > > > > > > I don't understand, so this is a merge of the commit from master (main) to > > > stablle/12 which had then been reverted? So why do the merge in the first > > > place? > > > > Because commit + revert pairs are noise in the MFC tracker that > > distracts from actual candidates for merging. > > Sounds like MFC tracker should be fixed then, as now it is noise in > the tool (tracker) vs. noise in the branch. Tools come and go, and > code stays forever. > Nah, the tool's fine.