From nobody Thu Oct 07 07:03:40 2021 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5E74B12BDA75; Thu, 7 Oct 2021 07:03:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQ2Nc2CfDz3jMK; Thu, 7 Oct 2021 07:03:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from [192.168.0.88] (unknown [195.64.148.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: avg/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7B8B625438; Thu, 7 Oct 2021 07:03:43 +0000 (UTC) (envelope-from avg@FreeBSD.org) Subject: Re: git: 000aad3d093a - stable/12 - loader: allocate properly aligned buffer for network packet To: Alexey Dokuchaev , Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org References: <202110070337.1973bgRH073900@gitrepo.freebsd.org> From: Andriy Gapon Message-ID: <87d1289f-7478-8cad-addb-e7f36c112a20@FreeBSD.org> Date: Thu, 7 Oct 2021 10:03:40 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 07/10/2021 09:50, Alexey Dokuchaev wrote: > On Thu, Oct 07, 2021 at 01:20:05AM -0500, Kyle Evans wrote: >> On Thu, Oct 7, 2021 at 1:06 AM Alexey Dokuchaev wrote: >>> On Thu, Oct 07, 2021 at 03:37:42AM +0000, Kyle Evans wrote: >>>> commit 000aad3d093a376bb1104a284b4102149db43155 >>>> >>>> loader: allocate properly aligned buffer for network packet >>>> >>>> Use memalign(4, size) to ensure we have properly aligned buffer. >>>> >>>> (cherry picked from commit 659bf32dfc595b6cd6aeda7f05cb57872c64d2d1) >>> >>> I don't understand, so this is a merge of the commit from master (main) to >>> stablle/12 which had then been reverted? So why do the merge in the first >>> place? >> >> Because commit + revert pairs are noise in the MFC tracker that >> distracts from actual candidates for merging. > > Sounds like MFC tracker should be fixed then, as now it is noise in > the tool (tracker) vs. noise in the branch. Tools come and go, and > code stays forever. I agree. And the MFC tracker (mfc.kernelnomicon.org) has "Never MFC" button if you changed your mind about a commit. -- Andriy Gapon