From nobody Thu Oct 07 06:50:21 2021 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E127B12BB264; Thu, 7 Oct 2021 06:50:21 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQ2595jHFz3QLT; Thu, 7 Oct 2021 06:50:21 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633589421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kgxGcA2sKqmevpyKCk0Wak4bgShV9vi5PvIgNtfbdK4=; b=e4zRql9h0pGDZRabUmzqNcVqREe7ciXjA5lgWtO/sXjA7rqXitGxv2TZtQMOJK+/eK5+yv vCUHfXIAfJPqQW0iCj5jDxbteJIc9aWdP3Ag9oGblzg28G1dYd/pQ1IXJgj/RtQFc2ToBC 5jfU2WedC+MEA+1v1/kknkBpcesYpXWKDX5ns+C2Jaz/JLWtzOwpfYHb4Q/F1XP4qSm8uE 0R6MRIxSfM7ETnPnT8w4O38/wDPyQPKzFyLKb5nI1fzabdBRfM+FO3LNQ6fq4kmdlNB6pW nJ7y8HIjM0ou0JM3aIatwukVGXxaNP69BErUz5BRL93e67z+ADzKQ+eSZM5FbQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id B097D15AC0; Thu, 7 Oct 2021 06:50:21 +0000 (UTC) Date: Thu, 7 Oct 2021 06:50:21 +0000 From: Alexey Dokuchaev To: Kyle Evans Cc: src-committers , "" , dev-commits-src-branches@freebsd.org Subject: Re: git: 000aad3d093a - stable/12 - loader: allocate properly aligned buffer for network packet Message-ID: References: <202110070337.1973bgRH073900@gitrepo.freebsd.org> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1633589421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kgxGcA2sKqmevpyKCk0Wak4bgShV9vi5PvIgNtfbdK4=; b=ZImb254ribe4mmliCejI3poffPO7UAGw+49b/2weUpvHxNE6Ry8Wx2dy7j00baussGaKIE 2QMVCIaSKf4OnT8+V3O5oe4X2HT5n8K+X6sB4gwH90b79LwowtMEGCCsFVfo65SO5OTDO3 cm9CAyRLQO9E5DSMm8owTVCgjOKwgJW4kJ8IgNTARq5u1DRtilky9c1ecba8dxoLb1jdSP gZFdDbvEIHEuQspR2EE5A8oOx+wVKnfjU71IjbfEB08kd/U/B8i6trTMNccjiBHLSZjVfq 234y8OMXLDC+8riaoGyxDESB8yBvHgTMDoQ8sTiixYxc6QhOa/yNCtGAAk130Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1633589421; a=rsa-sha256; cv=none; b=dmb/J4FGYfHSUWinv3GtuLsPtv7mYqp/Thh7ryt9vcDNWooIouhtg/XJKQlTThVhDSr3yr lFgbaWwrKPtDKNXZttU78v7LZwm8AsQiKRtlMwbmM7VAc7YW9cDJ6wSOToOMuMkLTWxR1Y Q54aojVu4Mw6AeqYyw1iSSFi0J8euNNcPry5K2aeho55HUzfB27q/5Mpc18uycrveLAbdi 4m5w69YkNlIcgZ0jvbS3GFWeCIMljAHQLMzChUb3JbZtm0FJpFu8zQIRJNfrWxdPTpvhee qTeCMDtNU0I/SH8JJ69brr/BU1Clzq7a9Xk9m4CphJB+ov1fYFdo3Meilz6r/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Oct 07, 2021 at 01:20:05AM -0500, Kyle Evans wrote: > On Thu, Oct 7, 2021 at 1:06 AM Alexey Dokuchaev wrote: > > On Thu, Oct 07, 2021 at 03:37:42AM +0000, Kyle Evans wrote: > > > commit 000aad3d093a376bb1104a284b4102149db43155 > > > > > > loader: allocate properly aligned buffer for network packet > > > > > > Use memalign(4, size) to ensure we have properly aligned buffer. > > > > > > (cherry picked from commit 659bf32dfc595b6cd6aeda7f05cb57872c64d2d1) > > > > I don't understand, so this is a merge of the commit from master (main) to > > stablle/12 which had then been reverted? So why do the merge in the first > > place? > > Because commit + revert pairs are noise in the MFC tracker that > distracts from actual candidates for merging. Sounds like MFC tracker should be fixed then, as now it is noise in the tool (tracker) vs. noise in the branch. Tools come and go, and code stays forever. ./danfe