git: ec5691aa2f96 - stable/13 - net: Allow binding of unspecified address without address existance

The branch stable/13 has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=ec5691aa2f96d27c8f000486a9e3297c2dce31b9

commit ec5691aa2f96d27c8f000486a9e3297c2dce31b9
Author:     Roy Marples <roy@marples.name>
AuthorDate: 2021-10-20 15:47:29 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-11-19 00:28:56 +0000

    net: Allow binding of unspecified address without address existance
    
    Previously in_pcbbind_setup returned EADDRNOTAVAIL for empty
    V_in_ifaddrhead (i.e., no IPv4 addresses configured) and in6_pcbbind
    did the same for empty V_in6_ifaddrhead (no IPv6 addresses).
    
    An equivalent test has existed since 4.4-Lite.  It was presumably done
    to avoid extra work (assuming the address isn't going to be found
    later).
    
    In normal system operation *_ifaddrhead will not be empty: they will
    at least have the loopback address(es).  In practice no work will be
    avoided.
    
    Further, this case caused net/dhcpd to fail when run early in boot
    before assignment of any addresses.  It should be possible to bind the
    unspecified address even if no addresses have been configured yet, so
    just remove the tests.
    
    The now-removed "XXX broken" comments were added in 59562606b9d3,
    which converted the ifaddr lists to TAILQs.  As far as I (emaste) can
    tell the brokenness is the issue described above, not some aspect of
    the TAILQ conversion.
    
    PR:             253166
    Reviewed by:    ae, bz, donner, emaste, glebius
    MFC after:      1 month
    Differential Revision:  https://reviews.freebsd.org/D32563
    
    (cherry picked from commit 5c5340108e9c2e384ca646720e17d037c69acc4c)
---
 sys/netinet/in_pcb.c   | 2 --
 sys/netinet6/in6_pcb.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c
index 8b109bce9dff..c3ad7e9b6bc6 100644
--- a/sys/netinet/in_pcb.c
+++ b/sys/netinet/in_pcb.c
@@ -932,8 +932,6 @@ in_pcbbind_setup(struct inpcb *inp, struct sockaddr *nam, in_addr_t *laddrp,
 	INP_LOCK_ASSERT(inp);
 	INP_HASH_LOCK_ASSERT(pcbinfo);
 
-	if (CK_STAILQ_EMPTY(&V_in_ifaddrhead)) /* XXX broken! */
-		return (EADDRNOTAVAIL);
 	laddr.s_addr = *laddrp;
 	if (nam != NULL && laddr.s_addr != INADDR_ANY)
 		return (EINVAL);
diff --git a/sys/netinet6/in6_pcb.c b/sys/netinet6/in6_pcb.c
index 1c36b4386030..bc7c0a2bebf5 100644
--- a/sys/netinet6/in6_pcb.c
+++ b/sys/netinet6/in6_pcb.c
@@ -134,8 +134,6 @@ in6_pcbbind(struct inpcb *inp, struct sockaddr *nam,
 	INP_WLOCK_ASSERT(inp);
 	INP_HASH_WLOCK_ASSERT(pcbinfo);
 
-	if (CK_STAILQ_EMPTY(&V_in6_ifaddrhead))	/* XXX broken! */
-		return (EADDRNOTAVAIL);
 	if (inp->inp_lport || !IN6_IS_ADDR_UNSPECIFIED(&inp->in6p_laddr))
 		return (EINVAL);
 	if ((so->so_options & (SO_REUSEADDR|SO_REUSEPORT|SO_REUSEPORT_LB)) == 0)