git: 93ce10ed2628 - stable/13 - hptiop: Remove Giant locking around ioctls.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 24 Dec 2021 01:16:25 UTC
The branch stable/13 has been updated by mav:
URL: https://cgit.FreeBSD.org/src/commit/?id=93ce10ed26282edc9647be20ad72d62f855f4bd1
commit 93ce10ed26282edc9647be20ad72d62f855f4bd1
Author: Alexander Motin <mav@FreeBSD.org>
AuthorDate: 2021-12-10 01:35:21 +0000
Commit: Alexander Motin <mav@FreeBSD.org>
CommitDate: 2021-12-24 01:05:03 +0000
hptiop: Remove Giant locking around ioctls.
The methods have their own locking and don't require Giant.
MFC after: 2 weeks
(cherry picked from commit e06c67eef8faae3322c06056960562fde88fd7aa)
---
sys/dev/hptiop/hptiop.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sys/dev/hptiop/hptiop.c b/sys/dev/hptiop/hptiop.c
index 50d26231a91c..eddc8da5bd8e 100644
--- a/sys/dev/hptiop/hptiop.c
+++ b/sys/dev/hptiop/hptiop.c
@@ -214,8 +214,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data,
int ret = EFAULT;
struct hpt_iop_hba *hba = hba_from_dev(dev);
- mtx_lock(&Giant);
-
switch (cmd) {
case HPT_DO_IOCONTROL:
ret = hba->ops->do_ioctl(hba,
@@ -225,9 +223,6 @@ static int hptiop_ioctl(ioctl_dev_t dev, u_long cmd, caddr_t data,
ret = hptiop_rescan_bus(hba);
break;
}
-
- mtx_unlock(&Giant);
-
return ret;
}