From nobody Sat Dec 18 11:58:34 2021 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 214BF18F1D9D; Sat, 18 Dec 2021 11:58:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JGPWZ6B0sz4tl9; Sat, 18 Dec 2021 11:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B518E6C7B; Sat, 18 Dec 2021 11:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BIBwYRl026031; Sat, 18 Dec 2021 11:58:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BIBwYJ0026030; Sat, 18 Dec 2021 11:58:34 GMT (envelope-from git) Date: Sat, 18 Dec 2021 11:58:34 GMT Message-Id: <202112181158.1BIBwYJ0026030@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Vincenzo Maffione Subject: git: a00d9c7f8cd9 - stable/13 - e1000: remove unused ifp backpointer List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vmaffione X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a00d9c7f8cd954d4fcff810b0217dbd48c3c0f1a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639828714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n4bDr9/yeFhLv+Knp49L0puDTBthxLRedr/yPnpCTwY=; b=TsNhFylnH/FsZoFK5/j4qn23egun2d+3MR6t84a5CGzdfr08OB+zaswcj2uhjV59fpHyhk bnYtYiYFf931gw/AheEAnOifg3hYR+HZAFW7vkjq5OA0FJNt9IH1MTHs00U8VqA/+E/sH7 v37pl1Ago6uXeAJvp/B84OSRYqQa8z4iKFM9AcI/c6605UeqZPbqYN6XhOahyk43k3y9n/ nTEvC6zXZqAHS+dfdZDR0CbtVtUscgcxFfFfVLkv+LYM8Yy0e7Yqrv+z4quYDkXbz/EaiP 9aMHZLvsOre7aU3PNXsB1EdkdbuGGi0EydQQRokoF5PRPSLSBHGqCMjEG2vXqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639828714; a=rsa-sha256; cv=none; b=puNMQovt0kXJcwG2KdRo8pdNcGW73hF2dM9Py2LBnAD1Ij6kVofFKqgi95X1H3/4d0b1L8 4EUJ8vKl1DLf6CmT1Qbx2PhEwZERrjPV8PyIKvk7C3Gw9oZA66K91x2YQjNOotcGTxJpS9 jrx0zCENT6VWecSSNnsxK5i+XOXt/UamG781ZdM7UnCvDd9DkNsO+poNRZb51NQOYdSogC CH80YSd6mYlGKW/jMe7yKaqsrYgxTDctc+5K66iiPf7tZXRuo6dSCPdnjJczfA9T06u2J1 GjGZy5f74l+pE3gToJLClmj8rdKge2UBpBocZwAZYkRMTcrk8cNwNBENsvUgvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by vmaffione: URL: https://cgit.FreeBSD.org/src/commit/?id=a00d9c7f8cd954d4fcff810b0217dbd48c3c0f1a commit a00d9c7f8cd954d4fcff810b0217dbd48c3c0f1a Author: Vincenzo Maffione AuthorDate: 2021-11-29 21:28:26 +0000 Commit: Vincenzo Maffione CommitDate: 2021-12-18 11:46:41 +0000 e1000: remove unused ifp backpointer The ifp (struct ifnet) backpointer in the e1000 private ifnet data is not used anymore since the iflib transition. Remove it so that developers are not tempted to use it and get a NULL pointer dereference. Reviewed by: markj, kbowling, erj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D33157 (cherry picked from commit d91559564dc647846479824340bdf94b7cf98c05) --- sys/dev/e1000/if_em.h | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 33ba22a88552..ed5a88013f5b 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -439,7 +439,6 @@ struct em_rx_queue { /* Our softc structure */ struct e1000_softc { - struct ifnet *ifp; struct e1000_hw hw; if_softc_ctx_t shared;