From nobody Wed Sep 30 23:35:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hwBHl67gpz6tSlr for ; Wed, 30 Sep 2026 23:35:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hwBHl4Yh8z4M3Y for ; Wed, 30 Sep 2026 23:35:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790811347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WFqCtJdugCu/CXnso1zMAsfnwHVRQanbNMbjINSxrIw=; b=Ncj8yfKk2Z/V5HMB8gzeJnGQYepPE/90ap4FqSk9JSEN0OY0D+Hu2x2+vj8bo0ufjKSEUa 1hSlrAtV8yiULyo3a+5Z8PaO1akTA5RhY4PA9c071esQWcFXk4Z0iAAi501mnFrWQXSOAK ZBfQpTfhcgvNpRY1zyd4KBsuNne4+P6QpOmLM6+NUUzcs36ma29S6roZe5LKl2sJ5jiRfi DcUgwUqVgGDcNKL0+pwQcTDWltZp4W9tsqqTOylsdr8Fab6nxxT0vFI6wd+L6wjDnoIikI 2e3Anxtkej73Pl2h3/LdaeZcC8pVfUQKZTUilv8bPYSnlX1R8Y/CAdvQLABzSg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790811347; b=jW+Soz0rki+RQul7gz91EU0IX1x6EoeYOzLUFawax1359CA26v275Sbe5BiGjrt6ASdGAQ 1YjBjOKknVbtnXLG5m9QzEdVYLV/+GpfiSfUqm7aJdNw3c7PIXYcpbTLoBGF0ii4ekoLzw LPFxxzq47NuOthoaEXBpBzKyAn0XEGNBF6clHJjQJnJdOM4tWRmJfGGKojr21g8tNO8Day whu1PGJxGZBGfMKhnTFsBy47WPxxznna3xpKk+xwBecDBHaaX8aYqY7QY2KFGgVNp9GVa4 ocoGxc1syJGaCDJuaaWlMpcAVOUx0+H4i5MJHP6sHfN8rDzEX9qAl9vu+0Qw6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790811347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WFqCtJdugCu/CXnso1zMAsfnwHVRQanbNMbjINSxrIw=; b=Cg06A9ND1WmJK/rDCf8JgEcxtNtyhqH/1tUttddn/mqD0nJyEnFiTno2/rb5f1upGRIvpc FfMtPXS0EeEhgIQSXSy08kOQZubWx2LiIcqLAkyhs1GPjinkeArUWL81J+CEKG6QWwxnBN +o1XIguVB6o4qJm0MwTqcVxNQOTGJS9L43q9AwA/wal7zkGwV0g9kyFgjnhW9K38whtga4 sWqWDH5gS8oMsIB+OAj/H/m+ru7RiguqVIjv3qVbYB2KlZWai00cfcKjrW7HBWorblt++C /JSMvf6ANpbC77N83mSZzHga8yrfNlUf4utMrmE+7nlqYG4Dx9SbFvNYEeEUOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hwBHl355Lz15DG for ; Wed, 30 Sep 2026 23:35:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 453e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 23:35:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 6d7f0162bd5d - main - pf: take the rules read lock in pf_handle_getrule() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6d7f0162bd5d25919cc18119a6e5a371acb2cf78 Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 23:35:42 +0000 Message-Id: <6abd9cce.453e1.75506667@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=6d7f0162bd5d25919cc18119a6e5a371acb2cf78 commit 6d7f0162bd5d25919cc18119a6e5a371acb2cf78 Author: R. Christian McDonald AuthorDate: 2026-09-30 23:33:43 +0000 Commit: R. Christian McDonald CommitDate: 2026-09-30 23:33:43 +0000 pf: take the rules read lock in pf_handle_getrule() pfctl -sr calls PFNL_CMD_GETRULE once per rule, and pf_handle_getrule() takes the rules write lock each time, so listing a ruleset of N rules stops packet processing N times. Only zeroing the counters (pfctl -z) needs the write lock. Take the read lock otherwise, as DIOCGETRULENV does. Reviewed by: kp Approved by: kp (mentor) Fixes: 777a4702c591 ("pf: implement addrule via netlink") MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D60161 --- sys/netpfil/pf/pf_nl.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/sys/netpfil/pf/pf_nl.c b/sys/netpfil/pf/pf_nl.c index 8d06798065ad..ad060ea3230a 100644 --- a/sys/netpfil/pf/pf_nl.c +++ b/sys/netpfil/pf/pf_nl.c @@ -1044,6 +1044,17 @@ pf_handle_getrule(struct nlmsghdr *hdr, struct nl_pstate *npt) struct pf_krule *rule; int rs_num; int error; + PF_RULES_RLOCK_TRACKER; + +/* The write lock to clear counters, the read lock to only read them. */ +#define PF_GETRULE_LOCKOP(op) do { \ + if (attrs.clear) \ + PF_RULES_W##op(); \ + else \ + PF_RULES_R##op(); \ +} while (0) +#define PF_GETRULE_LOCK() PF_GETRULE_LOCKOP(LOCK) +#define PF_GETRULE_UNLOCK() PF_GETRULE_LOCKOP(UNLOCK) error = nl_parse_nlmsg(hdr, &getrule_parser, npt, &attrs); if (error != 0) @@ -1055,23 +1066,23 @@ pf_handle_getrule(struct nlmsghdr *hdr, struct nl_pstate *npt) ghdr_new = nlmsg_reserve_object(nw, struct genlmsghdr); ghdr_new->cmd = PFNL_CMD_GETRULE; - PF_RULES_WLOCK(); + PF_GETRULE_LOCK(); ruleset = pf_find_kruleset(attrs.anchor); if (ruleset == NULL) { - PF_RULES_WUNLOCK(); + PF_GETRULE_UNLOCK(); error = ENOENT; goto out; } rs_num = pf_get_ruleset_number(attrs.action); if (rs_num >= PF_RULESET_MAX) { - PF_RULES_WUNLOCK(); + PF_GETRULE_UNLOCK(); error = EINVAL; goto out; } if (attrs.ticket != ruleset->rules[rs_num].active.ticket) { - PF_RULES_WUNLOCK(); + PF_GETRULE_UNLOCK(); error = EBUSY; goto out; } @@ -1080,7 +1091,7 @@ pf_handle_getrule(struct nlmsghdr *hdr, struct nl_pstate *npt) while ((rule != NULL) && (rule->nr != attrs.nr)) rule = TAILQ_NEXT(rule, entries); if (rule == NULL) { - PF_RULES_WUNLOCK(); + PF_GETRULE_UNLOCK(); error = EBUSY; goto out; } @@ -1095,7 +1106,10 @@ pf_handle_getrule(struct nlmsghdr *hdr, struct nl_pstate *npt) if (attrs.clear) pf_krule_clear_counters(rule); - PF_RULES_WUNLOCK(); + PF_GETRULE_UNLOCK(); +#undef PF_GETRULE_LOCKOP +#undef PF_GETRULE_LOCK +#undef PF_GETRULE_UNLOCK if (!nlmsg_end(nw)) { error = ENOMEM;