From nobody Wed Sep 30 19:28:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hw4pR1JM8z6v3wd for ; Wed, 30 Sep 2026 19:28:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hw4pR0dcGz4N62 for ; Wed, 30 Sep 2026 19:28:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790796511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zS1skNuDr5VX68GjpsBGa2YO4B+bJ3geKh01eTwrNeY=; b=tiGfc+MrtT/v/VVQDyYSpwyB1+EXgxygU+2fueKIrK4Q8pnlbnYkaRn4gzAu2dF23M90mT o+0id+Cxn+f0o5v8aD8MzpTSGVUNBgq5LkGEtTgThGB3EFWBt+o7OF9oPV/6FeuTI5GQhF j4Z5P3/hTXyNcU9QQzWieyArVFo2Gy5doQuq2HrUR5Ucnvu5A3XKS9uSgfv/J24jGBrhIc 7Lhud1h1smjNjg6f58CuZkMUdvaaieFNEAdiujzRPvJ7tVAzCD4M7MXUcylQan76ttBiXi L4le9yNdemz+l9sYZFJax3440OeMrM7osyHe9ajRxM8mbJK4s4hTk5XwlMcXoA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790796511; b=xKfKsT17PNcM/E/elK04Ioe45KPsPaZa5nJ+jkyjh7rajioj8wDdYdI73DKiV4NutlbMnS h+1P6aDG/aEiPrWDjS3ti/gxzyUMBr9y/nIQ8dzIybO7RJLOVL3w+/7remiyC29L+EF6qV ob8aWK/Vq8QlyqPr0Ac+BKiJQs68vj+zUYQmNWAamLDweL4FABZNaxiQKI4eYCXWS9qAlX tJ1YanOeDdVofKmgXkWPBSeYj/jTeHD/QzVD+fsouq0FueTeyy8lrOV5CrU8ZI/l23IXCR YVgHP05lMrjxmkP4/Rid2zUFEZ5VO7mVUfU/JAr48ehVUr3fOCzZOUiwRMe+UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790796511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zS1skNuDr5VX68GjpsBGa2YO4B+bJ3geKh01eTwrNeY=; b=QpT3giTNI1ybFN4ZQqgZIIlpExtmtl1J+jHUbzgLFeq/AoT5Ac5h050te/m7X23utc4EJp SjXDqAFIzT6p5ue3eNuCuoQnze21FTp1NYlG4p/rLje6SnDTLfD+Q7tLqlWqIOCRvLjBNp kjq2dZbm+FnyXSpe1wQD60UHHJK7A4Tf6oO2oDziqfqRW35macTSbeCJh19rZDM7WLoQob X3VmkdIvw41Uo3FQ/tnSv6ml+Ojt9mg2XyNOXInk9JzIFx5Du33pmloSUxgC6pn/fsqnfR P9yx5lbaBfjjknDSCm2o00dHp0D19OOWFof3HbS37/J64CF2lOxprt13F5TQ/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hw4pQ60t6zyGv for ; Wed, 30 Sep 2026 19:28:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22c97 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 19:28:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 6f9d0f02e72c - main - jh7110_gpio: handle preset high/low List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6f9d0f02e72cdcf64af6e0a034af4d4f065b26f8 Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 19:28:25 +0000 Message-Id: <6abd62d9.22c97.6b6762be@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=6f9d0f02e72cdcf64af6e0a034af4d4f065b26f8 commit 6f9d0f02e72cdcf64af6e0a034af4d4f065b26f8 Author: Mitchell Horne AuthorDate: 2026-09-30 19:23:03 +0000 Commit: Mitchell Horne CommitDate: 2026-09-30 19:26:04 +0000 jh7110_gpio: handle preset high/low Take action in the presence of the GPIO_PIN_PRESET_LOW/HIGH flags. This part of the GPIO interface seems to be unused, but is trivially implemented in our driver. Reviewed by: Brian Scott MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59991 --- sys/riscv/starfive/jh7110_gpio.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/sys/riscv/starfive/jh7110_gpio.c b/sys/riscv/starfive/jh7110_gpio.c index fdf40e5c147d..22e435a8d146 100644 --- a/sys/riscv/starfive/jh7110_gpio.c +++ b/sys/riscv/starfive/jh7110_gpio.c @@ -92,6 +92,7 @@ static struct resource_spec jh7110_gpio_spec[] = { #define JH7110_GPIO_LOCK(_sc) mtx_lock(&(_sc)->mtx) #define JH7110_GPIO_UNLOCK(_sc) mtx_unlock(&(_sc)->mtx) +#define JH7110_GPIO_ASSERT_LOCKED(_sc) mtx_assert(&(_sc)->mtx, MA_OWNED); #define RD4(sc, reg) bus_read_4((sc)->res, (reg)) #define WR4(sc, reg, val) bus_write_4((sc)->res, (reg), (val)) @@ -145,11 +146,26 @@ jh7110_gpio_pin_get(device_t dev, uint32_t pin, uint32_t *val) return (0); } +static void +jh7110_gpio_pin_set_locked(struct jh7110_gpio_softc *sc, uint32_t pin, + uint32_t val) +{ + uint32_t reg; + + JH7110_GPIO_ASSERT_LOCKED(sc); + MPASS(pin <= sc->maxpin); + + reg = RD4(sc, sc->doutcfg + GPIO_RW_OFFSET(pin)); + reg &= ~(DATA_OUT_MASK << GPIO_SHIFT(pin)); + if (val != 0) + reg |= 0x1 << GPIO_SHIFT(pin); + WR4(sc, sc->doutcfg + GPIO_RW_OFFSET(pin), reg); +} + static int jh7110_gpio_pin_set(device_t dev, uint32_t pin, uint32_t val) { struct jh7110_gpio_softc *sc; - uint32_t reg; sc = device_get_softc(dev); @@ -157,11 +173,7 @@ jh7110_gpio_pin_set(device_t dev, uint32_t pin, uint32_t val) return (EINVAL); JH7110_GPIO_LOCK(sc); - reg = RD4(sc, sc->doutcfg + GPIO_RW_OFFSET(pin)); - reg &= ~(DATA_OUT_MASK << GPIO_SHIFT(pin)); - if (val != 0) - reg |= 0x1 << GPIO_SHIFT(pin); - WR4(sc, sc->doutcfg + GPIO_RW_OFFSET(pin), reg); + jh7110_gpio_pin_set_locked(sc, pin, val); JH7110_GPIO_UNLOCK(sc); return (0); @@ -303,6 +315,13 @@ jh7110_gpio_pin_setflags(device_t dev, uint32_t pin, uint32_t flags) WR4(sc, sc->iomuxcfg + PAD_OFFSET(pin), reg); } + /* Handle preset values. */ + if ((flags & GPIO_PIN_PRESET_LOW) != 0) { + jh7110_gpio_pin_set_locked(sc, pin, 0); + } else if ((flags & GPIO_PIN_PRESET_HIGH) != 0) { + jh7110_gpio_pin_set_locked(sc, pin, 1); + } + JH7110_GPIO_UNLOCK(sc); return (0);