From nobody Wed Sep 30 09:51:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvr0d43LGz6v8gK for ; Wed, 30 Sep 2026 09:51:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvr0d11jGz3NM8 for ; Wed, 30 Sep 2026 09:51:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790761889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DV2dZWkfTsOwHANsFgfl92nFGJKqfadiDSpvsticAUg=; b=u0/tB2KVRJcujN9cWhImGV++1NQrzf6rz2HR/DVFQnbm5pQNgXt2T6MNfIUEDBso64jN7+ ha7ZMh947O1OZO2eiGa1aP2lFf6ss4wYjZCliJIglPwYWEX9Oq0qV51rZyc1Lkf1ruYKPg eS1rKQPOSjbZeQ4xTrE/nXaXklMA67TqfhR+80fjDllzzohya2Dd0OEAuQLDfh9jR6tJnB AyJln5fw9/8uQkMjnrYxftUkrJKne0Jl4xArICKGpeftdxniCUulrDnqecj5lFLR5SvmER KQ78CAzACLlT10dfR93Iyc1O8IXqHFpsag2YIQxqHn7k7xpn/0WRWa3DXLYndw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790761889; b=uCzQusgRGJh9kIeg61NF1g66CBsFkorbEs8ts6Y+sTHVE0TO8iad+1jYkEDEDbfy8XoW// xHYeNG7kLQ5q8KEAZSXxmbsjH75GZ6lyrrJoOfn3d2UTsyg6xO/Ceedeb6ZL4zz4HIEtV6 VnejYHusTSv7P59CxdQIDdO0gs9BpgfBLgB4i2UNP75Sso89rvB2B799yu52YuoESrFRBj 9Z2YoPgFdxhehaFiOZUIqr1wD2YklRvCwAiC7G2t83Q34m3kYniRdrBgeXLldtuT5cJiQ8 BR3HOW19zsGFyIV01PWQwhVXBCykteR0abcGz0aG2US31UoX9VRg6G6cr3fVvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790761889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DV2dZWkfTsOwHANsFgfl92nFGJKqfadiDSpvsticAUg=; b=spgi6OZ/j+IW9Gg3qjfuAAn/M5YuR3LYhourI6f2MbdryLoks3x7JTIxH7SHe7UZGDJqwH TCL2DSpO1UzluHl76k9ZtOTjBbl0dBDgJlL0FeOhSwfpZvE5EgCkMdTw6e4xSLN5q2049T 6sqKaLQYlrTEc7m8RHPXSCw8avCp5TVQghsJFvx6Ls0KhM4qP+t2pUDCNak68eGd1yCNz0 WkRVKxg87Ay7MrM4EJUqxvS9Fg1tNJXKekCcuuceJ6cg/0DjnR+RsxjWSRmq8/HREAPiHe wbscXNxFzgMgx2zJjt4iuyG4Cc/4XmcFb0r6BFiIxZOHGY8damPjC9Cr8HsHig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvr0d063Lzgvf for ; Wed, 30 Sep 2026 09:51:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3451f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 09:51:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: fad756fd200b - main - cuse: Use make_dev_s() to create client devices List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fad756fd200bf988861eb80146392661a887ab71 Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 09:51:29 +0000 Message-Id: <6abcdba1.3451f.2ed6dc60@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=fad756fd200bf988861eb80146392661a887ab71 commit fad756fd200bf988861eb80146392661a887ab71 Author: Christos Margiolis AuthorDate: 2026-09-30 09:50:03 +0000 Commit: Christos Margiolis CommitDate: 2026-09-30 09:50:03 +0000 cuse: Use make_dev_s() to create client devices make_dev_s() sets si_drv1 before the node is published in devfs, which avoids a race where cuse_client_open() could see it as NULL. It also now reports finer-grained errors on failure, instead of only ENOMEM. While here, drop the NULL checks on kern_dev in cuse_server_free_dev(), since a device is only added to the server's list once it has been created. MFC after: 1 week Sponsored by: The FreeBSD Foundation Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D59874 --- sys/fs/cuse/cuse.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/sys/fs/cuse/cuse.c b/sys/fs/cuse/cuse.c index 52a1693a45ce..0bd8cc0d5dac 100644 --- a/sys/fs/cuse/cuse.c +++ b/sys/fs/cuse/cuse.c @@ -636,8 +636,7 @@ cuse_server_free_dev(struct cuse_server_dev *pcsd) /* prevent creation of more devices */ cuse_server_lock(pcs); - if (pcsd->kern_dev != NULL) - pcsd->kern_dev->si_drv1 = NULL; + pcsd->kern_dev->si_drv1 = NULL; TAILQ_FOREACH(pcc, &pcs->hcli, entry) { if (pcc->server_dev == pcsd) @@ -645,11 +644,8 @@ cuse_server_free_dev(struct cuse_server_dev *pcsd) } cuse_server_unlock(pcs); - /* destroy device, if any */ - if (pcsd->kern_dev != NULL) { - /* destroy device synchronously */ - destroy_dev(pcsd->kern_dev); - } + /* destroy device synchronously */ + destroy_dev(pcsd->kern_dev); free(pcsd, M_CUSE); } @@ -1078,6 +1074,7 @@ cuse_server_ioctl(struct cdev *dev, unsigned long cmd, struct cuse_create_dev *pcd; struct cuse_server_dev *pcsd; struct cuse_data_chunk *pchk; + struct make_dev_args args; int n; case CUSE_IOCTL_GET_COMMAND: @@ -1260,16 +1257,19 @@ cuse_server_ioctl(struct cdev *dev, unsigned long cmd, pcsd->user_dev = pcd->dev; - pcsd->kern_dev = make_dev_credf(MAKEDEV_CHECKNAME, - &cuse_client_devsw, 0, NULL, pcd->user_id, pcd->group_id, - pcd->permissions, "%s", pcd->devname); + make_dev_args_init(&args); + args.mda_flags = MAKEDEV_CHECKNAME; + args.mda_devsw = &cuse_client_devsw; + args.mda_uid = pcd->user_id; + args.mda_gid = pcd->group_id; + args.mda_mode = pcd->permissions; + args.mda_si_drv1 = pcsd; - if (pcsd->kern_dev == NULL) { + error = make_dev_s(&args, &pcsd->kern_dev, "%s", pcd->devname); + if (error != 0) { free(pcsd, M_CUSE); - error = ENOMEM; break; } - pcsd->kern_dev->si_drv1 = pcsd; cuse_server_lock(pcs); TAILQ_INSERT_TAIL(&pcs->hdev, pcsd, entry);