From nobody Wed Sep 30 09:51:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvr0Y1Ztlz6v8cj for ; Wed, 30 Sep 2026 09:51:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvr0X6hTjz3N1j for ; Wed, 30 Sep 2026 09:51:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790761884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i22hg4Q6aMXMOCbUI40YN07Gx5ww8VsFi1ALvGmchaA=; b=OsdXppaAjsuW3m+F3TL2GBVLVJXDeHVSnQaE3T6HY85b2xRlkjX1kulODdavAapBQ1vCYY Kg5UfR2f0RTTUhfbG4D02eQJ3lD8WMw0L4YQHIqDDM8aXD6CL+fav4nRxk0vF2PquV9fSa xR97AVcCWaaZbHABpUNL/zHIR1aRAQSBlVDdo08S4een2aWWg8hYONNn0YNvzmDaSg16XQ nXazwfFqF9cWDIMz9n+895xK+zM6iq+VGu3eNW0Kmsy/QO5rWJBnFBVaUUyjoGvwZFrAXa d/Fbe68oSHcI7rCuzcp0QVO9HkiRH9U4m7Sjdrf8MnuJeAdqdwImAiJ3BWgBnQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790761884; b=DGu2xku1vJVZfjcyr2WleFwLoTS4IhRYi6kgAv0wlep8hk6HfYQJoPFjUm+vbMEtRr1lPK +bJ6iAeBLynRhU7eA/gRQVrN+9BcBhMft4cQDXt8Uk+MA0roPt2qGkriQ/uFxwd/EY69sJ otU6oBDGJfIZWRbcIZjofyHnNwq2lYtscVOVn5QjXHWBW3sOvKB5GpXu7zhOf0mApzhtbT HwZ+VxIOxQfidBfjcPUlPebsVQfJjAkGw6318xOiFL9BINe7NRReeqvec+EK2UelbvCvOY V2NoCpqOXFzOdTXce/h0/arjGe9lzAtBEM2AKUzBXSiSWS6btnepXmO6qmfBsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790761884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i22hg4Q6aMXMOCbUI40YN07Gx5ww8VsFi1ALvGmchaA=; b=qFOwTCzRR7ZETIqmBnwx/f/KGCjMkOQ+KlppOsey91o1AcOQOk1azfEU/CuSXUAxJ9biwT NcF1I8L+RfHNB0m9yLyl4EGb9i5p2mACTG2XmOtp+cBxr6O6y+lj4TPyYTbvjEs1UFmlR9 5KevUVH/PIDNJIXA8VXtihWG8T52zZUMfXTn7wX6I96/KxLCP88A3b6QsC0fkCXLb48I7D wH13AIDzaI3CMykRUJUO/VCDpPmNziJKzNhSIP5Y5qwfBvAlu5i2ZBdZvgEROcTTwW06Q/ XbncQde2h4xVwYq/YF3ImoBIQnsWI1FPMbCdieLS4gf4sfOxO9F1LzaGVJje0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvr0X4w3hzgqL for ; Wed, 30 Sep 2026 09:51:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 334bb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 09:51:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 3b3e6473b130 - main - cuse: Create /dev/cuse with MAKEDEV_CHECKNAME List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b3e6473b13093c6900194b42e8a11f56c2ea7d8 Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 09:51:24 +0000 Message-Id: <6abcdb9c.334bb.646d4e0d@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=3b3e6473b13093c6900194b42e8a11f56c2ea7d8 commit 3b3e6473b13093c6900194b42e8a11f56c2ea7d8 Author: Christos Margiolis AuthorDate: 2026-09-30 09:49:46 +0000 Commit: Christos Margiolis CommitDate: 2026-09-30 09:49:46 +0000 cuse: Create /dev/cuse with MAKEDEV_CHECKNAME Since we now use make_dev_credf(), make sure to fail kldload if it returned NULL. MFC after: 1 week Sponsored by: The FreeBSD Foundation Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D59863 --- sys/fs/cuse/cuse.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sys/fs/cuse/cuse.c b/sys/fs/cuse/cuse.c index dd8eb4d67f80..37b5f0494b38 100644 --- a/sys/fs/cuse/cuse.c +++ b/sys/fs/cuse/cuse.c @@ -268,19 +268,23 @@ cuse_cmd_unlock(struct cuse_client_command *pccmd) sx_xunlock(&pccmd->sx); } -static void +static int cuse_kern_init(void) { TAILQ_INIT(&cuse_server_head); mtx_init(&cuse_global_mtx, "cuse-global-mtx", NULL, MTX_DEF); - cuse_dev = make_dev(&cuse_server_devsw, 0, - UID_ROOT, GID_OPERATOR, 0600, "cuse"); + cuse_dev = make_dev_credf(MAKEDEV_CHECKNAME, + &cuse_server_devsw, 0, NULL, UID_ROOT, GID_OPERATOR, 0600, "cuse"); + if (cuse_dev == NULL) + return (ENODEV); printf("Cuse v%d.%d.%d @ /dev/cuse\n", (CUSE_VERSION >> 16) & 0xFF, (CUSE_VERSION >> 8) & 0xFF, (CUSE_VERSION >> 0) & 0xFF); + + return (0); } static void @@ -2038,18 +2042,20 @@ cuse_client_kqfilter(struct cdev *dev, struct knote *kn) static int cuse_modevent(module_t mod, int type, void *data) { + int err = 0; + switch (type) { case MOD_LOAD: - cuse_kern_init(); + err = cuse_kern_init(); break; case MOD_UNLOAD: cuse_kern_uninit(); break; default: - return (EOPNOTSUPP); + err = EOPNOTSUPP; } - return (0); + return (err); } static moduledata_t cuse_mod = {