From nobody Wed Sep 30 09:15:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvqC16v7Nz6v6DL for ; Wed, 30 Sep 2026 09:15:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvqC16QH9z3Gpq for ; Wed, 30 Sep 2026 09:15:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790759725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N/+xo2lQYjZcWN6MkVrt8yxoAOpMWZalcqmlmNqH0vc=; b=es6lrApd0ckB7Yfg8mdwfPEyibksHltdE33cVf+8yKnVsg0pITppL9b0Ujq88A8E7p2P0f wKypdpaS96v/fEqUAxUYblqMmLdTlV4iXIHTBTTN9PK78bfl+VfCL/N86eSzp1mRsX8IbO RsUn3sS7AHuMqi2JxWAu++J1WnSd2YEEV8ghCso1kb6F/zI8HzJPuMQhHRE3Yud8AztCHi pYBrbgwaZZO/LAGTmdYuzSLsWaNgF5LR3Kyh6lfSkhCjZXNsD6BmPpj3TPRNh0bu/2iiSs dl3qzL4KrKtY/D+qQAqxl13nUHxoxtcKLe8HTOviHOD5JgQDZgWf1Q979abNyw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790759725; b=ZNAU+mNjiIsHFMfuEpRCH0hyF1wVeI2LqXS5dLn/0DKhl8dgClPPOBEanzlnPLb4i80KO5 9mFex7ojkgf2NAO2F64eUza4UFrGbIRa7HIemDVrM/fQbejxKXm8Kbdgzz8TQ59WYUV7YF wAoMJb3HSRSI8chDuNS2BN/UG5gY7wQLMjvHP+tb9JZQz2lttuTx3bHvvG7idPUYr2Nsj6 e7Q1SWv+dSg/zxbNQS1+Y1ix/1P377G/1QW88E2GiGAF9xfF++M1wKzZuV/8V02BB2aVtN WYV6j6B/5MWYNwT1OYhqij3TqEKjofEmqNbti4fkvfUhl5eXsCIvAFNzUJshvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790759725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N/+xo2lQYjZcWN6MkVrt8yxoAOpMWZalcqmlmNqH0vc=; b=V6eMx5v9apcdBpD/cE9+5hnLAVvV+I1hPcrX8vq84cRWTzniwxDdZteS7fc6oEmB19FCxk 58uMXEHFwfBI61qIj4doNnTbyTczzyJp1GMsw+ZKFE1JrpSXVRCGNGO83qJ0CwlDFNkYqY 9Qw5na1wPSAnskUT6pv0NMxDv6CO6qwZfzfBmGeZUmYLK/58KG1t5O737u5VfzOMDIH9GV QTEawP6pc3vKJzZ4/yezWPkND/6ZU0BPfLIuSmw1Ff6NxbT5w2jnH2sIz2LFQbPApkacyR yYQxB5A47r85XoyfnA85UF8RV9GK/se1NlRKdGMY8HS5pbw8qJknWLgQOoVdXA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvqC15TQnzg7c for ; Wed, 30 Sep 2026 09:15:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30b8b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 09:15:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: e40d60838c9a - main - cred: freebsd14_setgroups(): Remove a now-unnecessary local variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e40d60838c9a0ebe5e5fb0e3cb00e7b08dd8c959 Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 09:15:20 +0000 Message-Id: <6abcd328.30b8b.544727b5@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=e40d60838c9a0ebe5e5fb0e3cb00e7b08dd8c959 commit e40d60838c9a0ebe5e5fb0e3cb00e7b08dd8c959 Author: Olivier Certner AuthorDate: 2026-09-30 09:10:44 +0000 Commit: Olivier Certner CommitDate: 2026-09-30 09:14:45 +0000 cred: freebsd14_setgroups(): Remove a now-unnecessary local variable MFC with: e6fbef451dd4 ("cred: Fix a race in the FreeBSD-14-compatible setgroups(2)") Sponsored by: The FreeBSD Foundation --- sys/kern/kern_prot.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index bfb95508b64e..005131b1561f 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -1231,11 +1231,8 @@ freebsd14_setgroups(struct thread *td, struct freebsd14_setgroups_args *uap) groups = smallgroups; error = copyin(uap->gidset, groups, gidsetsize * sizeof(gid_t)); - if (error == 0) { - int ngroups = gidsetsize; - - error = kern_setgroups(td, &ngroups, groups, true); - } + if (error == 0) + error = kern_setgroups(td, &gidsetsize, groups, true); if (groups != smallgroups) free(groups, M_TEMP);