From nobody Tue Sep 29 19:19:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvSfn1LvSz6tywy for ; Tue, 29 Sep 2026 19:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvSfn0wBdz4Pq1 for ; Tue, 29 Sep 2026 19:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790709585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gdukyNkFwErV/qNjWn3O2G9SZVHgFKRqXpF/icZdtM4=; b=opzdl+ya2w+lRU8N48JHBw9q41XGIRs7LYduS4Yx4iK327SWMSs9vz9i9jh3sHaVICI7CS tENgXcGLvYBdhsDBIFjTgllTt0YFurvR8qFFGPNDdFoZ8DRcneRPDWJKOKyQ1l12PhDJUr nXP9aE263zJOi7BkVvWCErG7IBrKrhoIYcFMbEiA22iFgvBiMKrvUQFbeWKLPcmLGLgpmq R2CAiKLKJb6vGU+1mVg9Ib5egUZqU+iBYN6JFdL4dC7IYlYYAmjEMy04+ZL66/rHDRpPTt OkqdCLLoSCrwZkg1AUKqQ1XxuODPumJUWJIFthwY0DlMf/0m7hvUOoEzd5ux6A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790709585; b=tUj6wRcX7mBV9N2+ERi5Gr6xqQQUTbI9DXEKn4BGn9F/dGB7MkfaUKaSWeFEwZ78xt5fJ6 RBqKd68flIMbQtVDSTuIKEdcEAerwmCE212kon0ISi+GYKgs0cYyNQQxhcPYE2iVLAYp6L kvbSy6OzrD4ZdDjHZz/et3zWk26HSdRA2lXc9Oa+Prwi9xnWmAreQ7hhE9LK/mxvPuOKHg a8dyTUduXjmM2R5Q8FTIUwymohtb+kvcj9l6ww0z28M8OwwkUcVX8LNlOyj1XzRvsI5gwm EElvMyig5n/Gv0qrp4BjD2dFTBCflWtmbAb8wqnWcLbGRY3VaG8GCknBIw+p+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790709585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gdukyNkFwErV/qNjWn3O2G9SZVHgFKRqXpF/icZdtM4=; b=X27IMy36hNxXoJ8yKSdXNcc8OLFXPNBiDmHtOaMRdpnIV3gpmXNbALxTuj15jHsnC0u++g 9yVghbaJ5AudarIH4CoObAKDnddqEyjT6Wv+SIuURCeMTZM9L1L2RdoLK2EJyQ3vNSDM3n O9OoXS8pnqNROJGnEKv5ijuYo9/ZH0hVlmrV9W11rKWPKYYchu/V/RTviF2VDXS1vMV8LK 5F0X8TfRnQl4A4Bw4RzhpQ9KWO57JhZtTW4rXMQrPMxPNRneUlkXn5nMFYFuK1yociIpZN QNTNR3fXkdkzvs8fs3K2uE4EGop/drheZW86ICUbs4EI5f+bYgbevmnYY6kFlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvSfn0051z1Qj5 for ; Tue, 29 Sep 2026 19:19:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 443df by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 29 Sep 2026 19:19:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 57f9bad9188d - main - pf: deregister the ifnet_rename_event handler on unload List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57f9bad9188d70272c131a6cc8502d00be58fd56 Auto-Submitted: auto-generated Date: Tue, 29 Sep 2026 19:19:39 +0000 Message-Id: <6abc0f4b.443df.20dfb2be@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=57f9bad9188d70272c131a6cc8502d00be58fd56 commit 57f9bad9188d70272c131a6cc8502d00be58fd56 Author: R. Christian McDonald AuthorDate: 2026-09-29 18:27:36 +0000 Commit: R. Christian McDonald CommitDate: 2026-09-29 19:19:19 +0000 pf: deregister the ifnet_rename_event handler on unload pfi_initialize() registers pfi_rename_ifnet_event() on ifnet_rename_event, but pfi_cleanup() never deregisters it. After "kldunload pf", the next interface rename calls through a stale pointer into the unloaded module: kldload pf kldunload pf ifconfig epair create ifconfig epair0a name foo Reviewed by: kp Approved by: kp (mentor) Fixes: 349fcf079ca3 ("net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming") Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netpfil/pf/pf_if.c b/sys/netpfil/pf/pf_if.c index 3993a3ee4c13..aed1af15fb30 100644 --- a/sys/netpfil/pf/pf_if.c +++ b/sys/netpfil/pf/pf_if.c @@ -221,6 +221,7 @@ pfi_cleanup(void) EVENTHANDLER_DEREGISTER(ifnet_arrival_event, pfi_attach_cookie); EVENTHANDLER_DEREGISTER(ifnet_departure_event, pfi_detach_cookie); + EVENTHANDLER_DEREGISTER(ifnet_rename_event, pfi_rename_cookie); EVENTHANDLER_DEREGISTER(group_attach_event, pfi_attach_group_cookie); EVENTHANDLER_DEREGISTER(group_change_event, pfi_change_group_cookie); EVENTHANDLER_DEREGISTER(group_detach_event, pfi_detach_group_cookie);