From nobody Tue Sep 29 10:16:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvDbh0dpPz6cWVw for ; Tue, 29 Sep 2026 10:16:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvDbh05jHz4ntV for ; Tue, 29 Sep 2026 10:16:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790676976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4eLostPgWCRgaNmWpAKxj+fALnIEJgkA6j9Q8QVCYDs=; b=UCsRdnpPvYAIciHAKoG3zwYTi+RqLBvwGPFymYCC9hGl5ulEgKcYzEC2tYlA1+xNXXYB4I hs+aE/2Oe991B9Walrafaqnq4dPpeTN2Oh8JjRbtSCPpZAtZw8Tau5y/+vIf1WBYFG4oMj 4oatqVPyUJEVtKnYcErlae2UzNEkivEqrhIByLabpjnbnl1yuSutij4gRl1ue+YQvQ2m8k lIZ9DRQVXTkaIR2T1vmioO+3zkwbSaXQp6U+TGAZCmTRBRQ/Lhx06Qb2rv8DjeEpO058q1 CyCDgKpK0G+BIM4JjEXHHjHNV8IGN/JhUKVGI0XjTrr4VTp5aKvs0ph5ahxV/g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790676976; b=Wa6qG5mOntLek2yDE30EuZy6hEeD9CvxBhNbtn4esz/Q+Ky/cKh54FbCIqE/tj4XYwafmu jrN3xcNwRxXKcjvOVkDVOGvPgBU6PfXVHdiI28LrcXMabPRAFiQFYmGFTnUm1GHJ7u+tyi pw1yl6FN0UMdv/F1pwIaLnug+Z9P+8EOfb9HvWB6NY0h2SV9nJIbe0ROKegO2jN9ogEgT6 bYjdqnDAkrFzLhv3ZM1rjt5yK1ygHSpmeNTlIt6Ow6GDxYJR2v2/PL+2k1T0n/EkJqbD6M 8ynFinEoehUZWI+4e/BdGFlSk1SZ5Hh1HEZXpceEE0qB6JStD/71l9YRpamxew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790676976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4eLostPgWCRgaNmWpAKxj+fALnIEJgkA6j9Q8QVCYDs=; b=MOBwoAb2NxPNr2veCIldDf8bT4I50H84vIpHrRAGOWHw6JHq4FN+RAx6NIUhfCfyxrWgLe YOzfgaKluo7Aw6favgAF90/h5ns9WBvdBcOYrFVEx2W2ReNsqMaG4PBUn/Na8qKk7b6aHC 3hGqX35GCBoLKVxMAh85uw3gokv62h1iMgs00zDgs526QFfdn5otcnmWTthN6UwmKc7Og0 DOvk8xPBuK/czhAqVUezNFJWA+pUSCjhmxbloVx4noQbSPhsr0YTb+MLGk6ZJSCqrIwNBp w+KVKGnwJ7JFhZG7U9kHDVJOo5rcNz90Hzq/zdZ1mL3A3k7RqruPKyyQ+xszfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvDbg5n1tz18k8 for ; Tue, 29 Sep 2026 10:16:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27bf1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 29 Sep 2026 10:16:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 77b75400324d - stable/15 - snd_uaudio: Read the UAC2 sample rate back after setting it List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 77b75400324d6072e7d9bdf7efc356e72aa0789c Auto-Submitted: auto-generated Date: Tue, 29 Sep 2026 10:16:15 +0000 Message-Id: <6abb8fef.27bf1.3946ec72@gitrepo.freebsd.org> The branch stable/15 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=77b75400324d6072e7d9bdf7efc356e72aa0789c commit 77b75400324d6072e7d9bdf7efc356e72aa0789c Author: Christos Margiolis AuthorDate: 2026-09-15 12:12:43 +0000 Commit: Christos Margiolis CommitDate: 2026-09-29 10:16:03 +0000 snd_uaudio: Read the UAC2 sample rate back after setting it Some devices only apply a new sample rate once it has been read back, and produce no sound at all otherwise. PR: 294803 Reported by: tatsuki_makino@hotmail.com Tested by: tatsuki_makino@hotmail.com MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D59616 (cherry picked from commit 694923501f56a5d4519f548ee06db603f9486bc7) --- sys/dev/sound/usb/uaudio.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/sys/dev/sound/usb/uaudio.c b/sys/dev/sound/usb/uaudio.c index d81eb037b283..110afc66b961 100644 --- a/sys/dev/sound/usb/uaudio.c +++ b/sys/dev/sound/usb/uaudio.c @@ -5419,6 +5419,7 @@ uaudio20_set_speed(struct usb_device *udev, uint8_t iface_no, uint8_t clockid, uint32_t speed) { struct usb_device_request req; + usb_error_t err; uDWord data; DPRINTFN(6, "ifaceno=%d clockid=%d speed=%u\n", @@ -5431,7 +5432,27 @@ uaudio20_set_speed(struct usb_device *udev, uint8_t iface_no, USETW(req.wLength, sizeof(data)); USETDW(data, speed); - return (usbd_do_request(udev, NULL, &req, data)); + err = usbd_do_request(udev, NULL, &req, data); + if (err != USB_ERR_NORMAL_COMPLETION) + return (err); + + /* + * Read the rate back, because some devices only apply it once it has + * been read, and produce no sound otherwise. + */ + req.bmRequestType = UT_READ_CLASS_INTERFACE; + USETDW(data, 0); + + err = usbd_do_request(udev, NULL, &req, data); + if (err != USB_ERR_NORMAL_COMPLETION) { + DPRINTF("could not read sample rate back: %s\n", + usbd_errstr(err)); + } else if (UGETDW(data) != speed) { + DPRINTF("sample rate is %u Hz, expected %u Hz\n", + UGETDW(data), speed); + } + + return (USB_ERR_NORMAL_COMPLETION); } static int