From nobody Mon Sep 28 17:01:01 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htndH2Wjcz6Wwsd for ; Mon, 28 Sep 2026 17:01:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htndH0Y8Hz4flt for ; Mon, 28 Sep 2026 17:01:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790614867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gklliblPSR4MHYoSmDt862C7A4ELAR0Hx4nXWPX+qUQ=; b=sX0GBG9VOLRgKQBfgWlsfzyWS2t+DbRQP5YLUyqSr68DyEEM02SPtcnsN6cl7GVOx1VQeq Wdy6ICROkFGfDbAWOxlAJwaQHRxL/pSAZTqEBacnwuEnHM03wtoqkUGq+VlGAK3H4cm+pn KvXRcb4XHOCV6GB4YRPcg2MhZGL4xVmqFCpzs4fVS0E5+Ex3nigW1aLn0Fgl80hwUQWlCf FKEo80bLBrqQW//hS+3HZlYjxPlY9fybvjpxaEcbKwRIq0RO1r4g6MxYAymwNVhMa0/nBZ bna4io94Ezwvy2mHTHbVXw1S5h4Wy2llpTGFazVtn/4Neh9mw+GLpqty6YQgXA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790614867; b=pOTvmNji043et8EFC0nNkkK7Pz6UJxFT8cpHufXh/n3CATd5AidtJV5cQTt4fHg6shCd6t dwudKrqXdTygzRcQi7BX5wm8dBeIIESSBtnVKEakwVmX6K2pbFkJ0YUVZCuNEJLRABTH3s 4zrrREjJyvk+Y/RGi9Qp17pr9RtIJzPTUnq6tzmlCZc4wBRA+XP8dye/PuIaaHjAd8uwQ8 vSbkKMMon5W1iOd/7ASlqKDevyxXiEgZjmMbIRtrARF7E84uOxrlKZWsjVJc/bsOQIcQ9U witp9XqPAn7A9wgs4o4CXdExHG+vK0MsAdot379JKruulFNHuOvJKRP7rELsJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790614867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gklliblPSR4MHYoSmDt862C7A4ELAR0Hx4nXWPX+qUQ=; b=je+knCirSD/FUIfjKU/ATlmGYeXkJVHFoGq64JFpdXO5x2gOvzBgh1lsgR3xVrT7ezVFR1 TjTPLcgX1w3M4Sy0OtmF0sD6T6UKAS+sQj0CQsWonUpVVUDKqRwk6IfYRcCjziZuDthDRA 71To3S5SMOK/HVrHXtBdA/xDlUJrlTkLIEr+yAQQEpeZNQLAqD8y7RRQaN/y6flIfq8EsP QU1NhfuHyvy2PE8SSplnJW00uqupDwZUhTtLiUBBrfHvQdaBEPwfae39Lwq8kSB4SbgK6b kICJGU7316GirtuY+kUcyy8FFAz0KEE/rihzcviDpNaI1qZ2aY0QKS6D800jmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htndG6SCgzcnN for ; Mon, 28 Sep 2026 17:01:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33b34 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 17:01:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: David Bright Subject: git: f3c0dcde0e20 - main - ipmi: Add some additional diagnostic output on errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dab X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f3c0dcde0e2065d7db8ffa6e5980d0f6b3bcc8ed Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 17:01:01 +0000 Message-Id: <6aba9d4d.33b34.6b62d771@gitrepo.freebsd.org> The branch main has been updated by dab: URL: https://cgit.FreeBSD.org/src/commit/?id=f3c0dcde0e2065d7db8ffa6e5980d0f6b3bcc8ed commit f3c0dcde0e2065d7db8ffa6e5980d0f6b3bcc8ed Author: David Bright AuthorDate: 2026-03-13 01:11:08 +0000 Commit: David Bright CommitDate: 2026-09-28 17:00:57 +0000 ipmi: Add some additional diagnostic output on errors Add some additional diagnostic output for IPMI code, particularly on error paths. This has been found to be helpful at $WORK and seems generally useful, so contributing the changes back to upstream. Sponsored by: Dell Technologies Reviewed by: vangyzen@ Differential Revision: https://reviews.freebsd.org/D60091 --- sys/dev/ipmi/ipmi_isa.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/sys/dev/ipmi/ipmi_isa.c b/sys/dev/ipmi/ipmi_isa.c index 6d84496b0ef1..46c304b125ba 100644 --- a/sys/dev/ipmi/ipmi_isa.c +++ b/sys/dev/ipmi/ipmi_isa.c @@ -108,6 +108,7 @@ ipmi_hint_identify(device_t dev, struct ipmi_get_info *info) /* Set the mode and default I/O resources for each mode. */ bzero(info, sizeof(struct ipmi_get_info)); + device_printf(dev, "ipmi_hint_identify - %s hint\n", mode); if (strcasecmp(mode, "KCS") == 0) { info->iface_type = KCS_MODE; info->address = 0xca2; @@ -250,20 +251,34 @@ ipmi_isa_attach(device_t dev) switch (info.iface_type) { case KCS_MODE: error = ipmi_kcs_attach(sc); + if (error) { + device_printf(dev, "ipmi_kcs_attach error\n"); + goto bad; + } break; case SMIC_MODE: error = ipmi_smic_attach(sc); + if (error) { + device_printf(dev, "ipmi_smic_attach error\n"); + goto bad; + } break; case BT_MODE: error = ipmi_bt_attach(sc); + if (error) { + device_printf(dev, "ipmi_bt_attach error\n"); + goto bad; + } break; } if (error) goto bad; error = ipmi_attach(dev); - if (error) + if (error) { + device_printf(dev, "ipmi_attach error\n"); goto bad; + } return (0); bad: