From nobody Mon Sep 28 16:20:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htmkV68wVz6Wt4J for ; Mon, 28 Sep 2026 16:20:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htmkV3Vslz4X70 for ; Mon, 28 Sep 2026 16:20:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790612434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=17Vs5AbNMT7WpGk2ZAA/lkrf7oZaMWJOM1HQ28antC8=; b=WpiXnVXPjIZu7YTX4He4i/jaOqmHDn3BmceTDL2MAhr5M74FsH+asdM96yENhcvx4JfeO+ CvLn5s/uDVarjvJtATkRghzLwEgZbohGuiQjNQcOthLWy1z39Wlz4g9+SIANpFEn8B06Xx RsPDwezT1EBqvvypVR8YfCdkVa0DypO99b71mgIzb6f18WmFkZMBDQhHcVESfrfDnrjxGd S+hTQis/Ob5Qw2mB9aWrtRTUY2scGVjtvj6PGIpDBThgbsc/6n9rXUFjsJDOzP1Z8E2J+J Kn4eWfLxLotid3vRd3HU5oCUpTqmsl4HbkMqepjxMIPf9d/eX+1vKSbPHf8IBA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790612434; b=CaCaaDON7/MKz6Uw1rFbE1fcLo5iuXMBGWBuWCtVpDhl6wjdhrn30m5zsyhsuQeHuOXySZ N/EIAqjJHuVCIfOlRvPAWlrlXRgjUImJ1d/nFH3xXe2v1dHHDeyH2z4VLlzRvVdyIWO95R 3i1UH6UJI1onzkYEVHIUhsZxlCI20l74OvuVxQ9WlZvJPqF3VGsllcL6YElzBExO7XXIwU mpTOsxG0TMcFC6h/lOGVVR5AMRP44RQL9IqmkomnVRpRnvBBLKuVffl3OPdvqzPtRTZQ0I N1cBokWn68N7IgXyc5iFYzj13e+6Mziy7Zd+UzlgBQHGCkFFZdi4tXtFgHmsZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790612434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=17Vs5AbNMT7WpGk2ZAA/lkrf7oZaMWJOM1HQ28antC8=; b=m1GycDA2yR0fxHrWlRUCyUm+OIur7R6DdoRYB5LVimjXDyxk6/KeQqZcWanNlG730sR2OI gFWECfKjf8Z+s4i8rFXiQAS/9jDljV5UB9jR39p1fyPYy4pTVlkiR1CJsCbYyrXuuhSGaZ z8R+eMjYQY30XSDXrLRMfiSyYxNUQQL8ROMKseMYanWhFQpeAfuZIlC5foj9TdV5UlJL96 aBrYVdvPyBPhqgTR2t5UbeYffZrcPYHlCQ3jdwpHapnopFaBhoGl/yAiHlHVKXa8i0Es8o 3b2TS0uJV4lfXnDYz5NE71xPVox/B/7Tb+u0PGCvFWFKT4JmIQ+X0+8z8rq4yw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htmkV1RMXzbyy for ; Mon, 28 Sep 2026 16:20:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30389 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 16:20:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Griffiths From: Mark Johnston Subject: git: 718746766c18 - stable/14 - proc: free kstack buffers when debug permission changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 718746766c18130f06602f1625d05ac514bb84a2 Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 16:20:34 +0000 Message-Id: <6aba93d2.30389.785e1d3a@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=718746766c18130f06602f1625d05ac514bb84a2 commit 718746766c18130f06602f1625d05ac514bb84a2 Author: Andrew Griffiths AuthorDate: 2026-09-14 07:55:01 +0000 Commit: Mark Johnston CommitDate: 2026-09-28 13:38:23 +0000 proc: free kstack buffers when debug permission changes The kern.proc.kstack handler allocates its output and stack buffers before deliberately checking p_candebug again under the process lock. If trace-control state changes between authorization checks, the failure path balances the process and exec state but leaks both buffers. Submitted by calif.io for the OpenAI Patch The Planet program Signed-off-by: Andrew Griffiths Fixes: 8b5abd9027b8 ("kern_proc.c: disallow execve around sysctl kern.proc.kstacks") Reviewed by: markj MFC after: 1 week (cherry picked from commit 3484217cc47c1f77d2be2ed0e012b870d1cd3dca) --- sys/kern/kern_proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index a722bac6185a..8fc52c6749e1 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -2891,6 +2891,8 @@ sysctl_kern_proc_kstack(SYSCTL_HANDLER_ARGS) execve_unblock(ctd, p); _PRELE(p); PROC_UNLOCK(p); + stack_destroy(st); + free(kkstp, M_TEMP); return (error); } do {