From nobody Mon Sep 28 15:49:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htm294J5Mz6Wr45 for ; Mon, 28 Sep 2026 15:49:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htm293j39z4QGw for ; Mon, 28 Sep 2026 15:49:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790610545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=45PxNx8ZxyVJ60R3DGw7WH0fJQQMlekcmW/T0QYHdVA=; b=O3N9R/SvGMYhGBtOXMEvVRMHn0zEFeLF73gszjQcOK7tiwl3n42ABHcq+lB5wiTLtnzP/A 2lbBTdoyV4t67/ZV2WQ/0cGFYljL/chqJDqeq4vJb7kA3LNexAgXCyqoRi2gbICW7OcxSB XcMHVMrjcc+Yw8CxM3Neq48tio5h2UFKHBhRVng5gHteBjgKKqHjp5zGNs7i2VMs1TNHdG H0IxRDL4xIIEIVY83E763YWS+0cqZKbgT/4q/4O+g/mXl2ZQNA9HAlvyhY0Ap2NxgRi/n5 /vrERWEaWnUa6JbmFEG+iC4GCHHN0ZxFvjOfW2vpb0PWuj+ACgK+ql5cTQqyFA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790610545; b=MX54GuF2/NgUr616ysu4NAng8gY3MTfA8E6imfrhtG0nO9wUKN4mYKHLoVeFBOxqWJkBxz kdqGoOfyqb+817/5HtStEALJivrfVfjQuXmKrQ9xk681n0NLPGX1VuOjzdOxYLMX1WHpnf ZNGzJ4yYBEzWn9ouzpa126fetQIJJKcuvLdd+TCPZHudvAJ+yxajNzmO2xj5Byvr3W06Zb YipcRzMoyuwGz8r5ZYoFYJKVWSkfK7SlychdXjDUg/D9zC0hyHnxvafcw4DtDvDmBSBFfL HXC8az4j3NdEDyoSUa6Y9thnzRmtrhCBKXJJgKVqNk3GxH1v5JTelu2blhQ92A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790610545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=45PxNx8ZxyVJ60R3DGw7WH0fJQQMlekcmW/T0QYHdVA=; b=VNsnBCXyBvascAXryAWBQ5jeeIR1ag99n+dzZtQPH8yrpbIizJWUt6VJcIyHdv86uID8N1 whDovLH5e6uL7NeR1nITsj2EaVj8qYq2tWtc7bdWqN5bVoE2adJZN72pZVsfq+CO8MnxvV fTDELPh6noYI4fOv8Z29zXlcKgOYYjtGVFoFQ48GrJrWHuvQSJhRMEy3w7h0Sup9AxQa8M igY7Oeibw+FgX+hDTxq/7YZqvQbAEByhcR4CbPzz4Mvk4+ZEm2DrR6PRAkfWinWb91Lq6o 7hZ0Kg0PIHDTq1cbmp/EoMIN3AuHneWy0EDWXxtQponkLqTWJKEhFaAo+ZhrHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htm292lsyzbNX for ; Mon, 28 Sep 2026 15:49:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24818 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 15:49:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Minsoo Choo Subject: git: 4cb357c61c00 - main - arm: pad minidump page table List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4cb357c61c004f4cf27ca12e702b44a81f2752ab Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 15:49:05 +0000 Message-Id: <6aba8c71.24818.3281fa01@gitrepo.freebsd.org> The branch main has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=4cb357c61c004f4cf27ca12e702b44a81f2752ab commit 4cb357c61c004f4cf27ca12e702b44a81f2752ab Author: Minsoo Choo AuthorDate: 2026-09-16 00:14:45 +0000 Commit: Minsoo Choo CommitDate: 2026-09-28 15:48:47 +0000 arm: pad minidump page table libkvm locates the sparse page array after the page-rounded PTE table size, but the ARM minidump writer emitted only the unrounded size. When the table size was not page-aligned, libkvm therefore read every dumped physical page at the wrong offset. The mismatch was introduced when libkvm began rounding ptesize. It has affected ARM minidumps since ffdeef323449 ("libkvm: Improve physical address lookup scaling."). It is exposed when the dumped KVA span is not a multiple of 4 MiB. Zero-pad the final PTE page and include the padding in the dump size. Reviewed by: jhb Approved by: jhb (mentor) Fixes: ffdeef323449 ("libkvm: Improve physical address lookup scaling.") MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59716 --- sys/arm/arm/minidump_machdep.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/arm/arm/minidump_machdep.c b/sys/arm/arm/minidump_machdep.c index 2e7fe6ebc51d..6bf2ffd08b33 100644 --- a/sys/arm/arm/minidump_machdep.c +++ b/sys/arm/arm/minidump_machdep.c @@ -187,7 +187,7 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) /* Calculate dump size. */ mbp = state->msgbufp; - dumpsize = ptesize; + dumpsize = round_page(ptesize); dumpsize += round_page(mbp->msg_size); dumpsize += round_page(nitems(dump_avail) * sizeof(uint64_t)); dumpsize += round_page(BITSET_SIZE(vm_page_dump_pages)); @@ -269,7 +269,9 @@ cpu_minidumpsys(struct dumperinfo *di, const struct minidumpstate *state) } } if (addr != dumpbuf) { - error = blk_write(di, dumpbuf, 0, addr - dumpbuf); + /* The sparse page array starts at a page-aligned offset. */ + bzero(addr, dumpbuf + sizeof(dumpbuf) - addr); + error = blk_write(di, dumpbuf, 0, sizeof(dumpbuf)); if (error != 0) goto fail; }