From nobody Mon Sep 28 15:47:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htm0M4Gnnz6Wqwn for ; Mon, 28 Sep 2026 15:47:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htm0M1pt0z4Q25 for ; Mon, 28 Sep 2026 15:47:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790610451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a3RpvvwhXKRhJKzzgrYZd0PiIr3zThQjdqaftNuI4lI=; b=CP+wu8l9avaqUvEySIay/ObF6JaEkVPGFYXSKajC4JxKK4wOd2oK12rOucMard4v8LM2l5 yhWI1SwsRRmNpTryQhxncAGDRHujwQFzVwBGMdIZ7jsn//kRzxIbRNytQ9B9nTMyEdhdOw qmLRYicsjj3ANHHWlT6jUWJAQbUN6ysMuLikRLmnYN9PjcPI06bnQZIv7Zu8TbdMc9HxmG 3V7iwI/x4w2l19W2Upd2dKew0WZumFIPOQkOp4P0HLj7ecXuavJUCcZMaZT5jxObjFdxJw J5Ig48+9eQ5R3xSdxRMOiD/ohi3g1OoHO6nzmH8M9VfNJ6G0xJ/+cQyzyV/WBA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790610451; b=bq0N228JOfBch3faH3eoSiEYaEG7Q0JHdGNrAfF3lnvlMKx/DNQQAU95Gapn1wpZ6bTfVZ of3nA0XecHkYG0lyaRE8qKHPMo8N/41B/7RTxvxRumAp5GRRKiIyDcj6B2NCgGayOlmgss 4HngYPdmIy0SEHm5CDGuu55biRcx+Mh3xd+VoByUEUr4bAIVUqd95UBSzS7T3VUMlfKhIK sDTBe+zEEE0RYJs3qmUGbde57mJf8LCyVs+LfjXcufpbuOzwncZrQpUvGEStYT7ic7O6iz fTGLgTv0xl9tX78GjCMZcjOb8Gv58clPlhfBsKCeG+ArjjkfNft82p5SPEVZdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790610451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a3RpvvwhXKRhJKzzgrYZd0PiIr3zThQjdqaftNuI4lI=; b=cFPW89C3+vReguxxD93rDDU7pcobY6BkXY2OVdDLcCJ3+ajyPRDvaN7aKRLzjBVGXed9TW pK7LZVL1ClDkSXSX9oNdfNstoehNfI1WaFbSpCnW0qyAVEQqX92mt5KaMCWaDa4/3GEKZa 2Uwvb2q2HIDNbpSInae73QOFDIM+P/xtD3iyoQl5lV3CrGw6SelXt4JUgrek8dD0WRNmPU UcyY9OFtz8cuBtQ4RV5zKrfWX26gmXaOUf7C7uixYK7HREAqyJCVolRwfRdkMsYV0cV91X 1zgqDxRgOLMhO66bxF1o6kxhO9j8YuBW9Eg/lUjT9RKGYM8sBRwWi5ajKM+SVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htm0M0Jp7zbR0 for ; Mon, 28 Sep 2026 15:47:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 240b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 15:47:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 61f98a98250d - main - nd6: Fix regeneration of temp addresses in detached state List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 61f98a98250da7bd2c80c6d93d0032961d7f2fad Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 15:47:30 +0000 Message-Id: <6aba8c12.240b1.dfb518f@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=61f98a98250da7bd2c80c6d93d0032961d7f2fad commit 61f98a98250da7bd2c80c6d93d0032961d7f2fad Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-09-26 19:54:16 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-09-28 15:46:53 +0000 nd6: Fix regeneration of temp addresses in detached state When an on-link prefix becomes detached, the kernel keeps generating new RFC 8981 temporary addresses for that prefix. Fix it by ignoring the detached addresses in regen_tmpaddr(). While here, change its return type to bool. PR: 298533 Discussed with: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D60051 --- sys/netinet6/nd6.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/sys/netinet6/nd6.c b/sys/netinet6/nd6.c index cc9246475e40..3af6887a9a30 100644 --- a/sys/netinet6/nd6.c +++ b/sys/netinet6/nd6.c @@ -148,7 +148,7 @@ int (*send_sendso_input_hook)(struct mbuf *, struct ifnet *, int, int); static bool nd6_is_new_addr_neighbor(const struct sockaddr_in6 *, struct ifnet *); static void nd6_slowtimo(void *); -static int regen_tmpaddr(struct in6_ifaddr *); +static bool regen_tmpaddr(struct in6_ifaddr *); static void nd6_free(struct llentry **, int); static void nd6_free_redirect(const struct llentry *); static void nd6_llinfo_timer(void *); @@ -976,7 +976,7 @@ nd6_timer(void *arg) CK_STAILQ_FOREACH_SAFE(ia6, &V_in6_ifaddrhead, ia_link, nia6) { /* check address lifetime */ if (IFA6_IS_INVALID(ia6)) { - int regen = 0; + bool regen = false; /* * If the expiring address is temporary, try @@ -990,8 +990,8 @@ nd6_timer(void *arg) */ if (V_ip6_use_tempaddr && (ia6->ia6_flags & IN6_IFF_TEMPORARY) != 0) { - if (regen_tmpaddr(ia6) == 0) - regen = 1; + if (regen_tmpaddr(ia6)) + regen = true; } in6_purgeaddr(&ia6->ia_ifa); @@ -1010,7 +1010,7 @@ nd6_timer(void *arg) if (V_ip6_use_tempaddr && (ia6->ia6_flags & IN6_IFF_TEMPORARY) != 0 && (oldflags & IN6_IFF_DEPRECATED) == 0) { - if (regen_tmpaddr(ia6) == 0) { + if (regen_tmpaddr(ia6)) { /* * A new temporary address is * generated. @@ -1111,7 +1111,7 @@ restart: /* * ia6 - deprecated/invalidated temporary address */ -static int +static bool regen_tmpaddr(struct in6_ifaddr *ia6) { struct ifaddr *ifa; @@ -1120,6 +1120,11 @@ regen_tmpaddr(struct in6_ifaddr *ia6) NET_EPOCH_ASSERT(); + /* ignore detached prefixes */ + if (ia6->ia6_ndpr == NULL || + (ia6->ia6_ndpr->ndpr_stateflags & NDPRF_DETACHED) != 0) + return (false); + ifp = ia6->ia_ifa.ifa_ifp; CK_STAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { struct in6_ifaddr *it6; @@ -1129,12 +1134,13 @@ regen_tmpaddr(struct in6_ifaddr *ia6) it6 = (struct in6_ifaddr *)ifa; - /* ignore no autoconf addresses. */ - if ((it6->ia6_flags & IN6_IFF_AUTOCONF) == 0) + /* ignore detached or no autoconf addresses. */ + if ((it6->ia6_flags & + (IN6_IFF_AUTOCONF | IN6_IFF_DETACHED)) != IN6_IFF_AUTOCONF) continue; /* ignore autoconf addresses with different prefixes. */ - if (it6->ia6_ndpr == NULL || it6->ia6_ndpr != ia6->ia6_ndpr) + if (it6->ia6_ndpr != ia6->ia6_ndpr) continue; /* @@ -1169,13 +1175,13 @@ regen_tmpaddr(struct in6_ifaddr *ia6) ifa_free(&public_ifa6->ia_ifa); log(LOG_NOTICE, "regen_tmpaddr: failed to create a new" " tmp addr,errno=%d\n", e); - return (-1); + return (false); } ifa_free(&public_ifa6->ia_ifa); - return (0); + return (true); } - return (-1); + return (false); } /*