From nobody Mon Sep 28 15:14:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htlGQ2TRpz6Wnqr for ; Mon, 28 Sep 2026 15:14:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htlGP6v6jz4JJj for ; Mon, 28 Sep 2026 15:14:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790608478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0HslXJdzWEZdYyl2PBlpd1PVUn1WACFp8m/quHiB2QM=; b=FhqgV4Jmg97SYkskKydgCKc80aJazbnpJMiNAQ5+DIhs3kRiPtzY1HBlbIqT0kM2TK1EWv RXSx633dU61/jeXDJnBn9fEc22qSE3QWu0R+dQzEmsHqoMNqAhPsJDq0KCsPF2D3HHyEoG Ak98rkcAm82/DA9UsoyqELHchKg4heWx0rTZ/LB68AtXHBdeGOKiJ7VlexajAqLcw7g1L/ O8qVMzlQSJl0psOjtDG/W+/2XEVxm2p5jHPHKNP1vFxZWSSvpgKUSyaBkqMmN7ufcRvjBr 82gSAq3fxU5hpyMAUKVZ2YdzSOG9gMeu3lPgxo609Ivr90bj90bJS2w0QgPC/A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790608478; b=UVPrI7WAo/Ggu+F+gIJ7uCI795cGwFMC3liaeR/k45sdRfLY9O/+I5UzcfYPskeFZFOksc 6aOiOhaUE/yX95rjcMfgH5c5APTF7c0xA/skK4GXII8Ff6aYyaPXdoOFETsFvTYLMT6Nxi V3Jntfu+jxjAz8GGafLp/jjRed3cHZIn6HWXPha+CTVSj2bvdJ1ZXtyoaya0VMXdRatEcJ 24NqenflnWNEnTIBrzXgXUaxX8W6mn4025j61FTGXn6125usiHtM2M/iRhox3aJIuMlOsf SaaV+7ao8Fx1hH4yFYOVMC4wWlmpFw3aZo1BXzn3QSM1yU3ZMlRGJGLSnOYtNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790608478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0HslXJdzWEZdYyl2PBlpd1PVUn1WACFp8m/quHiB2QM=; b=fUTQUWGArA7vcrD0lpyMdgyXR68X8sJUmUfKveC2dNWIi8FoOIAVcDqve2mtZaiAWBBrf+ TM22VSaPlKTzxFbVi8yoRR74moPv+zs/252r3lAylIWMsUQmTWEuiBEO4Rj+WELw0ay4tF 5G5lIdGjIJcOLxmUmJQOME6LeJwZiGkSUG7r5z4yVGRgyZ5SPEPZhR1IRhUrTJsUvpATkg tcWFW86ArFR+oN1a8NSoHpLYFsePwfhtsOMySX7WICrxXrJgs3KdAXvTfW8f4KE6aXJOao sWFpa9yIK0LYmTjJnangBguceBbhjC87uJmrWgoYNuUvhNVkYcgyFUvFvYsrwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htlGP5zDMzYq3 for ; Mon, 28 Sep 2026 15:14:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21e99 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 15:14:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andrew Griffiths From: Mark Johnston Subject: git: b01f66cb0e3b - stable/15 - proc: free kstack buffers when debug permission changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b01f66cb0e3bdf7f12bac161feaf9bc4d3a5a091 Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 15:14:32 +0000 Message-Id: <6aba8458.21e99.25065d17@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b01f66cb0e3bdf7f12bac161feaf9bc4d3a5a091 commit b01f66cb0e3bdf7f12bac161feaf9bc4d3a5a091 Author: Andrew Griffiths AuthorDate: 2026-09-14 07:55:01 +0000 Commit: Mark Johnston CommitDate: 2026-09-28 13:38:01 +0000 proc: free kstack buffers when debug permission changes The kern.proc.kstack handler allocates its output and stack buffers before deliberately checking p_candebug again under the process lock. If trace-control state changes between authorization checks, the failure path balances the process and exec state but leaks both buffers. Submitted by calif.io for the OpenAI Patch The Planet program Signed-off-by: Andrew Griffiths Fixes: 8b5abd9027b8 ("kern_proc.c: disallow execve around sysctl kern.proc.kstacks") Reviewed by: markj MFC after: 1 week (cherry picked from commit 3484217cc47c1f77d2be2ed0e012b870d1cd3dca) --- sys/kern/kern_proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index add8cbcde1d5..90b558adaf46 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -2892,6 +2892,8 @@ sysctl_kern_proc_kstack(SYSCTL_HANDLER_ARGS) execve_unblock(ctd, p); _PRELE(p); PROC_UNLOCK(p); + stack_destroy(st); + free(kkstp, M_TEMP); return (error); } do {