From nobody Mon Sep 28 15:14:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4htlGL1nlQz6WnyY for ; Mon, 28 Sep 2026 15:14:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4htlGL02nkz4JBl for ; Mon, 28 Sep 2026 15:14:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790608474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gsrHBFwGSUOOlFM1BRB2eJJErb55Z2YucJni7j04yXE=; b=t6kvoWnc7Q74E+aeixXgPv6mNftAo1/IRg+sMM78fcnNIAl5/dnJhh4QofWRv/C5hGNi6p mmoGmcRXNTWz/PZEkC6YiaX6hSewlIPiyJKvwb09OpTImNs9nvrtVNtI/UUEjK47+tchEd TaOBKinHBtcA5Y4F5I28WHn2kfqeUk5A7IkIEpzWRKq8GZ48JVNnm+vRLVz5gMkBu9He8/ sRBYjBBsITRYLwY+3otpp+bbNyqNbAFE59w7e/qQg3dCzx+jO6vbMPpkAjLExqErxYSV3R ijq2Sv6SwaBSxZ6v4CNmU3Wr+tvQ2XIoUPMiccZjMVAWbm3LL9twuJvBESv2yA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790608474; b=yj4McESvH5F1BiMT6h5CG3N0/v/GOelf86yh8uuAmkFMzS03YwNpMYr+aXU1ou91GMWzWA 3Ci8K9oPSwOZaX+BbuzcgYjAZKR2qg166f/sJqelVdFoEzExSQLZAwEQG/a3JNt3drTpy/ 8AliukFj6MHTNUU4hizwX/Ks06Yj+xDeW6zF/FOP5zMiwM8xRZDSsyZZCwG3JFpIFLRfWm Mr8Nd8zTxUBD74M4RTBgV6Za06WooO2D2r5wBIioou3WZBN+mhQqPXBgqOi0VPinCP6Fw/ Nzbr71HQiFwVj6SkQQLH2mFbU+d+k/5vIv9A7OUr8AyZ2gnOnOpF7Kc09dFHaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790608474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gsrHBFwGSUOOlFM1BRB2eJJErb55Z2YucJni7j04yXE=; b=n6DXN8K3ZN5RSBNgKWSf5ZwoQp56ixth1ASXRaCWvHKVrWvL0J22qaJP6CF3jYkFWLaQ/P GX9fbJ5DmoIFcxNVTDyO+e+dWmhc7mYx7OSWk5Za4iSMaxJ5geb/ZHizmI6VuRP/FOmKnd 4/DZgU7VcfKTvyY5WkcQTy9nSciOM1v+2J8BKjEhs4iIhwDtEfv2Wd2X9k++tV2XhE2Rfh 2OtRoFn/tX0+OmGGp/k3ubF+Xl9zZfThgqRUL34LF9i2M7yS3aJlO1n+l55MrWlAwY82hO tudp+pUdm6JIN26IxRyYfkq23xsBnTE768DZL1+XqRHrzK0o8ubI4dsXESRROQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4htlGK5PPHzYQj for ; Mon, 28 Sep 2026 15:14:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2193c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 28 Sep 2026 15:14:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Benjamin Jacobs From: Mark Johnston Subject: git: 52850d1831de - stable/15 - dtrace/arm64: de-pessimize dtrace_copy List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 52850d1831de7a3e1ab4aeba3919b26f68f4b7dc Auto-Submitted: auto-generated Date: Mon, 28 Sep 2026 15:14:33 +0000 Message-Id: <6aba8459.2193c.53e01d40@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=52850d1831de7a3e1ab4aeba3919b26f68f4b7dc commit 52850d1831de7a3e1ab4aeba3919b26f68f4b7dc Author: Benjamin Jacobs AuthorDate: 2026-09-09 09:57:12 +0000 Commit: Mark Johnston CommitDate: 2026-09-28 13:38:01 +0000 dtrace/arm64: de-pessimize dtrace_copy When DTrace catches a data abort exception it resumes execution on the next instruction. If a probe executes copyinto from unmapped memory, then dtrace_copy keeps faulting on successive bytes until the loop counter is exhausted. Detect the situation by witnessing the absence of zero-extension from an aborted unprivileged load. Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D59341 (cherry picked from commit 464b29857ff18801aca49d1001643c5cdd1324e8) --- sys/cddl/dev/dtrace/aarch64/dtrace_asm.S | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/sys/cddl/dev/dtrace/aarch64/dtrace_asm.S b/sys/cddl/dev/dtrace/aarch64/dtrace_asm.S index a934733251a3..decca6f79e0c 100644 --- a/sys/cddl/dev/dtrace/aarch64/dtrace_asm.S +++ b/sys/cddl/dev/dtrace/aarch64/dtrace_asm.S @@ -109,8 +109,11 @@ dtrace_copy(uintptr_t uaddr, uintptr_t kaddr, size_t size) ENTRY(dtrace_copy) cbz x2, 2f /* If len == 0 then skip loop */ 1: - ldtrb w4, [x0] /* Load from uaddr */ + mvn x4, xzr /* Set all bits */ + ldtrb w4, [x0] /* Load from uaddr or raise data abort */ add x0, x0, #1 + lsr x3, x4, #32 /* Extract zero-extended high bits */ + cbnz x3, 2f /* If high bits != 0 then break */ strb w4, [x1], #1 /* Store in kaddr */ sub x2, x2, #1 /* len-- */ cbnz x2, 1b @@ -120,15 +123,16 @@ END(dtrace_copy) /* void -dtrace_copystr(uintptr_t uaddr, uintptr_t kaddr, size_t size, - volatile uint16_t *flags) -XXX: Check for flags? +dtrace_copystr(uintptr_t uaddr, uintptr_t kaddr, size_t size) */ ENTRY(dtrace_copystr) cbz x2, 2f /* If len == 0 then skip loop */ 1: - ldtrb w4, [x0] /* Load from uaddr */ + mvn x4, xzr /* Set all bits */ + ldtrb w4, [x0] /* Load from uaddr or raise data abort */ add x0, x0, #1 + lsr x3, x4, #32 /* Extract zero-extended high bits */ + cbnz x3, 2f /* If high bits != 0 then break */ strb w4, [x1], #1 /* Store in kaddr */ cbz w4, 2f /* If == 0 then break */ sub x2, x2, #1 /* len-- */