From nobody Sat Sep 26 03:10:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hsCHm6sjNz6t8Rk for ; Sat, 26 Sep 2026 03:10:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hsCHm4d1lz4ncf for ; Sat, 26 Sep 2026 03:10:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790392228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gWsYAkzzlH+dr5EzwlzVmrMUA+RbLQtFQprrN3DOkkM=; b=Ms9jDqVyY4RsZ1WqtBXx4E389BkTfwtpJbPaA9clZslcAZyjF9uJSyyS1Zv5pln7y6hS+a vUTD98wuwTsKxgt9em1s0Fv0NtYvpfV40lQOwlbbnxQypB6aSd6NnAoRax4PPbpz22IGhH 5xZyEIlX+XDAYT/0WCS0S9Afh///1iSQyC2fAF2Wy3YsxaUZPuYz+r6IFZjmVBcI8O4aSN R8vfITwP5OOnuwHBA3EsjNlB5CQp7RC5aa12vNLToILbbg2MY9xmeXbwWIEg/snudFqakj c/mr5V7R7a0rbYQsfHZAnyQVgptBJKy05TbEXAMqKkKJSvjTfom5Bq7wmqP5rA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790392228; b=PBcWdokvzc2sYon4QBmk0mupF7i8mj/gXaw2GEQOoJ3LD0NfUpNvqyjxEAyni/qNSBQhnx QNl1k9aah4SUoP8U93meL09V80btTtTU5o+YpTVThT0meiLpaPe00o/KYji9iRbVLhy2Ul 2AFhwbYsX1U+7lpKzDueZZEbYnGL8WBsCLgB5pFMZzgEm4Hc1pm7uKVmfJQTL5mX1j5wCv h/2TJmBkkyJ1EZ17lVzm1GKfO8LATqmgZ4Jb2OsdeEEtD9h3JEfrMN7YdsIBsY/MScxe8U /jdT7f3DGDQ5qLHKCMOde7p998TVe1T/sVhjV1DFBo1ogCBURcg++ZElsTMCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790392228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gWsYAkzzlH+dr5EzwlzVmrMUA+RbLQtFQprrN3DOkkM=; b=AzqXyWki0mf5A0ycpsR1h/hzLuYrhW5Ov6es+fayQBela7Vb2LkU/7ORLwaRy4FLHrm9v/ 8Jkh+PmzqzOyyKwzpwtMQ76RiyXLDXRTa+Spuvqha9lwSFm6pMjD8SF+tLzpAIs/oG+IP/ mHetWcWDxTFmnSagBsuzd79wryJO6wVbJhme4ugpUFnSRZLmbDc6+tgUfty10In3z3nCNd b/5ALGesxEPjM0coiYAOPBSfaXAtJaDX29sQqCkZoq8rGTPYDH58pJNNlCvYLlEfTcUFEj gCT/FITUrCrZrCh0nNIynZstb6vMntDC8djP9tvGxWdEISkoDXbfTguah0ferg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hsCHm3fPZzfjw for ; Sat, 26 Sep 2026 03:10:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ccd3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 26 Sep 2026 03:10:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Yunheeee From: Xin LI Subject: git: 269002da4538 - main - fsck_msdosfs: fix head bitmap over-allocation on 32-bit platforms List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 269002da453895fc935101afefeb02d2c7d10360 Auto-Submitted: auto-generated Date: Sat, 26 Sep 2026 03:10:23 +0000 Message-Id: <6ab7379f.3ccd3.68c404cf@gitrepo.freebsd.org> The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=269002da453895fc935101afefeb02d2c7d10360 commit 269002da453895fc935101afefeb02d2c7d10360 Author: Yunheeee AuthorDate: 2026-09-26 03:10:04 +0000 Commit: Xin LI CommitDate: 2026-09-26 03:10:04 +0000 fsck_msdosfs: fix head bitmap over-allocation on 32-bit platforms bitmap_ctor() computed the allocation size as roundup2(bits, LONG_BIT) / (LONG_BIT / 8) The dividend is a count of bits, so converting it to bytes requires dividing by 8 (bits per byte), not by LONG_BIT / 8 (bytes per long). The two divisors happen to coincide on LP64, but on ILP32 platforms the head bitmap was allocated at twice the required size; for a FAT32 file system with close to 2^28 clusters, that is 64 MiB instead of 32 MiB. The extra half of the allocation was never accessed, so there is no functional change other than the reduced memory footprint. MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/2440 --- sbin/fsck_msdosfs/fat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/fsck_msdosfs/fat.c b/sbin/fsck_msdosfs/fat.c index 7d0ad9a595cf..ef788c9826a4 100644 --- a/sbin/fsck_msdosfs/fat.c +++ b/sbin/fsck_msdosfs/fat.c @@ -121,7 +121,7 @@ bitmap_count(long_bitmap_t *lbp) static int bitmap_ctor(long_bitmap_t *lbp, size_t bits, bool allone) { - size_t bitmap_size = roundup2(bits, LONG_BIT) / (LONG_BIT / 8); + size_t bitmap_size = roundup2(bits, LONG_BIT) / 8; free(lbp->map); lbp->map = calloc(1, bitmap_size);