From nobody Thu Sep 24 18:39:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrN0j32m4z6t3vZ for ; Thu, 24 Sep 2026 18:39:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrN0j1SqDz4ryf for ; Thu, 24 Sep 2026 18:39:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790275173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A5+ep0bQcIA5mYl4FdHAXTy4EzsHYIGKJ53YFjQ5oX0=; b=X5u93bsWgPVkRioTbUVPc+AhES+Iy2mwlx3SUzoF4O4rUaFFlk0ZktZ1EBbmQJRBSKoZ9D 6HzsoEhmn95a0rkKAXZBFH9MPU5h2aF4F8pBdckxSWHqtClGL5k/PSOKVB7TVUthISr/Vq Ep1a7WTiSh5J5OMk5JuvRuzGQ8igG3w4BtYNoc18cNtXgSSS9uEecDdsSVXHW1Ld7Tes6B i3QaDEXxqq6/6D60QrKS2u7+4joYK4x6kU6ETQ+l4wBo5QaeInowk9QUHRinhwyFbHk5aY Y7auKrcTDPs0OBREeQW+tc+5c1UMdNHZUKOW/SHGDY2dinCZNJ51dFmfwSy/4A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790275173; b=cgmFszmwjZczmidoA/T7sd5aIM7I4XD1vlp3j8gWtCZlH3gG+1Js88B2srz0LWS4OMkEYX M65NTPt9LQEuXUqcQxJMuRzNVDnZCOGcNQ/Jkmv5P96cOp2VmKmVjmRF5hctsJlRWdzFWZ dHtC4BSFlvqzBtCG8y+ArKYUTxKjKI8FF37TFL/crHwV3br7RN9VQ3cvsTasDh+KiZxoR8 enNvcV+gAE/g1rRv4TLniR0x8NA+HXALI2JNH0XJzUSFJqLLSL8QX2VfHSV8H2PlSn+LKh nEvpD8tYP64fFOgVHTldZyu0Qx4vKgZwV2qbEBIaXdbZo0j26tgRp6QYOaXFYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790275173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A5+ep0bQcIA5mYl4FdHAXTy4EzsHYIGKJ53YFjQ5oX0=; b=H7KJDK4+xOpMtvPwxaoqC+zHKgNPJQ046qw74PgW1dnq2CRgdKtOFxHaPNByOh8dBTRixB 5bCnY7NCCV4Md7NLnc8FAOaT8NiidQn8pt3Ux7YHuqq2FGto/9Fh9s9PA4KQOagEKvBpmB k2GgtVzWOlnf5AgqO6qeFnQIVeNr1LKiCtQVrAIqjowXH5q8a6Jw/UwNqPb9t5FDGiPrFh hN2WW1/AF23Dy7b9d9hjGSmpZHIEbkCw/84H3q2Diebe/Tsdq9avwv1m7PZNpSlUTgRCmh dLw5lzRsDVfCSY/9KnF13z7PrWJqTemVFtbE6vGaQUXvHMOQkP2W9un9/eP3GQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrN0h5K74zcvM for ; Thu, 24 Sep 2026 18:39:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 235d8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 24 Sep 2026 18:39:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 30ad8440b468 - main - VFS: require locked vnode for fsync() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 30ad8440b46838b050360ed87e6165a067f1cf8a Auto-Submitted: auto-generated Date: Thu, 24 Sep 2026 18:39:32 +0000 Message-Id: <6ab56e64.235d8.499a470d@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=30ad8440b46838b050360ed87e6165a067f1cf8a commit 30ad8440b46838b050360ed87e6165a067f1cf8a Author: Konstantin Belousov AuthorDate: 2026-09-20 03:22:39 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-24 18:38:33 +0000 VFS: require locked vnode for fsync() Stop exempting devfs nodes. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D59932 --- sys/kern/vfs_subr.c | 20 ++++++++------------ sys/kern/vnode_if.src | 2 +- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index f324e02e44d7..34f7b32de1b9 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -5962,8 +5962,6 @@ vop_fsync_debugprepost(struct vnode *vp, const char *name) { struct mount *mp; - if (vp->v_type == VCHR) - ; /* * The shared vs. exclusive locking policy for fsync() * is actually determined by vp's write mount as indicated @@ -5979,16 +5977,14 @@ vop_fsync_debugprepost(struct vnode *vp, const char *name) * should still be caught when the stacked filesystem * invokes VOP_FSYNC() on the underlying filesystem. */ - else { - mp = NULL; - VOP_GETWRITEMOUNT(vp, &mp); - if (vn_lktype_write(mp, vp) == LK_SHARED) - ASSERT_VOP_LOCKED(vp, name); - else - ASSERT_VOP_ELOCKED(vp, name); - if (mp != NULL) - vfs_rel(mp); - } + mp = NULL; + VOP_GETWRITEMOUNT(vp, &mp); + if (vn_lktype_write(mp, vp) == LK_SHARED) + ASSERT_VOP_LOCKED(vp, name); + else + ASSERT_VOP_ELOCKED(vp, name); + if (mp != NULL) + vfs_rel(mp); } void diff --git a/sys/kern/vnode_if.src b/sys/kern/vnode_if.src index d20ff39b314e..96e826ec86b6 100644 --- a/sys/kern/vnode_if.src +++ b/sys/kern/vnode_if.src @@ -292,7 +292,7 @@ vop_revoke { }; -%% fsync vp - - - +%% fsync vp L L L %! fsync pre vop_fsync_debugpre %! fsync post vop_fsync_debugpost