From nobody Wed Sep 23 18:07:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hqlL95YLFz6tQF7 for ; Wed, 23 Sep 2026 18:07:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hqlL94rfkz4nYk for ; Wed, 23 Sep 2026 18:07:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790186849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jG+wXTAf6FdMgu8/rg7L1Q1uSmRYqVueYST8biCSBtI=; b=rvUy108KNkyxIV9c9JdFYRYnc6SN+xvcua70xhqrFFkyuietWA4phmyMh2TlFGqhn79ZZs n0m/7QyXdaHN807N9XK47M+mXUgT0bkCtw6LjKNscX0Y+V3ybHTX1MJqnf9O283jrwJUHn FIi1W2gmdz07aPOfRleMLnmIsuyVx8JKXBAVns25QpSn3n8KzwXHAntSQWtLTvOJ7sE/nZ htmjqOPMCCySsaiBN9WDge6cfP/16ll73bYb2zgIOfpZiI2XVXkeN5A8j/L7vbp41iEXQ4 XSPW+aTat24GIUPLDS0C9urEI2nTevy+4q5DxTFkFnoLHQWuW4rDE9+Vjvc3HQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790186849; b=PD2AD3Y9BCzD2lABYp110DPu8XaZYoVfmccJqUFDNhGK5wAAMbe4LpTMInsfuEZE0Jmohd dNZOaXgmHzOsRxhIsqA2DAvqnKloo5HGIOfSfoEffjU/1j+bGIl648P7hlpNWpW41ElYnM QISna7AwVt1WzrIzGlcStXZ76TqUOuYx8EkfZslJ4jp2I5qJOou+agfIhuas6ojo498SdC Vk6eY3safcbuQll2SKWT/2ogxHjUJiKVTXDe91cbAYBVXuX5grIo75QtvVSwBfNLzuyrIp d0ZIWhz9t7wd/iUZvwfAeR2CavDohnxMGJ3xxqsG3k2SgHSYyvZ9H1MCpMQ/5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790186849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jG+wXTAf6FdMgu8/rg7L1Q1uSmRYqVueYST8biCSBtI=; b=VjR63vckSbXRprKECy6esqC7BOo2smO8cF7wBxBQCGJQiju0WqKnHbqDWDKKFcRXOND1H8 0k/j0tkJ0yGAO2Ne3c+WO3K8yrQRw3Boo62KcnWjNgo5t5AOyq3UR5aC+coQb+Z+7pMy84 mkt/mthZXDyIZ+fdX16fIZfyIFwUKR0bqvSrotpy3e3IhQFyv/WQa7f4nIa2a2U30yZ8Ow e76KlkFJuQeh1pd3TvoS3Y7FE83V1VM7kxMm5iVMJYzFzQRPCGJwussLoLSd47BQBUUYTQ GT/4oDRx5rN5foSmlx8wHqGaWkRe06cBr7DN1vBifeRk39huB7uQDbUVoqmvag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hqlL93wxHz12jX for ; Wed, 23 Sep 2026 18:07:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f99d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 23 Sep 2026 18:07:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Abdelkader Boudih Subject: git: 34f131f1de85 - main - nvme: bound the AER error log byte-swap by the fetched length List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: seuros X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 34f131f1de853ae824a6e67dd6429332d23b373d Auto-Submitted: auto-generated Date: Wed, 23 Sep 2026 18:07:29 +0000 Message-Id: <6ab41561.1f99d.23a8cdb8@gitrepo.freebsd.org> The branch main has been updated by seuros: URL: https://cgit.FreeBSD.org/src/commit/?id=34f131f1de853ae824a6e67dd6429332d23b373d commit 34f131f1de853ae824a6e67dd6429332d23b373d Author: Abdelkader Boudih AuthorDate: 2026-09-23 18:02:38 +0000 Commit: Abdelkader Boudih CommitDate: 2026-09-23 18:02:38 +0000 nvme: bound the AER error log byte-swap by the fetched length The Get Log Page request for the error log is clamped to NVME_MAX_AER_LOG_SIZE, but the byte-swap loop iterated ELPE + 1 entries. A controller reporting more than 63 entries makes the loop overrun the 4 KiB log page buffer. Reviewed by: ngie, imp, adrian Differential Revision: https://reviews.freebsd.org/D59626 --- sys/dev/nvme/nvme_ctrlr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 6dba83708df4..6d2749b90b20 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1291,7 +1291,7 @@ nvme_ctrlr_aer_task(void *arg, int pending) case NVME_LOG_ERROR: { struct nvme_error_information_entry *err = (struct nvme_error_information_entry *)aer->log_page_buffer; - for (int i = 0; i < (aer->ctrlr->cdata.elpe + 1); i++) + for (uint32_t i = 0; i < aer->log_page_size / sizeof(*err); i++) nvme_error_information_entry_swapbytes(err++); break; }