From nobody Tue Sep 22 07:32:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpsHh4ytvz6tH9X for ; Tue, 22 Sep 2026 07:32:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpsHh4SRDz4TV3 for ; Tue, 22 Sep 2026 07:32:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790062336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W0H2+UgrnPOMdiK2qFNsEah8SMQ3JM1ZTJBUfo+/nb8=; b=n8wpRHu9rejEFf/ENF9Bux/0b+fGL5ej9SLTMW1hsM0AOiTM9i6OsrEzyEfgy296qfKD1P KP/NB/R02WXQ8gWOT/dyOLgxJ5l6m3npSi1MkxjSds9ljdcmAF+X45aJtr7YegBk5w+Pfj xEWeFIoXxp0OhYN3dbDMsl2xnhkSgQ7TxZlrcqdLuMatXPaE6lBIq+eD1IlbW+AvIGDsF5 fljS3Hlisbst+iY627r6XUjBbEtri6uuBOq9fUNWKM9VkcIm3E0de5fLB2NMEJRVi+NfeM rnFiafocgn1MyPr608tKNrcMvEIARfL4IkbRD9dLQoQNNbpZidUpMpNYgUAV8g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790062336; b=FzLYSIJfVuddhQ/xlo62qfCuDuIkh0AnPz9mD4gdJ78k6l2vbxMxY126VFRTRYkaMJix7s 1bRHkAINIDLEblonUCVO4zrLhNeT2pcWic+JMsPnkQlLHbYQtcyXcyFH7kiuLVY4x2gf1o pcOygXE888PX1KenPlfJEqloYxOQflltEiPBlJVrKKj8cfuy8Y+jhB4nAFYebdpY2PUyhk h+2ucLFwjIODaycW4zhiiLKkggqfjm1GGukX/MXSK21WBBzk4YuTjPPc8AlTFWIqQmh+1a NtdAs+NWS/lKbZsmOKTtFLzQFIedRSTCRnypqn9q2hbxJzHAvvV8gfHmaJrp2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790062336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W0H2+UgrnPOMdiK2qFNsEah8SMQ3JM1ZTJBUfo+/nb8=; b=GWKZbgHR6L4DAzYTIygGP2SK8RFyRgECFlxc4hvt2qnH5oQmBIMshpz9ptjlCLblcz7rTo MwFo/+lA6SQfj1m812BHl2EhQmyzk1mIAacsGlLSOV8K6M7eaT7l3++YzNq+HQy1/mxzNm ZwrnadYAs1qde9rdwmI5CrA0qq37gQuosB2LoBxOogmmKDgKjSWZBl45c9KvWDzTld5MKN Z6WkAkvEbM9jj3U15tUt/lRBx0BVfUBZj/UVxSemikqwAo3xqVKcu42txVHoeOO4UJvXcC eRBkD9ryGlDyU/gf0l5xed3EnLVCXFGS4+eQnSbGYqBPJZCUeWc5iq2DXSaATA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpsHh3Wv9zxlM for ; Tue, 22 Sep 2026 07:32:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22500 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 22 Sep 2026 07:32:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrey V. Elsukov Subject: git: 9b4b68e82739 - stable/14 - ipfw: fix gcc warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9b4b68e82739e7f5e0ea337abffd0cadcb9abc8b Auto-Submitted: auto-generated Date: Tue, 22 Sep 2026 07:32:11 +0000 Message-Id: <6ab22efb.22500.2cd557e8@gitrepo.freebsd.org> The branch stable/14 has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=9b4b68e82739e7f5e0ea337abffd0cadcb9abc8b commit 9b4b68e82739e7f5e0ea337abffd0cadcb9abc8b Author: Andrey V. Elsukov AuthorDate: 2026-09-22 07:21:52 +0000 Commit: Andrey V. Elsukov CommitDate: 2026-09-22 07:21:52 +0000 ipfw: fix gcc warning We use first loop only for possible needed realloc, so it is not required to restrict end condition. Also check realloc() return value before accessing. This is direct commit to stable/14. Reported by: dim Differential Revision: https://reviews.freebsd.org/D56616 --- sbin/ipfw/ipfw2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/ipfw/ipfw2.c b/sbin/ipfw/ipfw2.c index a8a70dccf125..99a94a1b9d1d 100644 --- a/sbin/ipfw/ipfw2.c +++ b/sbin/ipfw/ipfw2.c @@ -5883,12 +5883,12 @@ ipfw_detect_u32_kbi(void) need = sizeof(ipfw_obj_lheader) + (64 * sizeof(ipfw_sopt_info)); opver = 0; - for (i = 4; i >= 0; i--) { + for (i = 5; i > 0; i--) { hdr = realloc(hdr, need); - memset(hdr, 0, need); if (hdr == NULL) break; + memset(hdr, 0, need); hdr->opheader.opcode = IP_FW_DUMP_SOPTCODES; hdr->opheader.version = opver; hdr->size = need;