From nobody Tue Sep 22 02:37:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpklK5hsyz6ss8x for ; Tue, 22 Sep 2026 02:37:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpklK3rSdz4cB8 for ; Tue, 22 Sep 2026 02:37:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790044637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SW0yPFckjDpW632OSgd3dFT1Ol31HuX3V8/QNY9HGZo=; b=FO0aCC/k3FRjjoh8YsLhNXPcLNvZtcIQ3Ge/tKG60/8FegJU0WMhxHpGq1BoE31MHqRiQO iQ+poZ+hQ5E1GUtuR1mBzPX5/2CSNXudkAVzRKZCuQbzjLl2Fn16mHmuHFx6vFQKfhV9mn SWYcLReEv2/HP5kGJHBkZtNItPa4gfZvTh9Gbz2Tyl82e7YF9F1q66v1kHqFeyjcdo9rAJ xn091ItikIJ4Dr0fYz3i07o+zWGZJgX+Nz4ImWouAGIhepVfi/4OSGkbH1MloF2Gm5KipF I20Bn7jq/ShIGrzm57nZif0zPIDplo7Wj3ZEjFoYyueGE6Lbue7V8De1DVCDMg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790044637; b=ProVLbLxBCAxJBDPCIE0+1LEWLInHd2FIHwYMqEua9z5iBI1ZVvsVpbWlYYVdmQgw0N0qG /9/sWnRz7jLbn2LC8V4wVzJyosuG4tzulKoBJCcbTdCz/qRsp6yE85Z3in+Q+06Iig+h/r O7V3EiTCNIzwvtrSA31pmMxYlLix6X1n8xIeNOgtHWXkf+KxcLh5QrktZGcRaf/6c4LZtM tc8mvwi5mMnrFwUqk1HwM5QLNmpp4NYoNEUK/NqT3qvcA15K0/zW3aFCbNLGExvpkCn+lL 9D5njYr/+CfsNzLZ1wJzd/nHsTy90mA2ankFrJuzkmEpWxZLgNUSA8tOjhaNuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790044637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SW0yPFckjDpW632OSgd3dFT1Ol31HuX3V8/QNY9HGZo=; b=IMGV2bYzhEOOG1NGIJ48M11qGDKsLSLAQozjmrv2X8c+iqm1M/LE8CohorMu7vZ2/aegJ+ prz1uJ/mVPbO75ztH0vwGcYYD+Dbf4bHUwH+TsCee28uRE31QRl02A68iJWQlmsJ9IE50W agzKztTs8GYe6jGoUTvKIeOBD8E9gc4xC75cRgPN57Lr6uCXsIV3ddxlEYIX4yn08H1jgw hLGejrxsJQcwYjRGSMQjTxUQd6ydBfehU1Nj8wA1JQywVJ7bCLqUx6/cXwACsJLxLNLB5B pIam2QfRMEcAw2Xkp4wekF+1dr9k6gNy2FukGeln+Ew9IW6edZLEFohhsvMeqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpklK1XSMznc0 for ; Tue, 22 Sep 2026 02:37:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 215f3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 22 Sep 2026 02:37:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Maxim Konovalov Subject: git: 04fcf3096126 - main - dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: maxim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 04fcf30961266cd77139b40774cb0d6ef6eb2be5 Auto-Submitted: auto-generated Date: Tue, 22 Sep 2026 02:37:12 +0000 Message-Id: <6ab1e9d8.215f3.12830f63@gitrepo.freebsd.org> The branch main has been updated by maxim: URL: https://cgit.FreeBSD.org/src/commit/?id=04fcf30961266cd77139b40774cb0d6ef6eb2be5 commit 04fcf30961266cd77139b40774cb0d6ef6eb2be5 Author: Maxim Konovalov AuthorDate: 2026-09-21 23:32:09 +0000 Commit: Maxim Konovalov CommitDate: 2026-09-22 02:36:46 +0000 dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array Otherwise, the following would segfault dnctl pipe 1 config bw 1Mbit/s profile 1025points.txt Found with: Claude Code Sonnet 5 MFC after: 2 weeks --- sbin/ipfw/dummynet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sbin/ipfw/dummynet.c b/sbin/ipfw/dummynet.c index a0cefcffd183..3cf9a1854365 100644 --- a/sbin/ipfw/dummynet.c +++ b/sbin/ipfw/dummynet.c @@ -959,6 +959,9 @@ load_extra_delays(const char *filename, struct dn_profile *p, } else if (do_points) { if (!is_valid_number(name) || !is_valid_number(arg)) errx(ED_EFMT("invalid point found")); + if (points_no >= ED_MAX_SAMPLES_NO) + errx(ED_EFMT("too many samples, maximum is %d"), + ED_MAX_SAMPLES_NO); if (delay_first) { points[points_no].delay = atof(name); points[points_no].prob = atof(arg);