From nobody Mon Sep 21 16:41:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpTWs28fSz6srW7 for ; Mon, 21 Sep 2026 16:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpTWr6G0qz4plJ for ; Mon, 21 Sep 2026 16:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790008888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+h9a0nMmG8CFUP71aRwEGjjr9m50jmY7vKefKJGqDRU=; b=Sr3aWGAmeS9XeeOBfcHlatW/TBNdERNOvuZAu0HViPE2nghsF6Mthl9rgpjapMUHMDr0is y4CeWwyJTziratyHU254s/39bujKtQxt2RFoHmxeSIiiGsiYiLswQn5wO8eP4FD+SohRiJ TkABpDVqy9s1ScroCva95Tqx2tZbkroVXQQ08v46l+XtMUOyu8U4msLayyfxTBZsJKdXC8 HOcAIrGwN6bBwNdBelCPr/JjCaXbZSyL6bwGNn1k2+qQaN1FkdI16eyLLcqPZEmoF7qsXN syDWK9FhaTdzHmiORdzxj2k1oujqAtAMxeycvnauIKsWPUonZZamkhX9nEJciA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790008888; b=U7gYvhKqYKxb4iipAVytSIfrVUhYWld2bwf0lpVvMWBGMPT7X6Znx4xV8MJwGPP23VOMNN +9FBF732DXN1X1y0Aub++nRZd4OKRHslsRJ6PRkKytkRbA5z1Vbs6OxbYRyM+jjL7jOAmb AgMyT8GbSskOM55qXcE5eOyVKhIB3v08nvwlzviZt6/Jf22doB6LBQAQSG/sO3o/YhxHZW zJL8R9Kpub2AjjTPiCNfO196F7fke36GpVADwt2/crqef4pwJcMA6BjRy+CUN/7xbPeHJZ qk3hEGOKD24TKdMnHK/hLoRevIJXGUSlQkgC+2cW0WxHyiU7o67q5Kq7SR9UJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790008888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+h9a0nMmG8CFUP71aRwEGjjr9m50jmY7vKefKJGqDRU=; b=k+YJZzEgLXI8JXeLTq3Qtv+cudly+FrRDbt4cbSyIfJ6jIIsHtz8JH1jCRQstuYT9vjTnm R/9PQpMygctdrbY/bHTMl1kjX8OcBmCEybpzWhrysSBcpX3XOLvFJtNEf3qfoCsrpykzN4 8rVQM6Z7SnhqvnYrME6MsEfv97ID47EtbcDWF/D1SpbXERABIjY0Dqgkvg72OkrF3EkqSR FLWn7bNSXpTTyeSeRUZ7DalOMAPWmMkWOFRaNHhR4gXiJc99sTBauAVFJLaA8tA+ZCb1+G eqoVj7K2OFjEmPFo/j1qAPZKUyuhM+5tmFzf7kzYK0IAIGLhNSvjQDym5zpNaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpTWr57sRzSLj for ; Mon, 21 Sep 2026 16:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39169 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 21 Sep 2026 16:41:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Hayzam Sherif From: Mark Johnston Subject: git: 3330226fd33a - main - vmm: Normalize a zero PIT count before starting channel 0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3330226fd33ae6b747c9edc97315244360ad5e54 Auto-Submitted: auto-generated Date: Mon, 21 Sep 2026 16:41:23 +0000 Message-Id: <6ab15e33.39169.4b5a213@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3330226fd33ae6b747c9edc97315244360ad5e54 commit 3330226fd33ae6b747c9edc97315244360ad5e54 Author: Hayzam Sherif AuthorDate: 2026-09-21 16:33:36 +0000 Commit: Mark Johnston CommitDate: 2026-09-21 16:35:58 +0000 vmm: Normalize a zero PIT count before starting channel 0 pit_timer_start_cntr0() does not schedule a callout when the initial count is zero. The counter write handler normalizes a programmed zero count only after calling it, leaving an initially unarmed channel 0 without a scheduled timer event. Move the existing normalization before the timer-start call. Retain the historical 0xffff representation of a zero count. Reviewed by: markj MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59749 --- sys/amd64/vmm/io/vatpit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/amd64/vmm/io/vatpit.c b/sys/amd64/vmm/io/vatpit.c index 31b6c2ad0f89..595c2e070c7a 100644 --- a/sys/amd64/vmm/io/vatpit.c +++ b/sys/amd64/vmm/io/vatpit.c @@ -401,14 +401,14 @@ vatpit_handler(struct vm *vm, bool in, int port, int bytes, uint32_t *eax) c->frbyte = 0; c->crbyte = 0; c->initial = c->cr[0] | (uint16_t)c->cr[1] << 8; + if (c->initial == 0) + c->initial = 0xffff; binuptime(&c->now_bt); /* Start an interval timer for channel 0 */ if (port == TIMER_CNTR0) { c->callout_bt = c->now_bt; pit_timer_start_cntr0(vatpit); } - if (c->initial == 0) - c->initial = 0xffff; } } VATPIT_UNLOCK(vatpit);