From nobody Sun Sep 20 07:02:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hncjx0D2Zz6t0YL for ; Sun, 20 Sep 2026 07:02:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hncjw5KKnz4Fl8 for ; Sun, 20 Sep 2026 07:02:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789887732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WiOI64xDeng390PLf53s/20/IrQWnhJyHVFDmdo+gPQ=; b=hvxFrYNe5jCXlxwLWS/OsuJ5BhayO/noeZ/Zj/vlhhdxGkfxnv3i0MdVbjA5o3GFEIIvvy 35jT4GekBgfaJF4SFpfXIKV+UdYrEXjhHTKZzUyWhlvAyh/ZxgVlst6mqsnBuavabn/aTk fzyjMYU/MwZmgzTNovSJgIRJ9V/3wFOe6enqESnA+LKrtKxxFPFLJoq8Nk/Ocm4EwYO0KH kbiIM3QAZ9Zm/eD/EWAZKjjOVbH5WDDCXCzAEEmd5KMO1rFC4MjMK4KAIbScQ2gQbF/wfV A7rSsSMYIspFczgdJFXECD/Lhok1MLUWEbxdwzC2TjBy91gh5XgJa+d6pL1rFw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789887732; b=vZix+WmC5TfIlUVeMjPPi6inUOu+TCECX1OZwCpZjWdrvZ1tmn/XhvlsqreAEVCxpK0Z9h ohuZBQv+WIim3ZGc69EdZgHjUAO5noUnaCZvFvHSo7ZEJyHHHOiZAMn6r98pTKBWURB5BL la0vtjPlU1fga7XTZPZi/RIAjeRVaHoVHinXTzU7sMIaYZkdQ9LFtpIKgHzopWhIJJfL2X fj85LXiye493Jyhb2BlKeYtocG1Ek9ao62rjFbION60O8oz/3r6cLGKAJ/8uaarK3oSLhk lCQTu8qAoHiz3nnplAbtvzOf3G5Ot+4I5NC0569Zf6ZayvqKHE8XdTcBYyT5BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789887732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WiOI64xDeng390PLf53s/20/IrQWnhJyHVFDmdo+gPQ=; b=vkcqSNVaSXUkpAD2KjIPMVLYLlG1YPCf8Ib6nqY0R856J/Ph5K/eZXK8XapPvSiqwtP68p Vq1eZX3Iw1P/Pwyz5deg2C5PhEFLtD9zPgrCXJ0Y+N8cPPs+9T9Y/pE2Sw/kSof+T6TcvX HqChLh7hiK0d6v549/AWyiANNlJ+Vm41+GUR5b7/3BZnOS7Cf2GVyd4CSh274FSfsE4Rbc LWdXyPJT3bTJf6AN5uA0hZ1mrcNlhjZkDSWwc/TAREqeGAKO6AzCoK/MLHIw3LYyGA/s7G BVXZ32FakMdvKtiY8XI8x1GFf+QCzCzhZ1GsA7FF5XAsiDtVE8rrqBR49DBUDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hncjw3M00zMsh for ; Sun, 20 Sep 2026 07:02:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 406cf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 20 Sep 2026 07:02:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: aca53fc2a687 - main - Fix statement with no effect in linuxkpi's xarray.h List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: aca53fc2a6879f45dcbe1a60f91f14a5f6d48448 Auto-Submitted: auto-generated Date: Sun, 20 Sep 2026 07:02:12 +0000 Message-Id: <6aaf84f4.406cf.2d04f895@gitrepo.freebsd.org> The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=aca53fc2a6879f45dcbe1a60f91f14a5f6d48448 commit aca53fc2a6879f45dcbe1a60f91f14a5f6d48448 Author: Dimitry Andric AuthorDate: 2026-09-18 07:07:46 +0000 Commit: Dimitry Andric CommitDate: 2026-09-20 07:01:47 +0000 Fix statement with no effect in linuxkpi's xarray.h When compiling the kernel with gcc 14, errors similar to the following are emitted: sys/dev/cxgbe/iw_cxgbe/ev.c: In function 'c4iw_ev_handler': sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:274:17: note: in expansion of macro 'xa_unlock_irqrestore' 274 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:283:17: note: in expansion of macro 'xa_unlock_irqrestore' 283 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ It looks like the intent of the "flags == 0" statement was to make the 'flags' macro argument not unused, but it still results in a warning. Use the construct "(void)flags" instead. Reviewed by: bz MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D59787 --- sys/compat/linuxkpi/common/include/linux/xarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/xarray.h b/sys/compat/linuxkpi/common/include/linux/xarray.h index a5b53b923719..10c10602407d 100644 --- a/sys/compat/linuxkpi/common/include/linux/xarray.h +++ b/sys/compat/linuxkpi/common/include/linux/xarray.h @@ -129,7 +129,7 @@ void *__xa_next(struct xarray *, unsigned long *, bool); #define xa_unlock_irqrestore(xa, flags) \ do { \ xa_unlock((xa)); \ - flags == 0; \ + (void)flags; \ } while (0) static inline int