From nobody Fri Sep 18 23:03:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmp896bMqz6t6Cr for ; Fri, 18 Sep 2026 23:03:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmp895tYxz3FNl for ; Fri, 18 Sep 2026 23:03:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789772617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kb5+YryhvlEcRMCIcUBmkqdlDRd/GLe0prWoerCunhg=; b=h9GppTHgXoj3nsyb+5yf5RqLNUOABN/0zqATKv44ciMdiWvOV0TYkqqBZfkjN3daRWASRO J4yj/7ZyD/5Yce2GF8kzcH3rleiobfxHU9JT2LjC5/meMMDjUK5kCYMmk4uhj7/8nXkNxY V5TyCgxfscWj5Qr7HgnunuKLsHHHTi3WxlkTyC6Q3Bzai8BT51dtA/lwJ2J/dAWyDHUcKR zd5KA5dgV6LTCi8Z9MzcLbtNunPwfGcJvHkMwlg21MgwnEBi9xSlgrCAzS3h6Ra6E/VIqN 7RIMvEMnU1rdO3cBb2ax9v9ZehzPiyFJ+Q+q4u/71MuKIFNdkVxKVMY29uVxIg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789772617; b=S09mkMRDSEYBXjoGfqh9oiep9UOAWuVDidKwiM1vbAaUWuSgy6xYMw49LmDzCHxgXDzjiO mRbEegFUTNdBBYw2MuS7LfseF+XcCGAt1Rm7ro/RGiB+aYMrn4rPgXr5ggamyFHnm1M0kH gizRJU3UqJGmjvrQ5yNuBhSf6RvDRFXBIuXxC/hKDExHwP/psezVl6/zNkumVQJiR5LXCE Avs17qGlu/ELACozr/B33HsJYA5KDRF6HHRuGu7bRTXx79bRg03ygOeDxyf/4KeP7FejVN 0pW2BjS6ukVIBIGfmaryqndUmuALQ1dvJtHJf4Fjpsu8qNYZJM4BCBH2wDCtxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789772617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kb5+YryhvlEcRMCIcUBmkqdlDRd/GLe0prWoerCunhg=; b=qCNvRQStYAE6EaaECiffoGNxxyKYaC5m/VvU69nDbxSW/bvqFn5jb0KI4S0WOBpCCKpF4J 44Dk2ZoU7RFg6N30kp67LuWjoome/dOmmUs5dH67BpVnVNBlxVhAGUlU32koFnkzQCcHPG Xo7oeln32nL4VVljIxeHUk+qZ88S94/DFvt5HNVa7ZkSPQjYnLcn4h95gHMui1VcZZbXOx ljotxNk7/WLvaHugnyNpAJUqsZrgAiku9JKRZCFtFojE5FT2xthnNWIxVULQoQ1F4EE/h5 9Bchoigor85veb1UJjq8M9HDRMJ8yiZWIEbAtusZP2f3wG2nfIoAtJRFLV9McQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmp89428hzgrt for ; Fri, 18 Sep 2026 23:03:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25f45 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 23:03:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: ce68b58217ed - main - qlnx: Derive the hardware RSS key from the common key List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce68b58217ed8a9bf45b1622d3d32ec26e9025d0 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 23:03:37 +0000 Message-Id: <6aadc349.25f45.158f2a12@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=ce68b58217ed8a9bf45b1622d3d32ec26e9025d0 commit ce68b58217ed8a9bf45b1622d3d32ec26e9025d0 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:20 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 23:02:57 +0000 qlnx: Derive the hardware RSS key from the common key Replace the embedded default key with rss_getkey(). Decode each group of four key bytes as a big-endian word; the shared code then serializes those host-order words as little-endian firmware fields. This preserves the existing hardware representation for the common default and allows a configured common key to take effect. Keep the existing multi-queue gate, RSS hash selections, and indirection policy unchanged. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59800 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 215837968505..853bd4cb7108 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -32,6 +32,7 @@ #include #include "qlnx_os.h" +#include #include "bcm_osal.h" #include "reg_addr.h" #include "ecore_gtt_reg_addr.h" @@ -6481,21 +6482,10 @@ qlnx_update_rx_prod(struct ecore_hwfn *p_hwfn, struct qlnx_rx_queue *rxq) return; } -static uint32_t qlnx_hash_key[] = { - ((0x6d << 24)|(0x5a << 16)|(0x56 << 8)|0xda), - ((0x25 << 24)|(0x5b << 16)|(0x0e << 8)|0xc2), - ((0x41 << 24)|(0x67 << 16)|(0x25 << 8)|0x3d), - ((0x43 << 24)|(0xa3 << 16)|(0x8f << 8)|0xb0), - ((0xd0 << 24)|(0xca << 16)|(0x2b << 8)|0xcb), - ((0xae << 24)|(0x7b << 16)|(0x30 << 8)|0xb4), - ((0x77 << 24)|(0xcb << 16)|(0x2d << 8)|0xa3), - ((0x80 << 24)|(0x30 << 16)|(0xf2 << 8)|0x0c), - ((0x6a << 24)|(0x42 << 16)|(0xb7 << 8)|0x3b), - ((0xbe << 24)|(0xac << 16)|(0x01 << 8)|0xfa)}; - static int qlnx_start_queues(qlnx_host_t *ha) { + uint8_t rss_key[RSS_KEYSIZE]; int rc, tc, i, vport_id = 0, drop_ttl0_flg = 1, vlan_removal_en = 1, tx_switching = 0, hw_lro_enable = 0; @@ -6637,8 +6627,13 @@ qlnx_start_queues(qlnx_host_t *ha) rss_params->rss_ind_table[i] = fp->rxq->handle; } + _Static_assert(sizeof(rss_params->rss_key) == RSS_KEYSIZE, + "RSS key size mismatch"); + rss_getkey(rss_key); + /* The shared code converts these host-order words to LE. */ for (i = 0; i < ECORE_RSS_KEY_SIZE; i++) - rss_params->rss_key[i] = (__le32)qlnx_hash_key[i]; + rss_params->rss_key[i] = + be32dec(rss_key + i * sizeof(uint32_t)); } else { memset(rss_params, 0, sizeof(*rss_params));