From nobody Fri Sep 18 22:54:39 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmnxq6cMgz6t5nh for ; Fri, 18 Sep 2026 22:54:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmnxq5lnRz58lK for ; Fri, 18 Sep 2026 22:54:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789772079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LeyGJ137scJtaY/H3OtKVtLCyfEJyFRrDczafeR43ik=; b=cXGaxZZFnoOUaQMwORT3/7fJyXbOHRtesxrmtzhp3sTUPPo3I/WIQgcjUi4DX8lJLp4kqR HqoGN1XZxpA1Vjct0LsFSFQVzLzl5+TsTjJE4E/CcUn75EagO0PV+dp26Cf5s8ptHvv9Up qpeI9udUyVjmKRm+Mkebmr2J1XmJrJxHlFiv2r5VR4fPOXrqodpANzBRTgcL5duUzXf4Gr 0WIHXao/xJY2+JSHmpiGfdBxwJc04+8+dccveBj+Hy4xuGp+D34s9gLi6Vx3eQhDN1wg5I NsJvtVTLs5p6NqhvMKu25Rjb6XYAmQpNOuzj1xYccCqEF+jLmjS9wYAK5gqB1g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789772079; b=gorogYS4aLwnY3cRpOSpW/HaW9QwxQ8Fmbwehpnc5Dh3/Op8tU+33IpwPWRTvH9Glt/+Ws Cm8xp9CwClqsY6P3g8nlJed27JQe0KoEs07tY3ST0jxsETHUckuxmEGZw7q262blCOqHMZ e82IlZDP+JdaT6A/5m+mBd0dxwyjRrWXJWMRdjjFb6Bdl4PkBgqjEcXqpGmWOUv0EozDis qAcMM7UfjGArf8brk6zoghyxgvDttyU48IWzuM5vSS2DGG4rsWlvkZxTh0N/MFhTv//YVp IRV7b2yQegSYauCZIjS8KP4cjMVdUVG67iSDMsc89FhoAY4LkmpX4ECgNfqCHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789772079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LeyGJ137scJtaY/H3OtKVtLCyfEJyFRrDczafeR43ik=; b=p4jK3uxcEe2RPSyNueZov8Kulk8UcpmgMGW8KUH+Gufpn3QW5du9LwmEeX5zsd42SlXQXP f+IkxoasEe3yaqS8jIWuk3FVfNLdKF1ATpyAWzFhrj45WfxdXcpq0Jm8rZfUGogDNAEBLd Z/28uOxgw6D2ZfVipurVoxA5BDFDA7D7ue4Ao/ryXvAZoFGqmy+n1oYi7/LI8gw+US6B3H DTJ7iJFkAXtsOk3NPjtPkQs5/BD4EgSzFLeZ3CvDMA9ZkVklgSzmLASl6CnP7/95WjhBP0 mdLcummQ2XXxoTsC5S243CHDhDnmnTZTXprAHPVIQ7RrVALWJKz5UZC29arS6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmnxq4frnzfvR for ; Fri, 18 Sep 2026 22:54:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2410a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 22:54:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: e94de94f8d14 - main - axgbe: Use the common RSS key without options RSS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e94de94f8d14ede98d38c9fc506ddf5c77ee9788 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 22:54:39 +0000 Message-Id: <6aadc12f.2410a.e837950@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=e94de94f8d14ede98d38c9fc506ddf5c77ee9788 commit e94de94f8d14ede98d38c9fc506ddf5c77ee9788 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:17 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 22:53:44 +0000 axgbe: Use the common RSS key without options RSS Fetch the common key in the PCI iflib frontend regardless of options RSS and make the key API declaration available in both configurations. Retain the existing hash-field selection and queue-placement branches. The independent ARM frontend is unchanged. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59794 --- sys/dev/axgbe/if_axgbe_pci.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sys/dev/axgbe/if_axgbe_pci.c b/sys/dev/axgbe/if_axgbe_pci.c index 7cf74b49e339..47a2db91821c 100644 --- a/sys/dev/axgbe/if_axgbe_pci.c +++ b/sys/dev/axgbe/if_axgbe_pci.c @@ -59,8 +59,8 @@ #include "opt_inet6.h" #include "opt_rss.h" -#ifdef RSS #include +#ifdef RSS #include #endif @@ -723,13 +723,17 @@ axgbe_initialize_rss_mapping(struct xgbe_prv_data *pdata) { int i; - /* Get RSS key */ #ifdef RSS int qid; uint32_t rss_hash_config = 0; +#endif + /* Get RSS key independently of software RSS queue placement. */ + _Static_assert(sizeof(pdata->rss_key) == RSS_KEYSIZE, + "RSS key size mismatch"); rss_getkey((uint8_t *)&pdata->rss_key); +#ifdef RSS rss_hash_config = rss_gethashconfig(); if (rss_hash_config & RSS_HASHTYPE_RSS_IPV4) @@ -739,8 +743,6 @@ axgbe_initialize_rss_mapping(struct xgbe_prv_data *pdata) if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV4) XGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, UDP4TE, 1); #else - arc4rand(&pdata->rss_key, ARRAY_SIZE(pdata->rss_key), 0); - XGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, IP2TE, 1); XGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, TCP4TE, 1); XGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, UDP4TE, 1);