From nobody Fri Sep 18 22:53:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmnw222L1z6t5bc for ; Fri, 18 Sep 2026 22:53:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmnw212Sxz58f3 for ; Fri, 18 Sep 2026 22:53:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8BqzIx9UAUUTnKrBxJ49v14BG+2hNR7RFUY5oLK6Bgo=; b=jwf4hOggEGORJ15U6vmRFJEtGZkGkOCppAmMqrWbrOId7EZlxqNIaLnRFe1MYUVwhkeiiS QP01LGO48HXK4eCmwZYanF/HxfGCWhaGodJUJ4tQBohYLUcn861ZL7P9/A3WdJ5IdcavOR z84OC1qxW0x007DzvU1vhxmT4MLBumTRHGiP2VlQmgTa+cprPW6w7ZADaAE8x90Bg2dCgG 6Gvh0YxJvZIqZwRdEqS/myvr5db7Zyhki/LZnZgG85lfh+KmTrSI3GQsnSijsU3eQFQXQY LdbthXof3ZipS6lIhr8oReZgwBGi0/svv32DYEmEoFuG4/hT2bFjbryssPUyeA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789771986; b=sEgtt0c82OCOY5uXw/h1M8V1oI5vLHFXHadlOT7unBv9NIT5QOi0ftUWQKUGZcGoFp/Bsu KK5ik8VONC3X1dTOrMD9u+NxcGAyRcbnG+qjD4nmZkUZC9OSRbLkpo4Coksv4p57DW1RQO V2ZrM+1CqBLG2GI6QrLhmQeTBGoetyuNQj8CoU7OWPJAbe+rigDFb4ONMrHrGcv3GjagQ3 a+Mau3XHzifzEBLu4fEOtaIeTUWlfpuaQJIUB2p5i1Jh94sWAbV8xjaIsb+3EkOI/f4L4K z/osY3gmAYaz3ldmSUupRY8VSeyI/D44AM0DSzZmlRStKlcLLzDIxsDT/u1wtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8BqzIx9UAUUTnKrBxJ49v14BG+2hNR7RFUY5oLK6Bgo=; b=qEhHouj/5xQiNsMqxjn4KcF7w3XWWBZudmhHNB4Yxeqg3zW8+H5gRyzTi+Q6SLG5TYzt4w XJHCBISMEaXawIESLqwiCZiPn4WQciDHAGWQudJNgTyTERZqVcOeSvREmo/JbD+icqt/aw LOKtvv+V2w6dFAyikD2vmKvLo4nxJnOWmtMGnGtKTmYUcWRDsoBidHLGJnYLdlzKyngi2q NdTdFrxOgbOUAjtwVxb4yZb8FHaSpomFFLKecPSmna/PFaC4WWzy8N3+16tmBPsaN/+UPN rRFaK/N+aI5WqQ2Hvqhl6S+9IhA5krhmD5xv0GDEEYtuqj/g2EQy64vChWifeQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmnw206BTzfvP for ; Fri, 18 Sep 2026 22:53:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24013 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 22:53:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 772994d77482 - main - aq: Use the common RSS key without options RSS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 772994d7748287be70fe850ec9e1117d4e7b1747 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 22:53:06 +0000 Message-Id: <6aadc0d2.24013.2a93d08@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=772994d7748287be70fe850ec9e1117d4e7b1747 commit 772994d7748287be70fe850ec9e1117d4e7b1747 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:17 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 22:52:24 +0000 aq: Use the common RSS key without options RSS Fetch the common RSS key independently of options RSS instead of generating a private key in non-RSS kernels. Keep the existing software-RSS or round-robin indirection policy and hardware key serialization unchanged. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59793 --- sys/dev/aq/aq_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/aq/aq_main.c b/sys/dev/aq/aq_main.c index 1ffa813d8b30..d5ba995eb493 100644 --- a/sys/dev/aq/aq_main.c +++ b/sys/dev/aq/aq_main.c @@ -504,12 +504,13 @@ aq_if_attach_post(if_ctx_t ctx) aq_add_stats_sysctls(softc); /* RSS */ uint32_t rss_qs = MIN(softc->rx_rings_count, HW_ATL_RSS_INDIRECTION_QUEUES_MAX); -#ifdef RSS + _Static_assert(sizeof(softc->rss_key) == RSS_KEYSIZE, + "RSS key size mismatch"); rss_getkey(softc->rss_key); +#ifdef RSS for (int i = nitems(softc->rss_table); i--;) softc->rss_table[i] = rss_get_indirection_to_bucket(i) % rss_qs; #else - arc4rand(softc->rss_key, HW_ATL_RSS_HASHKEY_SIZE, 0); for (int i = nitems(softc->rss_table); i--;) softc->rss_table[i] = i % rss_qs; #endif