From nobody Fri Sep 18 22:48:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmnq84TyKz6t5b7 for ; Fri, 18 Sep 2026 22:48:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmnq83zYGz56HX for ; Fri, 18 Sep 2026 22:48:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fFyHzsgxcLOmGuevQoKa3Y41sQa+i6sDqZaE+3qEkno=; b=glLamoUPe5FJKNHCVFRFVy+fjAjPxzTijnm+8ge4UEZeasgeTXJfrzPSfU/iLBDgORvn6c e3PJdftVYoKOya5tsYR/7q9JOZcRQYbXa84p6aaXP1vKeYkKVbVG7zrYkOtnwLa72gQE1X F0dKandtzVqdDSWr4BYgavaUaf7lHIYHFLcrrnNWFrALpSy2VRZYWEmshXzfTGTb6mVXuO H/Q9D0I8a4Ped7mLzOE0BtP/qcL1RNjG/5Jh9RUuV5k+mXnc5lcwvSmFKOlcPn1QHW26yl lqfFGNVsm1SCMgv2/uHGF7ZAsBQp/8K+tjHr+tXA2RKDNwCnLaaLNCnig3JrOA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789771732; b=UY00ZTfSw+1cxYyC5rybo7u2a+IfWfcS5PXHPEKtWIQCd5+eDyJefdBun9WdxLySOaGyWN Y1zDu4MsqtnoiZ0rrtDrjTzSwmcRBnMNV4oCuuj7+DHK7OLa3JaHluTi88vGvthykdIsCI UujHbKsjEL5IqCOiU+Ce0z3TVCZo+HlZEk7grKmeoyaE3hYvr7sqJ69/ANZCF79BW3hmnn A8dVmn8mqX1Z1CVKXZGMMtruV0mpCYQ/yArfswQVsr3vynapHUePNMjbf7KADhyz+DSl2B lvN1MJ58JTBDpHYt4jZGSVkLDsI4USlH3JD/QHs613ilOX8MbjTSzXtvHvKDmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fFyHzsgxcLOmGuevQoKa3Y41sQa+i6sDqZaE+3qEkno=; b=VSmupEC51PxLXlZ3oN/GXIuQOS/QzvuPAVXxBiZgETfbJzybSBD5fMtGs0St8jw4uEk7TF IJRMuz/o+rPDQyUU+Qf6SWO1dg0SbPSP820zTWM+6FnlifefoXVDpvhcY+ZQfxmrNtAfkY PlP9QSvbZVjeNg4T1379Q3gyjrKu+Bs9Q5CCOqpQXMUJBEBRlo7pILiTkyIs89jrUOexTZ FZwn9p1OsrnPAYCXtbU291KxxnIMId2Yr4PQohlergYicbqPFYEQ0yUeovfoD/+cS4CQYb wOU3eejbpxJWuyjbylQMLss3OnqRz1CJdYQILaCHg/EnTxRv2sjKqyxjmpmktg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmnq82SMMzg2p for ; Fri, 18 Sep 2026 22:48:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22160 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 22:48:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 0f7bdeadaf9d - main - ixl: Initialize the extended RSS key List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0f7bdeadaf9d8101993dd39abee3a6a2ef4e2950 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 22:48:52 +0000 Message-Id: <6aadbfd4.22160.3c92c6dd@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=0f7bdeadaf9d8101993dd39abee3a6a2ef4e2950 commit 0f7bdeadaf9d8101993dd39abee3a6a2ef4e2950 Author: Kevin Bowling AuthorDate: 2026-09-18 08:29:16 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 22:47:44 +0000 ixl: Initialize the extended RSS key Zero the complete 52-byte RSS key buffer before fetching the common 40-byte key. Both the X722 AdminQ path and the register path consume all 52 bytes; the trailing extended-key bytes must not come from uninitialized stack storage. This matches the zero padding already used by iavf and ice. Remove the unused driver-default key helper and its declaration. Keep the standard key, hash selections, and indirection policy unchanged. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59791 --- sys/dev/ixl/ixl.h | 1 - sys/dev/ixl/ixl_pf_main.c | 2 +- sys/dev/ixl/ixl_txrx.c | 17 ----------------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/sys/dev/ixl/ixl.h b/sys/dev/ixl/ixl.h index e265c8fbe3eb..2d21bf5c12de 100644 --- a/sys/dev/ixl/ixl.h +++ b/sys/dev/ixl/ixl.h @@ -516,7 +516,6 @@ extern const uint8_t ixl_bcast_addr[ETHER_ADDR_LEN]; /* Common function prototypes between PF/VF driver */ void ixl_debug_core(device_t dev, u32 enabled_mask, u32 mask, char *fmt, ...); void ixl_init_tx_ring(struct ixl_vsi *vsi, struct ixl_tx_queue *que); -void ixl_get_default_rss_key(u32 *); const char * i40e_vc_stat_str(struct i40e_hw *hw, enum virtchnl_status_code stat_err); void ixl_init_tx_rsqs(struct ixl_vsi *vsi); diff --git a/sys/dev/ixl/ixl_pf_main.c b/sys/dev/ixl/ixl_pf_main.c index 4c7907a5a9be..838e2178a110 100644 --- a/sys/dev/ixl/ixl_pf_main.c +++ b/sys/dev/ixl/ixl_pf_main.c @@ -1099,7 +1099,7 @@ ixl_set_rss_key(struct ixl_pf *pf) struct i40e_hw *hw = &pf->hw; struct ixl_vsi *vsi = &pf->vsi; device_t dev = pf->dev; - u32 rss_seed[IXL_RSS_KEY_SIZE_REG]; + u32 rss_seed[IXL_RSS_KEY_SIZE_REG] = {0}; enum i40e_status_code status; /* Fetch the configured RSS key */ diff --git a/sys/dev/ixl/ixl_txrx.c b/sys/dev/ixl/ixl_txrx.c index d047733ecbbb..047bb468254b 100644 --- a/sys/dev/ixl/ixl_txrx.c +++ b/sys/dev/ixl/ixl_txrx.c @@ -86,23 +86,6 @@ struct if_txrx ixl_txrx_dwb = { NULL }; -/* - * @key key is saved into this parameter - */ -void -ixl_get_default_rss_key(u32 *key) -{ - MPASS(key != NULL); - - u32 rss_seed[IXL_RSS_KEY_SIZE_REG] = {0x41b01687, - 0x183cfd8c, 0xce880440, 0x580cbc3c, - 0x35897377, 0x328b25e1, 0x4fa98922, - 0xb7d90c14, 0xd5bad70d, 0xcd15a2c1, - 0x0, 0x0, 0x0}; - - bcopy(rss_seed, key, IXL_RSS_KEY_SIZE); -} - /** * i40e_vc_stat_str - convert virtchnl status err code to a string * @hw: pointer to the HW structure