From nobody Fri Sep 18 22:38:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmnZq54gxz6t50f for ; Fri, 18 Sep 2026 22:38:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmnZq1cnNz54Nl for ; Fri, 18 Sep 2026 22:38:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OtQ/pJTxLwX8nFMEh3Nx8VI6wBAQg5e8T9+77vNYlSo=; b=xrq4Zv3G7kl7lgJverp3bNrxS/R02QNmXKhm3XgQiJ0eRHQkK7quBu++GsGeQlaQIYfb5m 6hA6psOUtpFrD50QvMLE6F2zhMwxNYxBC+tMoUv0LuoV33BHJjlTsJjAfKrM0qrF1QiUkU 7mGzo8ydri/zUh/BEgJX4dYQ+qk1sdVyKSU++aHq5GLGNPFUXlWQOTPLIu0DCKoxMJnmdm uXYdDVejS+jXDNiCbN4A5vrq853Opfbgnfz8TE9QO2ITCrGyLTqBut+jZR9e/k4zeJonGj gYwxg78R4LLwCIxudNrKkYHXFxYZjLFljKHbxP0yniyMGY/pxUDiNx5Y2Gmqww== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789771091; b=iTyEr8FBuFLtzfnIEW7yqgQJ7eI+QaflxqPcTqkd0i5TFh+wf1WGxLBj63bO1sSNac27Nt rjVoxoEWBDCaNMYxe2cVkZ0NIElJjVC9HGYSxpWkSE5aHfQnJWwGNMDsOO/Wk9j8Z9MkbA z5fczg7s61mtq8XBermD0Qoof9NtKnqKJ6S55p7KperkkDoeZg4ZINL8aSS9naftEfFGKn A0dW5ERg3UYAduVH4IEO9/t1b1vl5fkvhHOOY+g7Oq5HsKjAJ6Bii6JKst7qWYN9SStr17 x0nsusdHZ0MLIOTW2FZt4VVD0wGiBSrcmwuK6mFASLuIDSsaN9M8+39tjKGfSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OtQ/pJTxLwX8nFMEh3Nx8VI6wBAQg5e8T9+77vNYlSo=; b=okRV7ZLtKeUrM6Kq9e7pkVjZmUWXJFp5+/OeFOP1LPEXN6QcFGtJeTCLCRKWseSSX0jeE/ 2KF4sR7j0eY/8DzwEddz8FCqaynRnwJB/x706EHedWFeD3vIpW/cG7fF3N2Jv/0tp4f7dE zo3R26bsw8gaUJ5l2ZhoYOCBKiYIXjiSOdynX8VE5oQrEkBXi9I1i2HPy2pUIcv4RYzSjc ls5k0TB5XGihAq02Qf7wD55XLPEO1RDTIy8uZW0FdtsipTp9goUq/DOC0To3PHcg6Z0T0Z V6WO/tEWUzuu6nHXW8gVykn8Wj3GVOPvzy9V0bq0wt8sZJp/QoQ22n61V3t1Aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmnZp2Dqwzft5 for ; Fri, 18 Sep 2026 22:38:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 215f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 22:38:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 709d7cf3039f - main - ixgbe: Use the common RSS key without options RSS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 709d7cf3039f648e23260a35c1094b15b4d4593b Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 22:38:05 +0000 Message-Id: <6aadbd4d.215f4.135d8e1e@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=709d7cf3039f648e23260a35c1094b15b4d4593b commit 709d7cf3039f648e23260a35c1094b15b4d4593b Author: Kevin Bowling AuthorDate: 2026-09-18 07:43:37 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 22:35:53 +0000 ixgbe: Use the common RSS key without options RSS Use rss_getkey() for PF and VF RSS programming even when options RSS is not configured. The common key is available independently of RSS queue placement and is also used by software hashing. Generating a private key on each initialization defeats that agreement and changes receive hashes across resets. Leave hash-field selection and indirection-table placement unchanged. 82599 and X540 VFs retain their PF-owned RSS configuration. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59789 --- sys/dev/ixgbe/if_ix.c | 8 +------- sys/dev/ixgbe/if_ixv.c | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 9aca44c6d8fa..74ccfb7f629f 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -687,13 +687,7 @@ ixgbe_initialize_rss_mapping(struct ixgbe_softc *sc) u32 pfmrqc; #endif - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Set multiplier for RETA setup and table size based on MAC */ index_mult = 0x1; diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index b2c192caaae1..378a0c18cbf6 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -1788,13 +1788,7 @@ ixv_initialize_rss_mapping(struct ixgbe_softc *sc) int i, j; u32 rss_hash_config; - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Now fill out hash function seeds */ for (i = 0; i < 10; i++)