From nobody Fri Sep 18 21:55:30 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmmdh5gTyz6t2Kp for ; Fri, 18 Sep 2026 21:55:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmmdh21sYz4yZj for ; Fri, 18 Sep 2026 21:55:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789768536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=09FNkBYViITc9B6cOZSMgoQ7NPRG5h+jPE5mnzWeUO8=; b=ZrTU/LZALte7jFb2hj5BfG+KCOYAZz2OuJ1a5+sWIYQqYQNGUU5qkQIttWtrQ1uI0a13xw DGUdB5vMvI/2z5yJBix2uXi9PbQ8LPd9QUXGsdQq91q7F0Ohbx+/aDK7xrs7Tkh38GnMZs kArk7EzvmkzoQZIwimf5TX5alk9gP1WEhA7Irgb5ayhsXEUj5F5CuZsaffzdLrLjZY9mqo nkjrQ50P1xohwl4zE/lft5QQew2sJhVtPEq2Pzl2vy4bf5fFGKp1Jh/hOaOanQY7cuPaBm T/GpLIRGo8uoEfZcK1nc362rAv8fDlP05gVUVycxJ9xtJqBy6UWxDnWtyBk0fg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789768536; b=oaNzoihfq0oHBuKM2gcz78tEGIfXtcslDlZcBY7q4RwNvbfAehIaY98bXmofxXZsYbUyhM kEle3v/slCYhZ1WrXKpkqEeG9VWbEu+d5Z3E3uozIARly8zIai+qoAVL23Nz5einQ/PkqF EK6/bGdGr1Yr98axlpB11eMw+GN7ppV4QWOovJyCjdbgyW+YdsZQ+qRh2NcTM1t3ltKK6u xhphu2j36cDxH6xfdrh/kr7ujwHj37ocEJxwOxdfWtB+TNWXKnFmO2cwMbZZmtfzM8dxaU crT0p85eXZOCvJe37ZqljGABaphuZWoU+Qg5OCQWx3aSRs8gaPP40frzl6H8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789768536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=09FNkBYViITc9B6cOZSMgoQ7NPRG5h+jPE5mnzWeUO8=; b=gopzbJ0VdBSlKqpSpm9U4OS811WU75uYJFniCHVV6rFuIbuwlM+0tv6UWzthbA0P+SpzqO VzsF4yhKXXMb7ajQ0wyFZvr8aFZx03APw+8Nmlp0Y1MtacbEFytWk53zGmCM+JB3pLpKC+ f1r4JA+u1b/iDmXTOW5BSymjcauz1SBkJTzDmuYhatVSxEFIg6Ctb1URlV1Dry+CQwRxm4 jv3GVhZlwkZJf3OvafJjSKGbl4wbgMY0JQFSBrxck3CaZrtLuaeIYMCx4rlnmyg66RjJ6j 0XVysEcI0Mv3qSdGp2+HyUHDk7x474Oo2oaB945/TP9NMzhxybKcGRNsdKkobg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmmdg62c1zf34 for ; Fri, 18 Sep 2026 21:55:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d0d4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 21:55:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 8a37f8c325b6 - main - buf_ring: use counter(9) for drops List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8a37f8c325b65abd889b31b394bebaca7ad42026 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 21:55:30 +0000 Message-Id: <6aadb352.1d0d4.38d3f06d@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=8a37f8c325b65abd889b31b394bebaca7ad42026 commit 8a37f8c325b65abd889b31b394bebaca7ad42026 Author: Gleb Smirnoff AuthorDate: 2026-09-18 21:53:39 +0000 Commit: Gleb Smirnoff CommitDate: 2026-09-18 21:53:39 +0000 buf_ring: use counter(9) for drops If a buffer ring experiences drops, then system is definitely starving in CPU resources. Having an extra cache miss on a racy shared variable increment doesn't help. Reviewed by: gallatin Differential Revision: https://reviews.freebsd.org/D59495 --- share/man/man9/buf_ring.9 | 11 ++++++++++- sys/dev/cxgb/cxgb_main.c | 2 +- sys/dev/cxgb/cxgb_sge.c | 2 +- sys/dev/mxge/if_mxge.c | 2 +- sys/kern/subr_bufring.c | 7 +++++++ sys/sys/buf_ring.h | 21 ++++++++++++++++++--- 6 files changed, 38 insertions(+), 7 deletions(-) diff --git a/share/man/man9/buf_ring.9 b/share/man/man9/buf_ring.9 index 29a5e2580800..cffbbccc9364 100644 --- a/share/man/man9/buf_ring.9 +++ b/share/man/man9/buf_ring.9 @@ -36,7 +36,8 @@ .Nm buf_ring_count , .Nm buf_ring_empty , .Nm buf_ring_full , -.Nm buf_ring_peek +.Nm buf_ring_peek , +.Nm buf_ring_drops .Nd multi-producer, {single, multi}-consumer lock-less ring buffer .Sh SYNOPSIS .In sys/param.h @@ -59,6 +60,8 @@ .Fn buf_ring_full "struct buf_ring *br" .Ft void * .Fn buf_ring_peek "struct buf_ring *br" +.Ft uint64_t +.Fn buf_ring_drops "struct buf_ring *br" .Sh DESCRIPTION The .Nm @@ -125,6 +128,12 @@ function returns a pointer to the last element in the buf_ring if the buf_ring is not empty, .Dv NULL otherwise. +.Pp +The +.Fn buf_ring_drops +functions returns how many times the +.Fn buf_ring_enqueue +was not able to queue an element due to no available slots. .Sh RETURN VALUES The .Fn buf_ring_enqueue diff --git a/sys/dev/cxgb/cxgb_main.c b/sys/dev/cxgb/cxgb_main.c index 81fd3cb45841..2137aea55795 100644 --- a/sys/dev/cxgb/cxgb_main.c +++ b/sys/dev/cxgb/cxgb_main.c @@ -2201,7 +2201,7 @@ cxgb_get_counter(if_t ifp, ift_counter c) drops = 0; if (sc->flags & FULL_INIT_DONE) { for (i = pi->first_qset; i < pi->first_qset + pi->nqsets; i++) - drops += sc->sge.qs[i].txq[TXQ_ETH].txq_mr->br_drops; + drops += buf_ring_drops(sc->sge.qs[i].txq[TXQ_ETH].txq_mr); } return (drops); diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index 9614b69cfc6a..05fbecde95d2 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -3512,7 +3512,7 @@ t3_add_configured_sysctls(adapter_t *sc) &qs->rspq, 0, t3_dump_rspq, "A", "dump of the response queue"); - SYSCTL_ADD_UQUAD(ctx, txqpoidlist, OID_AUTO, "dropped", + SYSCTL_ADD_COUNTER_U64(ctx, txqpoidlist, OID_AUTO, "dropped", CTLFLAG_RD, &qs->txq[TXQ_ETH].txq_mr->br_drops, "#tunneled packets dropped"); SYSCTL_ADD_UINT(ctx, txqpoidlist, OID_AUTO, "sendqlen", diff --git a/sys/dev/mxge/if_mxge.c b/sys/dev/mxge/if_mxge.c index dd52d104ae5f..75bad049bbe9 100644 --- a/sys/dev/mxge/if_mxge.c +++ b/sys/dev/mxge/if_mxge.c @@ -3872,7 +3872,7 @@ mxge_get_counter(if_t ifp, ift_counter cnt) return (rv); case IFCOUNTER_OQDROPS: for (int s = 0; s < sc->num_slices; s++) - rv += sc->ss[s].tx.br->br_drops; + rv += buf_ring_drops(sc->ss[s].tx.br); return (rv); default: return (if_get_counter_default(ifp, cnt)); diff --git a/sys/kern/subr_bufring.c b/sys/kern/subr_bufring.c index 25691be69be2..ce077739efaa 100644 --- a/sys/kern/subr_bufring.c +++ b/sys/kern/subr_bufring.c @@ -30,6 +30,7 @@ #include #include #include +#include #include struct buf_ring * @@ -44,6 +45,11 @@ _buf_ring_alloc(int count, struct malloc_type *type, int flags, type, flags | M_ZERO); if (br == NULL) return (NULL); + br->br_drops = counter_u64_alloc(flags); + if (br->br_drops == NULL) { + free(br, type); + return (NULL); + } br->br_lock = lo; br->br_prod_size = br->br_cons_size = count; br->br_prod_mask = br->br_cons_mask = count-1; @@ -56,5 +62,6 @@ _buf_ring_alloc(int count, struct malloc_type *type, int flags, void buf_ring_free(struct buf_ring *br, struct malloc_type *type) { + counter_u64_free(br->br_drops); free(br, type); } diff --git a/sys/sys/buf_ring.h b/sys/sys/buf_ring.h index db934e083e1a..aa0dd2a077ce 100644 --- a/sys/sys/buf_ring.h +++ b/sys/sys/buf_ring.h @@ -38,10 +38,13 @@ #if defined(_KERNEL) #include +#include #define BR_LOCK_ASSERT(br) \ LOCK_CLASS((br)->br_lock)->lc_assert((br)->br_lock, LA_XLOCKED) #else #define BR_LOCK_ASSERT(br) do {} while (0) +typedef uint64_t counter_u64_t; +#define counter_u64_add(c,v) do { (c) += (v); } while (0) #endif /* @@ -58,7 +61,7 @@ struct buf_ring { uint32_t br_prod_tail; int br_prod_size; int br_prod_mask; - uint64_t br_drops; + counter_u64_t br_drops; uint32_t br_cons_head __aligned(CACHE_LINE_SIZE); uint32_t br_cons_tail; int br_cons_size; @@ -110,8 +113,8 @@ buf_ring_enqueue(struct buf_ring *br, void *buf) if ((int32_t)(cons_tail + br->br_prod_size - prod_next) < 1) { if (prod_head == atomic_load_32(&br->br_prod_head) && cons_tail == atomic_load_32(&br->br_cons_tail)) { - br->br_drops++; critical_exit(); + counter_u64_add(br->br_drops, 1); return (ENOBUFS); } continue; @@ -358,8 +361,14 @@ struct buf_ring *_buf_ring_alloc(int count, struct malloc_type *type, struct rwlock *: _buf_ring_alloc((c), (mt), (f), lk2lo(lk)), \ struct rmlock *: _buf_ring_alloc((c), (mt), (f), lk2lo(lk))) void buf_ring_free(struct buf_ring *br, struct malloc_type *type); -#else +static inline uint64_t +buf_ring_drops(struct buf_ring *br) +{ + return (counter_u64_fetch(br->br_drops)); +} + +#else /* !_KERNEL */ #include static inline struct buf_ring * @@ -385,5 +394,11 @@ buf_ring_free(struct buf_ring *br) free(br); } +static inline uint64_t +buf_ring_drops(struct buf_ring *br) +{ + return (br->br_drops); +} + #endif /* !_KERNEL */ #endif /* _SYS_BUF_RING_H_ */