From nobody Fri Sep 18 14:42:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmb246Mj3z6sYFv; Fri, 18 Sep 2026 14:42:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmb245n4Kz4tyN; Fri, 18 Sep 2026 14:42:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789742556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgUf+pnL36wcQB3IdHWhwLfA8h0HIM+a4KLgxRd9rIk=; b=FjcvnNbfOiebhznmDCBg7f1JpV9HT5P44oz3RFPFmbrZZyyYUYWMGMcW8V0OSMTS7Ja6ba cIKdlrXP/34mGROLjrE0uQA+RNXetLZl5ewCktF9ih489d4DrLMa+vwWTF6LRXkiZd5FGt RXbMjf5qwg+CTK+rsQJuUcirrgj2eT7ZxplzonG1vFmzzA46iZN8Opzyjxfa187yXZLewa Yxdf1yN0B8LBTEYLotgfzpX+/h6t4P6KMfe5OsmDVKc668/Q5giaHKBRrco4+GYWmHJvYp ncfwq4u2iWi09p/oS4zGPCT9GWaguAPkmJO5PvjRd/wfwMzRs9CWLN68X1St+Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789742556; b=CcUBj2aBsODW45sH8OT8ZK6tdEGO7qIVcjfovMx4hjtS+zIe6GxfRVM0l8KArbq+xHLZ2v LCqgsHhFoJQrPAIo7S+tk2N5CVt3QE6vak9jMRlTlfe+JqkyBQU3+nb/MESgR4+HgQC7Xf jcg15I7uSHxIa76VFOZGppuVeJr6uhOYqzFvSQd9QFiHJ1TkojmeoIvvKAJIc14PY8ZcWS SeoDATkGAGmHTOSRrrkA47JHoKS4Q9bFomtLgLnTYinQ76moGiUPoAp3qPuiXSXtT4//1v vaCfL2+Ux9BYm8Ys6ZPauC7OH1Fvj9sgQ2/Xtg4t0r88GCqY0ezwQG9NdUEQPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789742556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgUf+pnL36wcQB3IdHWhwLfA8h0HIM+a4KLgxRd9rIk=; b=URNZf2OXiSzw3VJi4/+x67ozF4tQwAKzw2S6wYdZlOh8jEWGNLNOi43DIHbhgYB72XkzaM 5UwQlrzTCOn3u3QeH7Ss14SswkGYjjn020xqaCUcq5tIYW9ZfK1oZDiT6m6awgMeOdha0e ug6helaPjfOQZQmiIuS76h7pmOc7KH43wGTZcOSZusTeme4XAqGNUEypIcDvqZ39Hwqgnn 144MZ/iUU2WF3cqn9KfTpWvPRAYSQKYEuJijTBs6k9P2/sFuszsKSR3z1UJIzsMsbRCuma jU2aa/q3J1YhwAkVmuxd5kDVh1mlRQ26DmfnQXD6V+pKhB4p/RG2U68sKwRKyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5cc:4402:82e0:b082:72b2:8f6d:8ebc] (unknown [IPv6:2601:5cc:4402:82e0:b082:72b2:8f6d:8ebc]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hmb243wZ6zk2V; Fri, 18 Sep 2026 14:42:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0a479927-623a-4889-9eb0-aee3d1cf0755@FreeBSD.org> Date: Fri, 18 Sep 2026 10:42:36 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a5a3daf88af5 - main - fixup! libmlx5: Extend mlx5dv_get_qp() to return UAR mapping info Content-Language: en-US To: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <6aaaa3d7.35fc8.1961289@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/16/26 23:07, Konstantin Belousov wrote: > On Wed, Sep 16, 2026 at 02:12:39PM +0000, Konstantin Belousov wrote: >> The branch main has been updated by kib: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=a5a3daf88af5e4d30952a7fc8b4d27d83458f484 >> >> commit a5a3daf88af5e4d30952a7fc8b4d27d83458f484 >> Author: Ariel Ehrenberg >> AuthorDate: 2026-07-28 12:02:36 +0000 >> Commit: Konstantin Belousov >> CommitDate: 2026-09-16 14:12:06 +0000 >> >> fixup! libmlx5: Extend mlx5dv_get_qp() to return UAR mapping info > To answer some questions I saw on private comm channel: > > The form of commits was intended, I initially have a plan to squash fixes > into the corresponding commits. But after some thought, I decided to > keep the original commits intact, and push fixes as separate changes. > This preserves the authorship and does not attribute changes not made > by the initial author, potentially putting him off the hook. > > Might be I should have edited the 'fixup!' rebase markers. Note that > using the 'Fixes:' tags is impossible because I cannot know the final > hashes in advance. > > This patch series as a whole was validated by Nvidia verification for > ConnectX RDMA. FWIW, when I recently pushed a set of changes to iw_cxgbe I used Co-authored-by: tags to acknowledge changes made by other authors while keeping the Author field as the "main" author, including when cherry-picking changes from the Linux driver rather than using separate fixup commits. I think the specific phrase fixup! is also best if reserved for commits you intend to squash (e.g those created with git commit --fixup for use with a later git rebase --autosquash). If you want to keep them as separate commits it would be best to reword the title to avoid confusion. -- John Baldwin