From nobody Fri Sep 18 14:14:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmZQC64MWz6sWnn for ; Fri, 18 Sep 2026 14:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmZQC3227z4jZV for ; Fri, 18 Sep 2026 14:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GVbbLFxAyBmI3T4w+uDSfpkD2PWtb/g3EkFicsg0wTI=; b=xQfk3yVqCX3pInsAmeQs6BgRTF79ZpKhPAZwXPLRNHr+a9i1PnATbagvONDTiuQ5rrPImW VmoKUgW0rawPt+WwvSLOASGSFA4fqVuwCdwfV5c4WGOwp9ljml1ycwTLp1OFYupszaf3LP r/tDBwYAyruFALiaY6cJ4OlaNMAYwyAIURCwCUHyao53sIkkpJaMFtHvX6dePIlOcwOaHk cpcwcZcArs13SeStPdt8lNMwuy5YlzCjfny/EKzyCBwGZKtGLOMqU9Q+2sntMuCoXY9wcG 7WUNoSSjhoHiymslWK+nv05f85w8bNLJaNaK6gzqCghS+I5IBSTODBOUCauLsg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789740899; b=GcTIQXHeDm7Lt2RWry0G+vRE6SC8wdw381E2miyu+49i23jGvnGJiU82a43Zruo3nsAwCR UIG7ftx1ktt7Jrpi11E60pyhZ7+QvmwROtzN0qTbRroyCHCZ/pTbqpEzG98ryJdxuWwtyo s0yBTa8jbSLmJrYGo4CWtO3Iudrvbj+GhAovm7xFMKHJPfaV5IY4DZZ5PQM21mcMNs8Ecu muCPqPaCYvy26fI9oq8CWDIDt9GjAx3DJN8TvDOZz8dSl7aqfCbshVs/2C+g1WA5juP3Xj nmknD2Kj0TCNRtmI48gMx3nKgPhu+Z4ee0lBqM2djEiiIdTiPxb+EspDzJdplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GVbbLFxAyBmI3T4w+uDSfpkD2PWtb/g3EkFicsg0wTI=; b=ZfT8kUGIFQgDhDIUdrtc/fCy/4cHvuTQ9U2RmuPUvviOrcBXKZl/O0gl55emQpT4CnY7G1 yJxCwxAcv25h4nSE1/KGSgczrGx7iLMfsoHbgdWTfuiwJik7zCpoOz7ipR7NsjsXlDRP93 jvHLOB7VgJDoT8o31LfHvn6UIphzLjQFhYVEowRKOtw2ywqywbxm22pA7yJznuf94/tqp6 Elr9PIOgIDghb3047lmWtb2FrB3m1EW7IzlFThAjXyDWrQhRFqzhwHv4jYW1lU3NwEsNqa +k64FlHzoJF4El7V8LwJQFhTwmf84zWPHxPsmzBMftzP1PZcQvK3qwqrHvJMOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmZQC0C5RzM6Q for ; Fri, 18 Sep 2026 14:14:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42ad5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 14:14:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Minsoo Choo Subject: git: 477d2ea79252 - main - sched_ule: fix invalid tdq_slice() and sched_slice_min List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 477d2ea79252054596c73fa5f485bd224c028fd9 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 14:14:59 +0000 Message-Id: <6aad4763.42ad5.1186c56b@gitrepo.freebsd.org> The branch main has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=477d2ea79252054596c73fa5f485bd224c028fd9 commit 477d2ea79252054596c73fa5f485bd224c028fd9 Author: Minsoo Choo AuthorDate: 2026-08-24 23:35:27 +0000 Commit: Minsoo Choo CommitDate: 2026-09-18 14:14:14 +0000 sched_ule: fix invalid tdq_slice() and sched_slice_min sched_slice_min should always to be greater than zero. When modifying sched_slice through sysctl, if the new value is less than SCHED_SLICE_MIN_DIVISOR, sched_slice_min is computed to zero. Add imax(1, ...) to prevent this. tdq_slice() should not return a value less than sched_slice_min since that will cause integer underflow of ts2->ts_slice in sched_ule_fork_thread. SCHED_SLICE_MIN_DIVISOR is currently set to 6 so when load is 5 and sched_slice is 4, the two if conditions in tdq_slice() will pass and the function will return zero. Thus use imax() so tdq_slice returns sched_slice_min at minimum. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59408 --- sys/kern/sched_ule.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index dc84b18e5ebf..9cd4d8e448f8 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -675,11 +675,9 @@ tdq_slice(struct tdq *tdq) * cannot be higher priority load in the system. */ load = tdq->tdq_sysload - 1; - if (load >= SCHED_SLICE_MIN_DIVISOR) - return (sched_slice_min); if (load <= 1) return (sched_slice); - return (sched_slice / load); + return (imax(sched_slice_min, sched_slice / load)); } /* @@ -3478,7 +3476,7 @@ sysctl_kern_quantum(SYSCTL_HANDLER_ARGS) if (new_val <= 0) return (EINVAL); sched_slice = imax(1, (new_val + period / 2) / period); - sched_slice_min = sched_slice / SCHED_SLICE_MIN_DIVISOR; + sched_slice_min = imax(1, sched_slice / SCHED_SLICE_MIN_DIVISOR); hogticks = imax(1, (2 * hz * sched_slice + realstathz / 2) / realstathz); return (0);