From nobody Fri Sep 18 14:14:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmZQ92v7Tz6sWrf for ; Fri, 18 Sep 2026 14:14:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmZQ872wqz4jZL for ; Fri, 18 Sep 2026 14:14:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qm0w0lI1M9H/nB/pLe2t64XyfGyQCAZ8Hho9/MR1ZWo=; b=eLksQFQsi6R75aRalXvIWzvvs63CytysDPhxF6daxMOpW21hORKtfSOj7haZhqitCC5zSL mBU68Eysj+LHlprcRgrP1gK6smMiPiB35+cje5Iq8tt6rhJN46LKizbBVD0X6FCCdi3R53 /DnzGMyRwh1ZrLiYJpjxQpV1nZsJ0o8eMcgt4ngLKMKh4+8H0higTUiua7iASvQVeuhzrT LLLg0IyVrs9+sST6aPDon21SNC497sIKdIFmMfgPmbCndrNuvrgAXVNgaBmDf+gzdnpl3M yro/FIwhXOdACcW3eVGr3eopVr5qxSU6IrZt6l2a9MnfFlzxQd9dDP8CbgKwUg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789740897; b=p0FYPtR3YHyd1aU8al74pogoRBOjn0vK60M4es8hLzVtzs++tymLR0yAxBCl5e+rPLDt0E L6wPPca8y067zvXKAYUv102wSte4NCDRz8brE9gPmmyDNIA9eb/ALPb2N4IGCuUg8mPI7x SISb7nJ8p5TL1HUJlbb8+5sIndPnokQcSzD0j6YhgyBJaOUlh1M2IsxrJj04UE1KpfP9Yd Q8WxXwWF3V29RnxDgsi1RmyyrFL73pwaNKbr4TuAh5Nrh5EQDcJJtK7KDczy5wg3e+jYL/ P1g887Y68MpI325uR6YSZ7rgtNPoP92qJ8UT9WangHKnuUvLEuFzOPbFEdBouA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qm0w0lI1M9H/nB/pLe2t64XyfGyQCAZ8Hho9/MR1ZWo=; b=QwUo0NISKxzNRAqGI/PsvmtQklvV5RKD8wqiyxG5bWtntzaSOdEc9TWgQMb5BhMUU8QKxe v6u59t2lf2QVu1Vaq/P7GdonzHL09NG5vsQkcVtT2429pyuBKcSDG4wrcXPNRWM4S6ULV0 amg4rH+UWg8YS8BVXj4ZH9rm1wLM/+JzASzoWh5syy3vK8p0NK/y2IOuOTNhBBzDL6tWQ8 9q/oVgrP+QCKg92xXXDCHimaMy9PbJI1BPCdYuUZ3/k6aDzoXwK0mVLYqnXeaXN98xGAfW 4V84UtGy60kEi0IYv4j5+LXkTTkWQAsOnJJaCX9cIdtCZ4p60Nq9e2RaAKzZeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmZQ85nfhzM28 for ; Fri, 18 Sep 2026 14:14:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44981 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 14:14:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Minsoo Choo Subject: git: cd33abbce5a5 - main - sched_4bsd: fix vague comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cd33abbce5a5c3b454f00ca3d0ecd71c2234106c Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 14:14:56 +0000 Message-Id: <6aad4760.44981.12734f22@gitrepo.freebsd.org> The branch main has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=cd33abbce5a5c3b454f00ca3d0ecd71c2234106c commit cd33abbce5a5c3b454f00ca3d0ecd71c2234106c Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:37 +0000 Commit: Minsoo Choo CommitDate: 2026-09-18 14:14:14 +0000 sched_4bsd: fix vague comment The comment "was incremented in schedcpu()" doesn't give enough background for decrementing ts_slptime by 1 (thus ignoring decay_cpu() for 1 ts_slptime). More accurately, ts_slptime is decremented by 1 because decay_cpu() has already executed once in schedcpu() when ts_slptime was 1. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59406 --- sys/kern/sched_4bsd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 27fbd3c5bdca..cd039501b609 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -585,7 +585,8 @@ updatepri(struct thread *td) ts->ts_estcpu = 0; else { newcpu = ts->ts_estcpu; - ts->ts_slptime--; /* was incremented in schedcpu() */ + /* schedcpu() performs one decay_cpu() on its own. */ + ts->ts_slptime--; while (newcpu && --ts->ts_slptime) newcpu = decay_cpu(loadfac, newcpu); ts->ts_estcpu = newcpu;