From nobody Fri Sep 18 14:14:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmZPz6pgQz6sWhV for ; Fri, 18 Sep 2026 14:14:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmZPz0bb6z4jGx for ; Fri, 18 Sep 2026 14:14:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S6/WoRy678Azye6hvdqY8nCxfLHutXfNA+aoCRUBifg=; b=CHRlujxX8a0eiffq2plYHtjOIrZa12bHrjtdjuXSkdIAjOEmjjJN36B1PcnH7BfSKKwZPj 2hkRATBwQhGi45D1Tw9NkZVTXSeWqwKl9yP01QxNMx2NU3OhaNllEgRs0PS1ng1bgZboAe fJJ75esuXdMp7Rse8dBVkHmPuynjczTeYfzO6Sa+idugJOB4GDXtBdsOtSFojqnP7Ocm3k jkjhfeZxHdjaqov6tw/vT9EnO0NH3D7IdKqe4lJGOpnB1TewsDdxlVRotMAwIz8ZqEH/yn XWG4DBRgcmLf2a7/Vc+sYk3XQODoKTGF52UHNZYccAa/mscAQaT6YG0eA5szoQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789740887; b=jnAApCFcXu5YhRmcTE+XIpIgr3/2U28HGG1E5xrvmbiS6aj0dixp82kNo44TfUKgEgl/Ji kGI4oYmV1qHJlM0kcIRGjqBERUCCgyI/qapMv5EDINOy40smJiwQglXtcoXUm6U0897QO6 FuQ4SOi4id1to7el10v32ncmhJbBQIGQC5dlREWuMA2A38oXgJfYtZokIvtU75QvSIHu6x HhSGZ8GEsdKqaihzTn0i0NdjtcNPG9GXVORxsSKlUW6PdNzTuAX94gUFv9Dgp9z81YKy7w wIsOzWua/SJOvUtePkfswrupWvX3lMNY+PYuhAg1HWWLGzvrcVOY0niUYtVk+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789740887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S6/WoRy678Azye6hvdqY8nCxfLHutXfNA+aoCRUBifg=; b=r3TWJhntU9kSwnR1cZwmYY+7T8XNxF06fVnR9/hT7cERgg89zCmvf9CbqG6nFnlKsPt0G5 +4TK3xSlXtt99uO2FCBWrSDueJxlDk7BN1lE0ijsOhNR9Sp/tdo8NTOwcZk+Ti9Jma9giF 1uYFqcllmmudRn6ygwtANNh+5TPYzPe7+zH/6v2+2gvnxK01oEOBGO+bYw8LzXko8X3s0a vk+uHvE/oWDLt47hrdPFy2f5HdgitLFc5gMlj6bqA5iN4A8WjSRAnHsy0cSk4+9tda2aNj EkBJDLEPRklaVd8HbSFQ2U3XGOnXGgqA/r5/gxI/EwENTOTFtDPUfU3qeRpNEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmZPy6XzjzM25 for ; Fri, 18 Sep 2026 14:14:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43cd1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 14:14:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Minsoo Choo Subject: git: e90be6fdf085 - main - sched_4bsd: add static assertion for nice weight List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mchoo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e90be6fdf08526624f407923d003b66efa23d304 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 14:14:46 +0000 Message-Id: <6aad4756.43cd1.559871b4@gitrepo.freebsd.org> The branch main has been updated by mchoo: URL: https://cgit.FreeBSD.org/src/commit/?id=e90be6fdf08526624f407923d003b66efa23d304 commit e90be6fdf08526624f407923d003b66efa23d304 Author: Minsoo Choo AuthorDate: 2026-08-24 02:25:32 +0000 Commit: Minsoo Choo CommitDate: 2026-09-18 14:14:12 +0000 sched_4bsd: add static assertion for nice weight When NICE_WEIGHT * (PRIO_MAX - PRIO_MIN) exceeds the timeshare range, two CPU-bound threads with different nice values can have the same priority as their nice values are clamped to the timeshare range limit. Add static assertion on NICE_WEIGHT to ensure that there is always enough room for nice values in the both end of the timeshare priority range. Reviewed by: olce Approved by: olce (mentor) MFC after: 2 weeks Sponsored by: FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59396 --- sys/kern/sched_4bsd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 95170c1a4e02..f5f31ff4fbfe 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -72,6 +72,10 @@ */ #define INVERSE_ESTCPU_WEIGHT 8 /* 1 / (priorities per estcpu level). */ #define NICE_WEIGHT 1 /* Priorities per nice level. */ +_Static_assert(NICE_WEIGHT * (PRIO_MAX - PRIO_MIN) + <= PRI_MAX_TIMESHARE - PRI_MIN_TIMESHARE, + "Priority range accounting for nice values cannot exceed the including " + "timeshare span."); #define ESTCPULIM(e) \ min((e), INVERSE_ESTCPU_WEIGHT * \ (PRI_MAX_TIMESHARE - PRI_MIN_TIMESHARE - \