From nobody Fri Sep 18 10:28:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmTPN171Pz6sFxX; Fri, 18 Sep 2026 10:28:56 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmTPN0Zrpz3MJM; Fri, 18 Sep 2026 10:28:56 +0000 (UTC) (envelope-from mmel@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789727336; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZWR8X0wHcmC3448TIaOxVrFgAwYTkZnEeVG81sMStDg=; b=xyaFYo97YxjMp8lAU37RKIgl2xMEYzCj0VdOg6oZR97bX2dKxDNnnGyWwvX46w/6OrtWxb TtZGTUxPDVFBHmy+KVmbP9hRTUTDwR982W0SyEdmKJh33olZ/MZhJQeOrle/96tuP6ZuBQ xP0g2B5aQVVCk274uXyKrcs60ZXrL7ogwROKFvMiFgp5FL17Pv5PoOCzk9s7Vpa8IsV2Dj 195xI5erzm4d3yNCXUQnPxhA2ug9Y5oLuasQPmrEcWYbcSqhdcj3sUQ4gCvRB1ZY3L598U iOYLbd3mHnFpoz9BzNtKVw6fUTdk7hdXUopA77OpZNtIgdbaKo0Oli4rqSVdOw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789727336; b=VtFikj9lZM8beOLGPjOBj+MV1X+le9W839z9fqsbI7bbjRWn4tUe2Ir83Zd7AfMWaB+d2g pKiHhm3IeL6eDuGdXMVu3jdQnVA5O701s6xrQGYV90v0VtRq4MBOHBgwgIOvL6INi3ZlHk 1Blu7LlRKSBWPAEmg1cB9BCgn9EEYxQ0WBd3Dv776QWcl6rgfY3nBulIYD5TYOAjuXubkA 466s1/ZZoKeWtjfGwMbJsvMvi9MB4rLSV2MglgShVbixK/tvbsLdTSOG6287oLFGHqMik5 UnrToRL1XRgnHJkZWQtFCFcolW+vzPDIfkKPfaaaY5APt1bV4FwyCtCUpQBJYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789727336; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZWR8X0wHcmC3448TIaOxVrFgAwYTkZnEeVG81sMStDg=; b=YdJ+loRIKVll3Z0h482oeC24jV4QkQBG8Pt+JL/TxMfjS9131EFJZyPQYxnr6BZuqElvXE lNEp5PWmSL8wfFBkAUGw0YZmBW2NcYwjgLb+4CwM2AXf+6x35jtB5u5gEjMlQq1RE6EVZG xYLDmDsCA3+bTqKG48e9lqKvzLzMDBG/Wk7uFSNY0gS9cnqMlGiGd/cBuhdEad6/xUgnpz /woG5m5zRyT6IoSPcw2wV1cQXfLS0HJSXzO1jfdizXzGI91RoO3+PNv8JpMv2fOYfFsHKB JvGrl+dU/5HTPxtel0Lx5qwYES5WXNL+lANAAdvtohIOYWk/Ivdpb6eeR7HSZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2001:67c:14a0:5fe0:375f:c0b1:757c:98c] (unknown [IPv6:2001:67c:14a0:5fe0:375f:c0b1:757c:98c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mmel/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hmTPM2x0KzdWn; Fri, 18 Sep 2026 10:28:55 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Message-ID: <1106f0e4-6c51-4235-85fd-50a62d021aab@FreeBSD.org> Date: Fri, 18 Sep 2026 12:28:54 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Michal Meloun Reply-To: mmel@FreeBSD.org Subject: Re: git: 477c594d9063 - main - kobj: allow multiple inheritance with per-class softc To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6aa40ba9.2672a.7c32cf3e@gitrepo.freebsd.org> <19D9A1EA-4026-407B-B1E6-23DBD16490B9@FreeBSD.org> <5e03e401-5778-4459-a501-e9f7b5d56a0f@FreeBSD.org> <35AD4B98-4BE8-4A6A-99DC-89D881C9BDD5@FreeBSD.org> Content-Language: cs, en-US In-Reply-To: <35AD4B98-4BE8-4A6A-99DC-89D881C9BDD5@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18.09.2026 11:32, Kristof Provost wrote: > On 18 Sep 2026, at 9:11, Michal Meloun wrote: > > On 18.09.2026 0:15, Kristof Provost wrote: > > On 11 Sep 2026, at 16:09, Michal Meloun wrote: > > |The branch main has been updated by mmel: URL: https:// > cgit.FreeBSD.org/src/commit/? > id=477c594d906328e210c30cf2c21d983152f21de3 cgit.FreeBSD.org/src/commit/? > id=477c594d906328e210c30cf2c21d983152f21de3> commit > 477c594d906328e210c30cf2c21d983152f21de3 Author: Michal Meloun > mmel@FreeBSD.org AuthorDate: > 2026-09-11 11:47:30 +0000 Commit: Michal Meloun mmel@FreeBSD.org > CommitDate: 2026-09-11 14:09:36 +0000 > |kobj: allow multiple inheritance with per-class softc Add > support for hierarchical softc layout so that a leaf class and > each of its base classes owns a private softc region inside a > single allocation. device_get_softc_class(dev, cls) returns a > pointer to the softc that belongs to the requested class. The > classic device_get_softc() still returns the leaf softc and > remains fully compatible with existing drivers. Existing drivers > are unaffected; they simply obtain a slightly larger softc block > when they inherit from base classes. | | > > For some reason this commit causes my machine (Dell T640) to > fail to boot. > > It doesn’t panic, but it seems to be very slow during boot, and > seems to remain stuck around when it’d start userspace. > (Freezing just before | Trying to mount root from zfs:zroot/ > ROOT/16.0-CURRENT-20260917.222603|) > > I don’t even begin to understand how that’d be related to this > commit, but it’s very reproducible. > > Do you have any suggestions for how to begin to debug this? > > Thanks, > Kristof > > I also don't see how this change could have directly caused the > described failure. > Could you generate a backtrace from the hung state? Ideally, > generate more than one to see where the kernel is livelocked. > > I’ve not had any luck getting a backtrace out, I’m afraid. While in the > hung state the system doesn’t seem to be processing anything any more. > (That is, I can get it to break to debugging when it’s working fine, but > not in this state.) > > However, I added some debug output and spotted this: > > |KP: device_set_driver() smartpqi 2579896 != 2579904 KP: > device_set_driver() nic_uio 184 != 4294967297 | > > And that last one does seem like it’s maybe a bit more than it ought to be. > That one’s installed by net/dpdk, so could it be an ABI mismatch? > (Presumably the kernel ought to be a bit more robust about 4294967297 > sized allocations, or at least panic here.) > > Also, can you, for test, replace > "size = kobj_total_data_size(driver);" > with > "size = driver->size;" > at > https://cgit.freebsd.org/src/tree/sys/kern/subr_bus.c#n2503 > ? > > That lets it boot. > > Best regards, > Kristof > Thanks. Yes, nic_uio is clearly the winner. The struct kobj was changed, meaning that all external drivers must be recompiled. But this should always be done after any update. Michal