From nobody Thu Sep 17 08:05:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hlpGX3LcSz6sf6x for ; Thu, 17 Sep 2026 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hlpGX2rBrz50v2 for ; Thu, 17 Sep 2026 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789632340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PatEU3cc4zlogjPRKsTs8mO+XqLXQDowzsMy5fJjZZ0=; b=C0YMeVJ43xD294M7+Jtb+WhdeOhA0h1/AhoNHivSH9RRpbL9PIoZXCeJyKu2RAcjPZWCFn ZKYQUxT+vE9gGSmEFiDEQBQfKzjhy6BfEpC1md2S1OtyxOz2HJbA1iIMJjssGQqTmRg0XJ t07tqoLOEFW1KACydngir8cyZnm+LinwGcVqX7OKWG8MMwSocTY7GPA5ANKDb/sEBhK0KC mKqiKRzVSEChUIso3bIrTNUwsQTxLmTnKmFQIbouExRAzKyIQuhEABLKlG0cDwUBa4E04Y 7iBb+osXRtJvXPcZd5JccjTGpBzeMQMgcyU4d4iyQ5XpBNYO8/XE7Mpp8MgKbA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789632340; b=KBPf5EWwFnbgIjyjaOKgtcPBjLYPeE1Syj8BzXTRXyV+cn/7uRGQNKD8d8HGi/1+eiY7LO hgJ9HY45OPcQAy2lAwvSZm6hy7PKyyrnpO5SQ2SX8mW0KbTiRcpvz1dSd/hZQeUvEX4jt5 CRYNOpIvqRD/ItlxT1EE+y541uDGkuq0U1ctLQqyqwLgXolM7bczm+kRHugiTfkO2W+fkW rn+TXzgkiAGApbEIYZCDoj7vq49XreHvHSqwT82+P/KV5o+aj3Y3DYoubCl3syexXnrw02 zdXHRnFWQ2cAvWnqltO/MOZ7YwnbKFJgDZpDnKhElDWn3IJL4NdZynHP7XTmnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789632340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PatEU3cc4zlogjPRKsTs8mO+XqLXQDowzsMy5fJjZZ0=; b=xBkZL2F4zycgXnirdKqiM8X7JEWrQxvH908Af6dxzFwCfhgzU60qqpCoXgsqlU9qB9ARG3 KgJY/h9WwXzgHEjz00m+zBP0x2h5RPjEIIxFWNPyNDxUzmbZ/Y57C2Ox5B91VcpwNti94Z xb5siI1DcwvlDKuyZ/3sCjlLmvsNQS/cg5jciv79VZK1gxsgrRe4YLhhbO5nQBsIrxACoM +SLXPcdcm89jtgm526ZwNIYE5tCSJwzp7tkhLSYcRrCKuCFTB3OgQ25Qb3A2BypV2KXiYW 0elJKVioRQAPJZyl7oLSstHgoJ+jTN11U0b4moIEz/P00RZIrQRAW4HJpLxGJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hlpGX1snpzNZt for ; Thu, 17 Sep 2026 08:05:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39b35 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 17 Sep 2026 08:05:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d38e0889d20e - main - ice: Report VF queue enable failures as hardware errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d38e0889d20eed3885a020993b72dc9855148ba3 Auto-Submitted: auto-generated Date: Thu, 17 Sep 2026 08:05:35 +0000 Message-Id: <6aab9f4f.39b35.6aa4244f@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d38e0889d20eed3885a020993b72dc9855148ba3 commit d38e0889d20eed3885a020993b72dc9855148ba3 Author: Kevin Bowling AuthorDate: 2026-09-17 06:53:41 +0000 Commit: Kevin Bowling CommitDate: 2026-09-17 08:05:01 +0000 ice: Report VF queue enable failures as hardware errors The ENABLE_QUEUES handler has already validated the queue selection before attempting to enable Rx hardware. A timeout or unexpected queue state is an operation failure, not an invalid virtchnl parameter. Return VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR for these failures, matching the disable path. Keep ERR_PARAM for invalid requests and attempts to enable unconfigured queues. Preserve the recorded state of queues which were enabled before a later queue failed. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ice/ice_iov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ice/ice_iov.c b/sys/dev/ice/ice_iov.c index 0278d10abd36..0d53f8f14253 100644 --- a/sys/dev/ice/ice_iov.c +++ b/sys/dev/ice/ice_iov.c @@ -1530,7 +1530,7 @@ ice_vc_enable_queues_msg(struct ice_softc *sc, struct ice_vf *vf, u8 *msg_buf) device_printf(sc->dev, "Unable to enable VF-%d Rx queue %d: %s\n", vf->vf_num, bit, ice_err_str(error)); - v_status = VIRTCHNL_STATUS_ERR_PARAM; + v_status = VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR; goto done; } vf->rxq_enabled |= BIT(bit);