From nobody Thu Sep 17 06:05:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hllbf3nJjz6sV14 for ; Thu, 17 Sep 2026 06:05:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hllbf058kz4X50 for ; Thu, 17 Sep 2026 06:05:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789625118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CdJr4XJd+gfxUK2qhIRL9KHRs5NWaoP95jifdzpxJzM=; b=noql1UIAhn2Axw6qkNGfDnliOH31RDGllKhj2odvHKRWhX7cMqCMOyquZ780ptFk+fGZqQ TrwNiB1A/4PNgoNxV5WbY3qKwRy53Dkf33r7E3V2QbXfNDmbQnShmaIBVam0rRoL/+Xcew V88Cd3AMPTj/LmF0IAeowrhQ17smP7Lf2aKTshVJ/KecITovB2egagP4i9paJItzzshsZt nuVom0iNyc2nAjLMQe/PjK97zx1HRkbL2rWU9EukDbTVyUbUvI2+LUvR1vq9j3d93N+vLJ CHvX30Ohf+WYQHIKXX870v5sNk0GbwVQC5OuXgV6KUxR9tNui1WMxFC5WDL5ZA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789625118; b=l0evV1Zl9SOQAaU/qRIWiJ064k8yq3ppm0mPn7qrON9fmE76Cxx+jm8/mCFqSJOkt4ms7/ rmXyAZd5/FedFozoDXUzxi+RNKbRfcPW3ggCewk6mR41LaypF6C0V1KsDQ/wJSyn6aompH QyCabIPWaEW6tdox1gqN1kWs3C+FrSBAiZ/oW4dBUL9aGoXFAaVtozcA7GDKfA3qhPdz59 bA3YxpvQ26aE07qIoESdhp6lo4IP9Qnmirq/EN8k82qd4EAjgl3gRaSUNKO9c7sSzTqyiG ImpvT9u+dm7gRqbrbrgemQFjEWWPyLOETPNHNRhBf5P1V3VYx0Yg7Qu2yLthCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789625118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CdJr4XJd+gfxUK2qhIRL9KHRs5NWaoP95jifdzpxJzM=; b=IspPZjqNraQHf9ONMpyG1i52+sE5auX+MI1D0ybtXdCBtpEWVEzNf3nThBVESl9UAHu/2C ZBbZG3O34xUyn7mEKOhQFTdUAyx3E0zAWJkvNkoylTnFcECN4iv931T45m9+OpBYLKB8SY +bOqTFM1Y3N6gfOzHB/6j/67XX+UI6S3exg8DWtcjSoWvOuhz3GeXePWCJiGuq6Ce7O5ak 4uVurB4DsjpxYsTN5T56eiqppRxDOQ/bzBCQJp+Wq8DRMY78EE2x1bRhP4nBfJ4QFNF33W jx66O+jIcf1JyRbDB2z77iCiJpHIMn/03ufA1QxoKSw+DAmeGwXZbqUO0/rK6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hllbd5mqrzKch for ; Thu, 17 Sep 2026 06:05:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 252e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 17 Sep 2026 06:05:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 6a903d983764 - main - ixgbe: Report hardware initialization failures to iflib List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6a903d9837645a9dbf990b699f50c67ad984c043 Auto-Submitted: auto-generated Date: Thu, 17 Sep 2026 06:05:17 +0000 Message-Id: <6aab831d.252e1.129c50a1@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=6a903d9837645a9dbf990b699f50c67ad984c043 commit 6a903d9837645a9dbf990b699f50c67ad984c043 Author: Kevin Bowling AuthorDate: 2026-09-07 11:30:52 +0000 Commit: Kevin Bowling CommitDate: 2026-09-17 06:04:37 +0000 ixgbe: Report hardware initialization failures to iflib Check the result of ixgbe_init_hw() before configuring queues. Report failure through iflib_init_failed() instead of publishing a working datapath after shared-code initialization failed. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixgbe/if_ix.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index f2841bc04e2e..9aca44c6d8fa 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -4254,6 +4254,7 @@ ixgbe_if_init(if_ctx_t ctx) u32 ctrl_ext; int i, j, err; + s32 status; INIT_DEBUGOUT("ixgbe_if_init: begin"); if (atomic_load_acq_int(&sc->recovery_mode)) { @@ -4282,7 +4283,13 @@ ixgbe_if_init(if_ctx_t ctx) ixgbe_set_rar(hw, 0, hw->mac.addr, sc->pool, 1); hw->addr_ctrl.rar_used_count = 1; - ixgbe_init_hw(hw); + status = ixgbe_init_hw(hw); + if (status != IXGBE_SUCCESS) { + device_printf(dev, "Hardware initialization failed: %d\n", + status); + iflib_init_failed(ctx); + return; + } sc->iov_mta_valid = false; sc->iov_vfta_valid = false;