From nobody Thu Sep 17 05:40:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hll3H2nD6z6sSJg for ; Thu, 17 Sep 2026 05:40:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hll3H1BPlz4RMK for ; Thu, 17 Sep 2026 05:40:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789623643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=igb8kK9mvI974R9Q3jWZjUmrKvmpfxb05yeNcyg3uqc=; b=QKN7WwRqH9xWe7c40aFu9RAPqwkhgxWCEGZU4AiM0KpqsS39RBh8kcRrnEcgfgVHcpHFR+ 2vOS/1Q1E40Dyeh2f+G903ra2i0qMNnDujsIXMoxJFgdGsOh+a5kVMABI072hoD9aDtEEd u8MO7hjgUCUI9tiqHexyBYYpojc6Ljfd0qDZPI5o60DIfy8HgHGGy0Nm2yicOXf4UflTuw gXYkM6LA/2dqHslwuvcPjoYhigf5ErqkKoZv5Pphgu9es2aCVff2z1Pu54CYhnY0yALUTY RItsJ1fgZEHc6GgKCtfIE8ER0i90SVk/d8j7s2fte2KgyX9OQZq8f6xKZrrWNw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789623643; b=yeDLK/t9L+FtLCP5oEFMcienhakfXQqOqesvl+KKlLNJ77JMrsB7/PbVapMTPNOOFzGLuU ZaRbHes9Y6SQjX3g1xL7nZYiqs1XKiKK8JmRh3bCSymhrDJrFyKA/XzDM0/CFw/awXu1Od JBns5fut1vPbzLNSxMp9aLVGtPgINBBw4GQW6Xik1tq+f7AGmm7PIgSPgKLCJ5NRtbaNex 3DifjB5NFFhzUQ+HFymrjUpoSYE7Mgs13+IQnsssiv5bJr+5OQfGtq43OvkJw3j2BB+Cw0 0SI3uXqNME85Kdx+EjV8760qc5bOEQWdRQR7fNERmpvgw39AROj4WoM82NAK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789623643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=igb8kK9mvI974R9Q3jWZjUmrKvmpfxb05yeNcyg3uqc=; b=HTcFiUuEoeUrqOfLVyIYT7uRCdVfx9xVJupu9ref9Dx/HP9vrMK5RtUsK0P8wpbESAhxYj 3MxpL/cVD8ANkI0fDeC7Np7IgaFa+hhtesMKwO4buPSE3hDTZ/kr6bRxSJZFzpLoi2o0kZ UeCaRPPTQ74y9s7zecSpQ0KkKpMMt3LMy+dru6FG0vapuB+P10K6u0EuEht3IzsO5ob+C9 Mou1l/HwP3ifPs0uoMMOhVRto1jN84Um0uD2ZSnCukSsyTvyIOcUgjFkmbRK1UGpE2dN6p 6Ts+C3BJxU+/BdETNYXZwuG8kO1KLeBIhFh50WQRa4XKxYdcBmK/RkWtCMfdaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hll3H0FgzzK6Y for ; Thu, 17 Sep 2026 05:40:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2213b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 17 Sep 2026 05:40:37 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 5abfd8fe4d1a - main - ixgbe: Defer flow control programming while admission is closed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5abfd8fe4d1adb74863231f27a9958cf176e3ded Auto-Submitted: auto-generated Date: Thu, 17 Sep 2026 05:40:37 +0000 Message-Id: <6aab7d55.2213b.530bc40f@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=5abfd8fe4d1adb74863231f27a9958cf176e3ded commit 5abfd8fe4d1adb74863231f27a9958cf176e3ded Author: Kevin Bowling AuthorDate: 2026-09-11 21:42:24 +0000 Commit: Kevin Bowling CommitDate: 2026-09-17 05:39:41 +0000 ixgbe: Defer flow control programming while admission is closed Cache a validated flow control setting without touching hardware when iflib has closed admission. The queues may still be live pending a watchdog stop, or the device may already be stopped or suspended. RX initialization and link setup replay the cached flow control policy. For live updates, decide once under the context lock whether to touch hardware, then mask MDD around SRRCTL writes regardless of a concurrent watchdog closing admission. The context lock excludes actual stop and reinitialization while these writes are in progress. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixgbe/if_ix.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 2ece3b7bc433..f2841bc04e2e 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -5679,10 +5679,16 @@ ixgbe_set_flowcntl(struct ixgbe_softc *sc, int fc) return (EINVAL); } + sc->hw.fc.requested_mode = fc; + /* Don't autoneg if forcing a value. */ + sc->hw.fc.disable_fc_autoneg = true; + /* Init replays the policy; closed admission does not prove DMA stopped. */ + if (!iflib_is_running(sc->ctx)) + return (0); + /* Updating SRRCTL on a live queue is itself an MDD violation. */ mdd_active = sc->num_rx_queues > 1 && - (sc->feat_en & IXGBE_FEATURE_SRIOV) != 0 && - iflib_is_running(sc->ctx); + (sc->feat_en & IXGBE_FEATURE_SRIOV) != 0; if (mdd_active) ixgbe_disable_mdd(&sc->hw); if (sc->num_rx_queues > 1) { @@ -5701,10 +5707,6 @@ ixgbe_set_flowcntl(struct ixgbe_softc *sc, int fc) } } - sc->hw.fc.requested_mode = fc; - - /* Don't autoneg if forcing a value */ - sc->hw.fc.disable_fc_autoneg = true; ixgbe_fc_enable(&sc->hw); return (0);