From nobody Wed Sep 16 15:35:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hlNHg23TTz6rfDt for ; Wed, 16 Sep 2026 15:35:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hlNHf722Zz4h1B for ; Wed, 16 Sep 2026 15:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789572911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GU6/03lm88CsEHWQRm5Wxshr95CDBz2a7gjwlNtVu/o=; b=FvJHVmOZI+kABg0+yCCvJRYv4LIaMlZtjsK7dM5I513F2LkPdGR92rv9rd+XD9BFMPvsC7 BTrYiE+J5NZILX7F2fFXF5WDXoxXTmOv0E0VqrDq6NoHYCQP4+dMivqMYEyEJ5sU5V9x/P 9HyCH3Jq+o0TO0xKEzSJ0hWLaCzCyfYXcHndg7giyKaBvt5NmcNhK6gD9mvleWsmY5ORgE TxkykU505isaw4BRv5Vs1TrGDIEAfhP66pNsQK/hg00URZckoCm3JJxzsne67buiPcz0mH dku8U6ZG0ByRHeYGonNYxosVK2mzOs7iHIGVK9GZIKn2lGLF2Y2lu2Vhab6dlg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789572911; b=WFEK8fY9Di+uD1z7QlSf3lHjZzlhgiyd+lznRVIgPk0+thdnknOLB3atrE49hr9PWnRfI3 pj14aEAc9AuXaD2PeHcvc3XlQSg+T38H8mgpr73pNHo33wokpuunULp8/8zhEe04xCZg7j Hj+ynf5EwPqTwd8tObp8y7oSI35PSanm2jgxJ3Vvtg0i2Zj/ShlIiR9vNw3pj1Cak01NL5 aBqq3q/d/bCsMcrMH1H2dv3plBdC62W0N3drrdinrY5uO9w4epecZ67FilJBW7MC3djxhL O6Y1CTVY87fdEbr2fwXQ20q/aDBmphJUD8+Bj2Ogc0elDzIgafiL40dyGG9uBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789572911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GU6/03lm88CsEHWQRm5Wxshr95CDBz2a7gjwlNtVu/o=; b=iBfXhtj3mPV3/795kk6LkU6pQ0g9NeUm56Z2AMO2R5dUy2NeFnUsvpddf98rVgq23o9K57 tpnAuElJHxF7//iN7WmeVL3wFDevcwCHkZP6yvbPzskI1e8YjfOCjE728nOB+8dVIrfCEr QVBPKE65Ob+r0tDlvhYZB9XYJ8UN5w9nKqSfYWBKLrzfsdgvsj2AWkTBZ4i1/RolGo4Km6 FTTOUORQxQoUMdmhxonT7VXQ1Y0Fu8gfWRpeqmzxIbYcPqhs3I7KtL+Rm6u+z73zEheJXq 5WOhmggr0MFVwahF4CPKiW7pQZ5PHJayKxDjtjh3KaOzjIZag5pwiNt8KWo7qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hlNHf64Jwzrxg for ; Wed, 16 Sep 2026 15:35:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e0c9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 16 Sep 2026 15:35:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Andrew Griffiths From: Mark Johnston Subject: git: 3484217cc47c - main - proc: free kstack buffers when debug permission changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3484217cc47c1f77d2be2ed0e012b870d1cd3dca Auto-Submitted: auto-generated Date: Wed, 16 Sep 2026 15:35:10 +0000 Message-Id: <6aaab72e.3e0c9.76c9d9ee@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3484217cc47c1f77d2be2ed0e012b870d1cd3dca commit 3484217cc47c1f77d2be2ed0e012b870d1cd3dca Author: Andrew Griffiths AuthorDate: 2026-09-14 07:55:01 +0000 Commit: Mark Johnston CommitDate: 2026-09-16 15:34:31 +0000 proc: free kstack buffers when debug permission changes The kern.proc.kstack handler allocates its output and stack buffers before deliberately checking p_candebug again under the process lock. If trace-control state changes between authorization checks, the failure path balances the process and exec state but leaks both buffers. Submitted by calif.io for the OpenAI Patch The Planet program Signed-off-by: Andrew Griffiths Fixes: 8b5abd9027b8 ("kern_proc.c: disallow execve around sysctl kern.proc.kstacks") Reviewed by: markj MFC after: 1 week --- sys/kern/kern_proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index 6489feca99fc..398de3a182f5 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -2890,6 +2890,8 @@ sysctl_kern_proc_kstack(SYSCTL_HANDLER_ARGS) execve_unblock(ctd, p); _PRELE(p); PROC_UNLOCK(p); + stack_destroy(st); + free(kkstp, M_TEMP); return (error); } do {