Re: git: 09711ccb09f4 - main - Remove source_rc_confs, inlined from defaults/rc.conf

On 15 Sep 2026, at 22:55, Devin Teske <dteske@freebsd.org> wrote:
> 
> 
>> On Sep 15, 2026, at 2:31 PM, Jessica Clarke <jrtc27@freebsd.org> wrote:
>> 
>> just because you’re listed as a maintainer doesn’t mean you
>> shouldn’t seek review from others for 100+ LoC commits.
> 
> 
> LoC is not the handbook’s "non-trivial” test; most of the diff is comments and deletion of the mistaken inline.
> 
> The committer's guide encourages review for non-trivial work. It does not require a Differential for a trivial follow-up on your own files. eaeb5f29bc6f inlined source_rc_confs from defaults, broke A_flag, and left a load path that could not work. I took that out and the direct debris. That is trivial in the handbook sense.
> 
> https://reviews.freebsd.org/D59658
> 
> 
>> We all make
>> mistakes even for code we wrote that we know like the back of our
>> hands, so more eyes from peers can help us all reach a better end
>> result.
>> 
> 
> I’m correcting mistakes I failed to catch in bapt’s review; siva later caught them in the tests.
> 
> 
>> just because each of these changes is fixing something in the
>> same commit doesn’t mean they all need to be bundled into one commit.
>> Splitting them up into multiple commits makes it easier to review (both
>> pre-commit and post-commit), and makes it clearer which source changes
>> correspond to what part of the commit message (even if maybe in this
>> case it’s relatively apparent when you look at the diff, modern source
>> control software makes it easy to break changes into multiple commits).
>> 
> 
> Splitting leaves landmines for bisection.
> 
> The bundled pieces have to land together so main is not left half-broken for bisect.

From what the commit message says I find it hard to believe that it
would not be possible to split it into multiple commits without
introducing new, temporary regressions. Is that what you are trying to
say here?

Also, can you please not be so aggressive to any negative feedback? I
really don’t think it should be this controversial for me to have
pointed out that a commit listing what sounded like at least five
separate things should have been broken up.

Jessica