From nobody Tue Sep 15 21:31:27 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hkwFT1PP3z6rZtk for ; Tue, 15 Sep 2026 21:31:41 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr2-f27.google.com (mail-wr2-f27.google.com [74.125.225.91]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hkwFS0s5Mz4PRs for ; Tue, 15 Sep 2026 21:31:40 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 74.125.225.91 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-wr2-f27.google.com with SMTP id ffacd0b85a97d-4843796e373so102599f8f.1 for ; Tue, 15 Sep 2026 14:31:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789507899; x=1790112699; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kjbu5xzzkxImOAHqnbvNl3pyJ9IyZonKSwUrBFbuQH8=; b=Ia6acPFU7HT7FsiKFjNSc05AB0xv9GFiBeT+mwHckSH4+pPNNdnRq9MIWJm6PYyCkY wZOTIxUZnp+Xd5RdG7oROXWi0tGi1lGsBvwEzyPTzUNqsCWgFuK/9D2ze+i4iUbXVYy3 j7/4Y5xpmDRJ46/W1CUYfuuXOuB93ou4fzhCbyWqY9UrH8eWtdESBETe9R/CifSscIwY bWvIIY8S977Zw+ECWfVzIrW4uuyCJRYwsn5JVS/fgNd2an/IBTpIW7Kne34jRgAcPhj3 PNCAIrjGA4Ou+hiAnubsnHnP6bCNmxeMuEE/Z9nOUoOrJNMrn/Oqh6Utfw592mZG+8pt iDMA== X-Forwarded-Encrypted: i=1; AKwUvBxs32m+499GqKcNviZUjLB0H72OJXOE6b9yzWs8h9TEgBXPBxor0u1rqMipJvTPysPn28q2IGOT2SpK5evc8xsUBz0C@freebsd.org X-Gm-Message-State: AFuF++knDhsxFoZo23UOx53wtSFdJZPy8MQes9bAZOr0F4iIBwlHmOqg jIKI9oSKXypGpOjZilgDqXK1S+m6vHPfyJiLuk+tqNPq8Va2CpNNtfqJ+m4U0pIzlrS8gVuH400 dLSuj85s= X-Gm-Gg: AYBFou1B5UfwQf//vzPPOZG7WKYyTY4F+vRuwdtYdYJl+FymDnym+hVMHT5ifWQQrsC heqUJ0jTtAtF3qphhzk9hTO4S0+YtOuRilk1er7/6C9Lm97mJ/P07PALIUv1tr77onLaHU0NXKF 8fxaKnWpwKezePAxh6clisGmeC5IZ4/pC/tsBGzPskiY+nwi2vsZVyxikHcdlDvrKd3Ie659AK4 a0W43p11E4Q+Ja5+Scc17o00Q823lb0XdWqVUSbtDvJR8RAScZ6+QgAonEHH6oOfnMBpUZ26utO yf5A8NA/CXf8DrjdUNXcCBIwN5aZqCymzxLMVFLku7jmtgL41KH317I89Azs/ZvqvhiAsXCaBIQ UnMOFOQwtomKxbsXqjf1bkHdhtbXz8pGfus6xP+AkCqjLhRYLSrFnCHcHuCm0fVbHF6S0rz4S7i 5W5dMu3vyEEjhT2YCFEPk6TYlCa+AzsiVJHdf7zhP+TwdblzN0KKuzSAq5QFR3tDjb4QVcTi7b5 xbML+QQS4APKzDK7PreYdryxTc/0A== X-Received: by 2002:a05:6000:2003:b0:487:41c:175e with SMTP id ffacd0b85a97d-4870d03fdabmr257559f8f.22.1789507898515; Tue, 15 Sep 2026 14:31:38 -0700 (PDT) Received: from smtpclient.apple ([2a00:23c8:d60b:1d01:f97b:ed14:3f2a:b746]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4870bef7687sm2182296f8f.1.2026.09.15.14.31.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2026 14:31:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.11\)) Subject: Re: git: 09711ccb09f4 - main - Remove source_rc_confs, inlined from defaults/rc.conf From: Jessica Clarke In-Reply-To: <8192F29B-C42C-4579-AF0D-109F483846D5@freebsd.org> Date: Tue, 15 Sep 2026 22:31:27 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6651F051-4227-4ABA-A4A7-06DBB855FE93@freebsd.org> References: <6aa9b038.338f3.46192136@gitrepo.freebsd.org> <9467A34A-BDA8-4AC0-9883-1A5401EFF7F3@freebsd.org> <96890F48-7939-459C-92D6-026174AF5281@freebsd.org> <8192F29B-C42C-4579-AF0D-109F483846D5@freebsd.org> To: Devin Teske X-Mailer: Apple Mail (2.3901.100.1.1.11) X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:74.125.0.0/16]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:15169, ipnet:74.125.225.0/24, country:US]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[jrtc27]; RWL_MAILSPIKE_POSSIBLE(0.00)[74.125.225.91:from]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4hkwFS0s5Mz4PRs On 15 Sep 2026, at 22:10, Devin Teske wrote: >=20 >=20 >=20 >> On Sep 15, 2026, at 2:08=E2=80=AFPM, Devin Teske = wrote: >>=20 >>=20 >>=20 >>> On Sep 15, 2026, at 2:06=E2=80=AFPM, Jessica Clarke = wrote: >>>=20 >>> On 15 Sep 2026, at 21:53, Devin Teske wrote: >>>>=20 >>>> The branch main has been updated by dteske: >>>>=20 >>>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D09711ccb09f482fd345b2b640dbbeb66= de535041 >>>>=20 >>>> commit 09711ccb09f482fd345b2b640dbbeb66de535041 >>>> Author: Devin Teske >>>> AuthorDate: 2026-09-15 20:50:20 +0000 >>>> Commit: Devin Teske >>>> CommitDate: 2026-09-15 20:50:20 +0000 >>>>=20 >>>> Remove source_rc_confs, inlined from defaults/rc.conf >>>>=20 >>>> Inlining source_rc_confs broke sysrc_test:A_flag >>>>=20 >>>> While here, switch to SPDX, bump version/copyrights, fixup = comments. >>>>=20 >>>> Prevent common function override when bsdconfig includes new >>>> sysrc.subr that contains inlined commons. Fix non-unique = duplicate >>>> header variable incorrectly shared between bsdconfig's sysrc.subr >>>> include and new sysrc.subr include. >>>>=20 >>>> Harden RC_DEFAULTS parameter expansion from DoS-via-glob = (SC2223). >>>>=20 >>>> Move pgm to the correct location to not override bsdconfig's pgm. >>>>=20 >>>> Drop _SYSRC_JAILED=3D1 that is no-longer needed. Drop i18n from >>>> jail_depend now that messages are inlined to subr. >>>>=20 >>>> Reported by: siva >>>> Fixes: eaeb5f29bc6f sysrc: make independant from bsdconfig(8) >>>=20 >>> Hi Devin, >>> This sounds like it should have been at least five separate (and >>> reviewed?..) commits? >>>=20 >>=20 >> grep sysrc MAINTAINERS >=20 >=20 > Re: five separate >=20 > No. Every change is a direct result of the changes in eaeb5f29bc6f Hi Devin, Firstly, these responses come across as quite rude. Secondly, just because you=E2=80=99re listed as a maintainer doesn=E2=80=99= t mean you shouldn=E2=80=99t seek review from others for 100+ LoC commits. We all = make mistakes even for code we wrote that we know like the back of our hands, so more eyes from peers can help us all reach a better end result. Thirdly, just because each of these changes is fixing something in the same commit doesn=E2=80=99t mean they all need to be bundled into one = commit. Splitting them up into multiple commits makes it easier to review (both pre-commit and post-commit), and makes it clearer which source changes correspond to what part of the commit message (even if maybe in this case it=E2=80=99s relatively apparent when you look at the diff, modern = source control software makes it easy to break changes into multiple commits). Please try to think more about your fellow developers and be more community-minded. Jessica