From nobody Tue Sep 15 14:04:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hkkL16Dcyz6sGn5 for ; Tue, 15 Sep 2026 14:04:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hkkL13zpcz4FYw for ; Tue, 15 Sep 2026 14:04:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789481097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HvcSVVJmyOc9+RQyYAC1iMQRYWasJk2SnkpA/0zkxrg=; b=dShOVXOKSA0xD7/8bdkkiHn4YwG8zH+3jaFROOrRCoFt7IWRk/gGT8OI7a0F50pTYHX7LN JMfOwLSQHPHrjmz6JZj23jGtc/SjnB8836oPrB5anz0tbuICBDhsWPgv5+6GHo47rY6lVw JnBNx/yokFV/EwZ42sD4wiWLZeUgknaQbEm3pf75tuG2NY/O4LR7knCPtO1fV0synhfsQR MSji1w+KrFuXCzuoBstkxtRPKT51Gh8HzxYoePC9f10NnAz/ab9mfzOWD1QomxWSgG2/CV ZJQfyySTx7rFUtN/ucERh9XkLCq0xEtylxvCwZwZJcnq+AFk4vBVdyQ8sdzkeA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789481097; b=dwD/qvMvQapwIfbbVenm1c7rLQjJru+glBAI+324hkMewShw6ZIouTOo7GdjpR/x6OTY81 mzafXFz5unvAxyCs2a+cHzhe66lyuVJKWOz/kbUydJjP5uTSpiHMVpLWrQYidOV1g6e8dw ptmri266TCq9c/gpjSz4T1Tg6GdbdIFWCNe6AzCPRF8y+BwVGyJWXOLl5wmBnHXQf1U+XU m7sSuCVAHRaaP3WvR2YU0n8W47Bi4C0499+yPaN+bi/SIEUvJkX2rB7XajlMFD3nFXRR52 wyas1xydLFcXHoPbMOYyVSsXxe835vqDC2LytYbn3nOlr0OjURD8v8Zor1eDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789481097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HvcSVVJmyOc9+RQyYAC1iMQRYWasJk2SnkpA/0zkxrg=; b=lTZLQcQB4jQ8e9mF14CYynkEjN6DW3ly6Ht97YgrflVyvCgvl4tMPJjflPMLdcfm4KXaV0 jIPhrqEFPPmLCeNjLaTBoQzWqwE77Mrtp9rZOfWi5VpMRvbTE7d+DU0HdqfDuFfxXw9s5q U0gRD/RWozS/ER2XcUvf1D2DdK+zijdSDilZ5jGYZwjCWBgsYYnpEhL7kvd5mZCMXuG4sw qb2ric051W5S+X3MINS/IX/xWfLyHVqh/iWsA3gE8JAF62518pdw7rUv955+miP9kmH44b l5kwFe2Te170pdmKhdRQPK9W1/8AE3Oii/ayK4azq8680W/QnP1ffhC+l0d23A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hkkL12mz3z13RH for ; Tue, 15 Sep 2026 14:04:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 316ee by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 15 Sep 2026 14:04:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Quent=?utf-8?Q?in Th=C3=A9?=bault From: Kyle Evans Subject: git: 4505445ccdb9 - main - bhyve: tpm: allow the last dword of the CRB command buffer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4505445ccdb9555efc23262a971a18ca03486969 Auto-Submitted: auto-generated Date: Tue, 15 Sep 2026 14:04:57 +0000 Message-Id: <6aa95089.316ee.24964f63@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=4505445ccdb9555efc23262a971a18ca03486969 commit 4505445ccdb9555efc23262a971a18ca03486969 Author: Quentin Thébault AuthorDate: 2026-08-07 14:02:08 +0000 Commit: Kyle Evans CommitDate: 2026-09-15 14:04:28 +0000 bhyve: tpm: allow the last dword of the CRB command buffer The bounds check rejected any access ending exactly at the end of the register block, so a four byte write at offset 0xffc was refused, returning EINVAL and killing the VM. MFC after: 1 week PR: 291063 Fixes: 75909086a45d ("bhyve: allow read/write to full CRB buffer") Sponsored by: Defenso Signed-off-by: Quentin Thébault Reviewed-by: aokblast, kevans, markj Pull-Request: https://github.com/freebsd/freebsd-src/pull/2362 --- usr.sbin/bhyve/tpm_intf_crb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/tpm_intf_crb.c b/usr.sbin/bhyve/tpm_intf_crb.c index 7058b47733f3..ef1a3a6bf34a 100644 --- a/usr.sbin/bhyve/tpm_intf_crb.c +++ b/usr.sbin/bhyve/tpm_intf_crb.c @@ -321,7 +321,7 @@ tpm_crb_mem_handler(struct vcpu *vcpu __unused, const int dir, crb = arg1; off = addr - TPM_CRB_ADDRESS; - if (off > TPM_CRB_REGS_SIZE || off + size >= TPM_CRB_REGS_SIZE) { + if (off > TPM_CRB_REGS_SIZE || off + size > TPM_CRB_REGS_SIZE) { return (EINVAL); }