Re: git: b551cb063c5e - main - During shutdown, announce each file system as it's unmounted.

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Sun, 13 Sep 2026 19:35:28 UTC
On Fri, 4 Sep 2026, Alan Somers wrote:

> The branch main has been updated by asomers:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=b551cb063c5efe66a634b5afded901a0323bcee2
>
> commit b551cb063c5efe66a634b5afded901a0323bcee2
> Author:     Alan Somers <asomers@FreeBSD.org>
> AuthorDate: 2026-09-04 20:48:41 +0000
> Commit:     Alan Somers <asomers@FreeBSD.org>
> CommitDate: 2026-09-04 21:12:46 +0000
>
>    During shutdown, announce each file system as it's unmounted.
>
>    But only if debug.bootverbose=1.
>
>    MFC after:      2 weeks
>    Sponsored by:   ConnectWise
> ---
> sys/kern/vfs_subr.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c
> index 8d6793ad9573..f324e02e44d7 100644
> --- a/sys/kern/vfs_subr.c
> +++ b/sys/kern/vfs_subr.c
> @@ -5143,11 +5151,20 @@ vfs_unmountall(void)
> 		if (mp == rootdevmp)
> 			continue;
>
> +		if (bootverbose) {
> +			printf("\tUnmounting %d/%d %s\n", ++n, nmountpoints,
> +				mp->mnt_stat.f_mntonname);
> +		}
> 		unmount_or_warn(mp);
> 	}
>
> -	if (rootdevmp != NULL)
> +	if (rootdevmp != NULL) {
> +		if (bootverbose) {
> +			printf("\tUnmounting %d/%d %s\n", ++n, nmountpoints,
> +				rootdevmp->mnt_stat.f_mntonname);
> +		}
> 		unmount_or_warn(rootdevmp);
> +	}
> }
>
> static void


Is there a reason this needs to be \t indented?

..
Syncing disks, vnodes remaining... 0 0 done
All buffers synced.
         Unmounting 1/2 /
         Unmounting 2/2 /dev
Uptime: 1d7h36m47s
uhub0: detached

Just looks weird there...

-- 
For there shall arise false Christs, and false prophets, and shall shew
great signs and wonders; insomuch that, if it were possible, they shall
deceive the very elect. Behold, I have told you before. [Mat. 24:24-25]