From nobody Sun Sep 13 12:33:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hjSPC5sXgz6rcr3 for ; Sun, 13 Sep 2026 12:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hjSPC4dwLz4qg1 for ; Sun, 13 Sep 2026 12:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789302799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1jBpQk/sbhckkSwesvxAkYHJl6BGmJO8wIheOKElhq8=; b=NzC4ltS1ccogGUoK5lY/lckk8JZQBKUeMb1PCDlLP/qV6idGMAwsq3gdIgPHYAe4hcZLta TpxRFNipGwFOvW3b8nwUmMMnfE/P2lSl3U2NU5E4FT9CoQ+uxt2gJTwW00kgDmE1AmRE9n 6atiwiXWakLjdeRbrjX8VJuq2pOfzigNBrzAeAFnFJWAF5FPYYIBtMDGk0fuWnzEczTS/B pQtdrggNTcP2f7An8N765YsD+6cFSAcbdAfyU+08CM+edpA8c6sDXS8eOndy16VHB1SgGf RuAg/qmaC1linBJ48SZDwCrJ+qaAz3aaGVRKFmSJep37UAba+xBXZ23d78tR4A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789302799; b=L+Sj/dsg5kRcrwtnMNcNPQusA/7PnKc5NhPdNdryJdUBV+CvQNky1p6evrWhj5dRconzyj O7V4k6Oymf4vrpSjIVJErzoDM1KzHV04qczItEi+NpfyBXOzSR7+tCcoYtEPMHODVSaN5y QaNyFhQ6EyNnqs9hVSSdQBxe+f9oANVQL0KQfkwcq9dZlSKjNvJInAIyWAWmoyK/14uQvT V57q+FjSGHdRKu2TEmgMYzZkl5FzznqM5Mk0OhEWzKwPYcqHsoIqsmkH7UEHD6rH76ktaU PFKoQlkcPiUHjsFDa2gH3i/9IdjcwkLyyW+YENzKQxD+1tKXeFuylGQAHwxipg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789302799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1jBpQk/sbhckkSwesvxAkYHJl6BGmJO8wIheOKElhq8=; b=w48hSOhe0UydUCd0/u14J9/7YoOKTS3kL/XMVc0S9MaY1DccgnYz2hhu4/LnERs1XaRV9C fdb5DRjfhxW8MHuIy8URLEAlrBO8akmDLlBNLrn7hkGH4NY6OzQzmeWPvKnzvzk3dN8x8s sZfEx/yZ5cHqbjNe3I2p3VUG8IfuVn0ynqgqgx2u3ReyA3NePlWhEYwLtVchAmANf6NE5T cRWW3JNLCXGrzW51uqk3MqsWzh9pAZUGZ4Y7JkLFjbaLTpii8VeVrK6REEqmFsaGHLfyvK 7zaULHROBoBVhkmbvMW72eNVj/yDzh1FfYugn3csi9jMa9PTJ+58za6hucfS9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hjSPC3kqrzjQH for ; Sun, 13 Sep 2026 12:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1dda0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 13 Sep 2026 12:33:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Faraz Vahedi Subject: git: 73d3c964be93 - main - libc: Preserve const qualifier on strchr(3), strrchr(3), and memchr(3) results List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kfv X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 73d3c964be93034daf26a55ebac38c2152769f74 Auto-Submitted: auto-generated Date: Sun, 13 Sep 2026 12:33:19 +0000 Message-Id: <6aa6980f.1dda0.476905db@gitrepo.freebsd.org> The branch main has been updated by kfv: URL: https://cgit.FreeBSD.org/src/commit/?id=73d3c964be93034daf26a55ebac38c2152769f74 commit 73d3c964be93034daf26a55ebac38c2152769f74 Author: Faraz Vahedi AuthorDate: 2026-09-13 12:27:45 +0000 Commit: Faraz Vahedi CommitDate: 2026-09-13 12:33:00 +0000 libc: Preserve const qualifier on strchr(3), strrchr(3), and memchr(3) results Reviewed by: dteske, fuz Approved by: dteske (mentor), fuz (mentor) MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D59612 --- lib/libc/gen/getgrent.c | 4 ++-- lib/libc/gen/syslog.c | 3 ++- lib/libc/iconv/bsd_iconv.c | 3 +-- lib/libc/iconv/citrus_prop.c | 2 +- lib/libc/inet/inet_cidr_pton.c | 3 ++- lib/libc/nameser/ns_name.c | 2 +- lib/libc/net/base64.c | 2 +- lib/libc/net/getaddrinfo.c | 7 ++++--- lib/libc/net/rcmdsh.c | 2 +- lib/libc/stdio/mktemp.c | 2 +- 10 files changed, 16 insertions(+), 14 deletions(-) diff --git a/lib/libc/gen/getgrent.c b/lib/libc/gen/getgrent.c index 8819708556b9..ee73c7eb6d39 100644 --- a/lib/libc/gen/getgrent.c +++ b/lib/libc/gen/getgrent.c @@ -1313,10 +1313,10 @@ compat_group(void *retval, void *mdata, va_list ap) }; struct compat_state *st; enum nss_lookup_type how; - const char *name, *line; + const char *name, *line, *p; struct group *grp; gid_t gid; - char *buffer, *p; + char *buffer; void *discard; size_t bufsize, linesize; off_t pos; diff --git a/lib/libc/gen/syslog.c b/lib/libc/gen/syslog.c index a6290ee81a29..98b5056c65d5 100644 --- a/lib/libc/gen/syslog.c +++ b/lib/libc/gen/syslog.c @@ -467,7 +467,8 @@ setlogmask(int pmask) static void parse_tag(void) { - char *begin, *end, *p; + const char *begin, *end; + char *p; pid_t pid; if (LogTag == NULL || (LogStat & LOG_PID) != 0) diff --git a/lib/libc/iconv/bsd_iconv.c b/lib/libc/iconv/bsd_iconv.c index d3da6fd1a271..fb92b8f48ad0 100644 --- a/lib/libc/iconv/bsd_iconv.c +++ b/lib/libc/iconv/bsd_iconv.c @@ -250,8 +250,7 @@ __bsd_iconvctl(iconv_t cd, int request, void *argument) { struct _citrus_iconv *cv; struct iconv_hooks *hooks; - const char *convname; - char *dst; + const char *convname, *dst; int *i; size_t srclen; diff --git a/lib/libc/iconv/citrus_prop.c b/lib/libc/iconv/citrus_prop.c index 6dadce92e3eb..5f01f1f29df4 100644 --- a/lib/libc/iconv/citrus_prop.c +++ b/lib/libc/iconv/citrus_prop.c @@ -81,7 +81,7 @@ _citrus_prop_read_##_func_##_common(struct _memstream * __restrict ms, \ { \ _type_ acc, cutoff; \ int ch, cutlim, n; \ - char *p; \ + const char *p; \ \ acc = (_type_)0; \ cutoff = _max_ / base; \ diff --git a/lib/libc/inet/inet_cidr_pton.c b/lib/libc/inet/inet_cidr_pton.c index e24efcedc935..1d07e5c9e677 100644 --- a/lib/libc/inet/inet_cidr_pton.c +++ b/lib/libc/inet/inet_cidr_pton.c @@ -251,7 +251,8 @@ inet_cidr_pton_ipv6(const char *src, u_char *dst, int *pbits) { static int getbits(const char *src, int ipv6) { int bits = 0; - char *cp, ch; + const char *cp; + char ch; if (*src == '\0') /*%< syntax */ return (-2); diff --git a/lib/libc/nameser/ns_name.c b/lib/libc/nameser/ns_name.c index ab6a81ed7b4e..35dc5fbd4fd5 100644 --- a/lib/libc/nameser/ns_name.c +++ b/lib/libc/nameser/ns_name.c @@ -216,7 +216,7 @@ int ns_name_pton2(const char *src, u_char *dst, size_t dstsiz, size_t *dstlen) { u_char *label, *bp, *eom; int c, n, escaped, e = 0; - char *cp; + const char *cp; escaped = 0; bp = dst; diff --git a/lib/libc/net/base64.c b/lib/libc/net/base64.c index f508275e4eb9..a0712f575e76 100644 --- a/lib/libc/net/base64.c +++ b/lib/libc/net/base64.c @@ -193,7 +193,7 @@ b64_pton(const char *src, u_char *target, size_t targsize) { int tarindex, state, ch; u_char nextbyte; - char *pos; + const char *pos; state = 0; tarindex = 0; diff --git a/lib/libc/net/getaddrinfo.c b/lib/libc/net/getaddrinfo.c index b8af23ebe8da..64e7f30ff412 100644 --- a/lib/libc/net/getaddrinfo.c +++ b/lib/libc/net/getaddrinfo.c @@ -272,7 +272,7 @@ static int is_ifdisabled(char *); static void set_source(struct ai_order *, struct policyhead *); static int comp_dst(const void *, const void *); #ifdef INET6 -static int ip6_str2scopeid(char *, struct sockaddr_in6 *, u_int32_t *); +static int ip6_str2scopeid(const char *, struct sockaddr_in6 *, u_int32_t *); #endif static int gai_addr2scopetype(struct sockaddr *); @@ -1338,7 +1338,8 @@ explore_numeric_scope(const struct addrinfo *pai, const char *hostname, const struct afd *afd; struct addrinfo *cur; int error; - char *cp, *hostname2 = NULL, *scope, *addr; + char *hostname2 = NULL, *addr; + const char *cp, *scope; struct sockaddr_in6 *sin6; afd = find_afd(pai->ai_family); @@ -1682,7 +1683,7 @@ is_ifdisabled(char *name) /* convert a string to a scope identifier. XXX: IPv6 specific */ static int -ip6_str2scopeid(char *scope, struct sockaddr_in6 *sin6, u_int32_t *scopeid) +ip6_str2scopeid(const char *scope, struct sockaddr_in6 *sin6, u_int32_t *scopeid) { u_long lscopeid; struct in6_addr *a6; diff --git a/lib/libc/net/rcmdsh.c b/lib/libc/net/rcmdsh.c index 7e400e99cb3b..509490cfe459 100644 --- a/lib/libc/net/rcmdsh.c +++ b/lib/libc/net/rcmdsh.c @@ -62,7 +62,7 @@ rcmdsh(char **ahost, int rport, const char *locuser, const char *remuser, struct addrinfo hints, *res; int sp[2], error; pid_t cpid; - char *p; + const char *p; struct passwd *pw; char num[8]; static char hbuf[NI_MAXHOST]; diff --git a/lib/libc/stdio/mktemp.c b/lib/libc/stdio/mktemp.c index a2f80ee7b0dd..827d686bdaa8 100644 --- a/lib/libc/stdio/mktemp.c +++ b/lib/libc/stdio/mktemp.c @@ -113,7 +113,7 @@ static int _gettemp(int dfd, char *path, int *doopen, int domkdir, int slen, int oflags) { char *start, *trv, *suffp, *carryp; - char *pad; + const char *pad; struct stat sbuf; uint32_t rand; char carrybuf[MAXPATHLEN];